The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Ruslan Bilovol <ruslan.bilovol@gmail.com>
Cc: Jorge Sanjuan <jorge.sanjuan@codethink.co.uk>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] ALSA: usb-audio: Insertion Control for BADD Adaptors.
Date: Thu, 14 Jun 2018 22:12:47 +0200	[thread overview]
Message-ID: <s5hh8m5uny8.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAB=otbRkXJwMUXebJuLtVaZkUG-RY=O65rRNT9oL+u2_cipgXQ@mail.gmail.com>

On Thu, 14 Jun 2018 21:18:10 +0200,
Ruslan Bilovol wrote:
> 
> On Thu, Jun 14, 2018 at 7:07 PM, Takashi Iwai <tiwai@suse.de> wrote:
> > On Thu, 14 Jun 2018 16:05:54 +0200,
> > Jorge Sanjuan wrote:
> >>
> >> Thanks for review!
> >>
> >> Here is what's new in this V2:
> >>  - Split the patchset into a more sensible series.
> >>
> >> This patchset adds support for the Insertion Control for BADD devices
> >> (subset of UAC3).
> >>
> >> This control is only pressent in the HEADSET ADAPTER BADD profile. The USB
> >> interrupt pipe shall be present for this profile so the status pipe
> >> creation should also happen for BADD devices.
> >>
> >> Also, the bi-directional type codes have been defined so they can be used
> >> as inferred values for the Input and Output terminals for this adapter
> >> profile.
> >>
> >> Based on tag: next-20180612
> >>
> >> Jorge Sanjuan (4):
> >>   ALSA: usb-audio: Add bi-directional terminal types.
> >>   ALSA: usb-audio: Change in connectors control creation interface
> >>   ALSA: usb-audio: UAC3. Add insertion control for BADD.
> >>   ALSA: usb-audio: Always create the interrupt pipe for the mixer
> >
> > Thanks, this looks nicer, each of changes is smaller and clearer.
> > Although it's a bit too late for the merge window, this is a change
> > that is fairly safe for the existing UAC1/UAC2, I merged it now.
> >
> 
> It's too late probably, but I just finished reviewing these patches
> and don't have any objections.

Yeah, I already pushed out.  But thanks for reviewing.


Takashi

      reply	other threads:[~2018-06-14 20:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12 14:31 [PATCH 0/2] ALSA: usb-audio: Insertion Control for BADD Adaptors Jorge Sanjuan
2018-06-12 14:32 ` [PATCH 1/2] ALSA: usb-audio: Add bi-directional terminal types Jorge Sanjuan
2018-06-12 14:32 ` [PATCH 2/2] ALSA: usb-audio: UAC3. Add insertion control for BADD Jorge Sanjuan
2018-06-14 12:34   ` Takashi Iwai
2018-06-14 14:05 ` [PATCH v2 0/4] ALSA: usb-audio: Insertion Control for BADD Adaptors Jorge Sanjuan
2018-06-14 14:05   ` [PATCH v2 1/4] ALSA: usb-audio: Add bi-directional terminal types Jorge Sanjuan
2018-06-14 14:05   ` [PATCH v2 2/4] ALSA: usb-audio: Change in connectors control creation interface Jorge Sanjuan
2018-06-14 14:05   ` [PATCH v2 3/4] ALSA: usb-audio: UAC3. Add insertion control for BADD Jorge Sanjuan
2018-06-14 14:05   ` [PATCH v2 4/4] ALSA: usb-audio: Always create the interrupt pipe for the mixer Jorge Sanjuan
2018-06-14 16:07   ` [PATCH v2 0/4] ALSA: usb-audio: Insertion Control for BADD Adaptors Takashi Iwai
2018-06-14 19:18     ` Ruslan Bilovol
2018-06-14 20:12       ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hh8m5uny8.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=jorge.sanjuan@codethink.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ruslan.bilovol@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox