From: Takashi Iwai <tiwai@suse.de>
To: Jorge Sanjuan <jorge.sanjuan@codethink.co.uk>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
ruslan.bilovol@gmail.com
Subject: Re: [PATCH 2/2] ALSA: usb-audio: UAC3. Add insertion control for BADD.
Date: Thu, 14 Jun 2018 14:34:02 +0200 [thread overview]
Message-ID: <s5hvaal35tx.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180612143201.29988-3-jorge.sanjuan@codethink.co.uk>
On Tue, 12 Jun 2018 16:32:01 +0200,
Jorge Sanjuan wrote:
>
> The HEADSET ADAPTER profile for BADD devices is meant to support
> Insertion Control for the Input and Output Terminals of the headset.
> Furthermore, this profile may also include the interrupt status pipe
> to report changes on these terminals.
>
> This patch creates the jack-detect controls for the Headset Adapter
> profile and enables the interrupt status pipe creation for BADD devices.
>
> Signed-off-by: Jorge Sanjuan <jorge.sanjuan@codethink.co.uk>
The changes look good, but I'd prefer splitting this:
- A preliminary work to change get_connector_control_name() and
build_connector_control() to receive usb_mixer_interface;
this is no functional change
- Add build_connector_control() calls for UAC3 BADD
- Apply snd_usb_mixer_status_create() for UAC3 BADD, too
thanks,
Takashi
next prev parent reply other threads:[~2018-06-14 12:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 14:31 [PATCH 0/2] ALSA: usb-audio: Insertion Control for BADD Adaptors Jorge Sanjuan
2018-06-12 14:32 ` [PATCH 1/2] ALSA: usb-audio: Add bi-directional terminal types Jorge Sanjuan
2018-06-12 14:32 ` [PATCH 2/2] ALSA: usb-audio: UAC3. Add insertion control for BADD Jorge Sanjuan
2018-06-14 12:34 ` Takashi Iwai [this message]
2018-06-14 14:05 ` [PATCH v2 0/4] ALSA: usb-audio: Insertion Control for BADD Adaptors Jorge Sanjuan
2018-06-14 14:05 ` [PATCH v2 1/4] ALSA: usb-audio: Add bi-directional terminal types Jorge Sanjuan
2018-06-14 14:05 ` [PATCH v2 2/4] ALSA: usb-audio: Change in connectors control creation interface Jorge Sanjuan
2018-06-14 14:05 ` [PATCH v2 3/4] ALSA: usb-audio: UAC3. Add insertion control for BADD Jorge Sanjuan
2018-06-14 14:05 ` [PATCH v2 4/4] ALSA: usb-audio: Always create the interrupt pipe for the mixer Jorge Sanjuan
2018-06-14 16:07 ` [PATCH v2 0/4] ALSA: usb-audio: Insertion Control for BADD Adaptors Takashi Iwai
2018-06-14 19:18 ` Ruslan Bilovol
2018-06-14 20:12 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hvaal35tx.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=jorge.sanjuan@codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=ruslan.bilovol@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox