[PATCH] sound/oss/dmasound: Remove superfluous "break"

[PATCH] sound/oss/dmasound: Remove superfluous "break"

[zuoqilin1]

From: zuoqilin <zuoqilin@yulong.com>

Remove superfluous "break", as there is a "return" before them.

Signed-off-by: zuoqilin <zuoqilin@yulong.com>
---
 sound/oss/dmasound/dmasound_core.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/sound/oss/dmasound/dmasound_core.c b/sound/oss/dmasound/dmasound_core.c
index 49679aa..22cef0c 100644
--- a/sound/oss/dmasound/dmasound_core.c
+++ b/sound/oss/dmasound/dmasound_core.c
@@ -999,11 +999,9 @@ static int sq_ioctl(struct file *file, u_int cmd, u_long arg)
 	case SNDCTL_DSP_RESET:
 		sq_reset();
 		return 0;
-		break ;
 	case SNDCTL_DSP_GETFMTS:
 		fmt = dmasound.mach.hardware_afmts ; /* this is what OSS says.. */
 		return IOCTL_OUT(arg, fmt);
-		break ;
 	case SNDCTL_DSP_GETBLKSIZE:
 		/* this should tell the caller about bytes that the app can
 		   read/write - the app doesn't care about our internal buffers.
@@ -1020,7 +1018,6 @@ static int sq_ioctl(struct file *file, u_int cmd, u_long arg)
 			size = write_sq.user_frag_size ;
 		}
 		return IOCTL_OUT(arg, size);
-		break ;
 	case SNDCTL_DSP_POST:
 		/* all we are going to do is to tell the LL that any
 		   partial frags can be queued for output.
@@ -1044,7 +1041,6 @@ static int sq_ioctl(struct file *file, u_int cmd, u_long arg)
 		if (file->f_mode & shared_resource_owner)
 			shared_resources_initialised = 0 ;
 		return result ;
-		break ;
 	case SOUND_PCM_READ_RATE:
 		return IOCTL_OUT(arg, dmasound.soft.speed);
 	case SNDCTL_DSP_SPEED:
@@ -1123,7 +1119,6 @@ static int sq_ioctl(struct file *file, u_int cmd, u_long arg)
 		   the value is 'random' and that the user _must_ check the actual
 		   frags values using SNDCTL_DSP_GETBLKSIZE or similar */
 		return IOCTL_OUT(arg, data);
-		break ;
 	case SNDCTL_DSP_GETOSPACE:
 		/*
 		*/
-- 
1.9.1

Re: [PATCH] sound/oss/dmasound: Remove superfluous "break"

[Takashi Iwai]

On Mon, 24 May 2021 09:00:28 +0200,
zuoqilin1@163.com wrote:
> 
> From: zuoqilin <zuoqilin@yulong.com>
> 
> Remove superfluous "break", as there is a "return" before them.
> 
> Signed-off-by: zuoqilin <zuoqilin@yulong.com>

Thanks, applied.


Takashi

[PATCH] sound/oss/dmasound: Remove superfluous "break"

[zuoqilin1]

From: zuoqilin <zuoqilin@yulong.com>

Remove superfluous "break", as there is a "return" before them.

Signed-off-by: zuoqilin <zuoqilin@yulong.com>
---
 sound/oss/dmasound/dmasound_core.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/sound/oss/dmasound/dmasound_core.c b/sound/oss/dmasound/dmasound_core.c
index 22cef0c..0c95828 100644
--- a/sound/oss/dmasound/dmasound_core.c
+++ b/sound/oss/dmasound/dmasound_core.c
@@ -1229,31 +1229,22 @@ static char *get_afmt_string(int afmt)
         switch(afmt) {
             case AFMT_MU_LAW:
                 return "mu-law";
-                break;
             case AFMT_A_LAW:
                 return "A-law";
-                break;
             case AFMT_U8:
                 return "unsigned 8 bit";
-                break;
             case AFMT_S8:
                 return "signed 8 bit";
-                break;
             case AFMT_S16_BE:
                 return "signed 16 bit BE";
-                break;
             case AFMT_U16_BE:
                 return "unsigned 16 bit BE";
-                break;
             case AFMT_S16_LE:
                 return "signed 16 bit LE";
-                break;
             case AFMT_U16_LE:
                 return "unsigned 16 bit LE";
-                break;
 	    case 0:
 		return "format not set" ;
-		break ;
             default:
                 break ;
         }
-- 
1.9.1

Re: [PATCH] sound/oss/dmasound: Remove superfluous "break"

[Takashi Iwai]

On Thu, 27 May 2021 05:04:45 +0200,
zuoqilin1@163.com wrote:
> 
> From: zuoqilin <zuoqilin@yulong.com>
> 
> Remove superfluous "break", as there is a "return" before them.
> 
> Signed-off-by: zuoqilin <zuoqilin@yulong.com>

Thanks, applied.


Takashi