* [PATCH 2/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 445 G8
2021-06-29 8:28 [PATCH 1/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8 Andy Chi
@ 2021-06-29 8:28 ` Andy Chi
2021-06-29 8:28 ` [PATCH 3/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 630 G8 Andy Chi
2021-07-01 6:42 ` [PATCH 1/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8 Takashi Iwai
2 siblings, 0 replies; 4+ messages in thread
From: Andy Chi @ 2021-06-29 8:28 UTC (permalink / raw)
Cc: andy.chi, Jaroslav Kysela, Takashi Iwai, Kailang Yang, Hui Wang,
Jeremy Szu, Jian-Hong Pan, Chris Chiu, Huacai Chen, Sami Loone,
alsa-devel, linux-kernel
The HP ProBook 445 G8 using ALC236 codec.
COEF index 0x34 bit 5 is used to control the playback mute LED, but the
microphone mute LED is controlled using pin VREF instead of a COEF index.
Therefore, add a quirk to make it works.
Signed-off-by: Andy Chi <andy.chi@canonical.com>
---
sound/pci/hda/patch_realtek.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 9c3bb1a2b849..25a32b718fbc 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8344,6 +8344,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x884b, "HP EliteBook 840 Aero G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8862, "HP ProBook 445 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+ SND_PCI_QUIRK(0x103c, 0x8863, "HP ProBook 445 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x886d, "HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
SND_PCI_QUIRK(0x103c, 0x8870, "HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
SND_PCI_QUIRK(0x103c, 0x8873, "HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 3/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 630 G8
2021-06-29 8:28 [PATCH 1/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8 Andy Chi
2021-06-29 8:28 ` [PATCH 2/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 445 G8 Andy Chi
@ 2021-06-29 8:28 ` Andy Chi
2021-07-01 6:42 ` [PATCH 1/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8 Takashi Iwai
2 siblings, 0 replies; 4+ messages in thread
From: Andy Chi @ 2021-06-29 8:28 UTC (permalink / raw)
Cc: andy.chi, Jaroslav Kysela, Takashi Iwai, Kailang Yang, Jeremy Szu,
Hui Wang, Jian-Hong Pan, Chris Chiu, Huacai Chen, Sami Loone,
alsa-devel, linux-kernel
The HP ProBook 630 G8 using ALC236 codec which using 0x02 to
control mute LED and 0x01 to control micmute LED.
Therefore, add a quirk to make it works.
Signed-off-by: Andy Chi <andy.chi@canonical.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 25a32b718fbc..58e185c6e77f 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8337,6 +8337,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87e7, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x87f1, "HP ProBook 630 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f2, "HP ProBook 640 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8
2021-06-29 8:28 [PATCH 1/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8 Andy Chi
2021-06-29 8:28 ` [PATCH 2/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 445 G8 Andy Chi
2021-06-29 8:28 ` [PATCH 3/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 630 G8 Andy Chi
@ 2021-07-01 6:42 ` Takashi Iwai
2 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-07-01 6:42 UTC (permalink / raw)
To: Andy Chi
Cc: Jaroslav Kysela, Takashi Iwai, Kailang Yang, Jeremy Szu, Hui Wang,
Jian-Hong Pan, Chris Chiu, Huacai Chen, Sami Loone, alsa-devel,
linux-kernel
On Tue, 29 Jun 2021 10:28:57 +0200,
Andy Chi wrote:
>
> The HP ProBook 450 G8 using ALC236 codec which using 0x02 to
> control mute LED and 0x01 to control micmute LED.
> Therefore, add a quirk to make it works.
>
> Signed-off-by: Andy Chi <andy.chi@canonical.com>
The patch series (at least the patch 2) doesn't seem cleanly
applicable via git-am. Could you check your MUA setup?
thanks,
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread