* Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671
[not found] <tencent_080B040F1CE2D7D83D6FD0C8@qq.com>
@ 2022-03-11 8:30 ` Takashi Iwai
0 siblings, 0 replies; 8+ messages in thread
From: Takashi Iwai @ 2022-03-11 8:30 UTC (permalink / raw)
To: huangwenhui
Cc: perex, tiwai, jeremy.szu, hui.wang, wse, cam, kailang, tanureal,
sami, alsa-devel, linux-kernel
On Fri, 11 Mar 2022 02:20:42 +0100,
huangwenhui wrote:
>
> Hi Takashi,
>
> if adjusting the mixer element or replugging the headset, the headphone would
> be unmuted.
> But most users hope that the default state is unmuted.
> Should this unconditional unmute be required?
It's the standard behavior for most of ALSA drivers.
The initial mute state is rather controlled via alsactl, restoring the
previous state. Also, the sound server like PulseAudio or pipewire
does unmute automatically. If this doesn't work as expected, that's a
more problem to diagnose.
Takashi
>
> Thanks.
>
> ------------------ Original ------------------
> From: "Takashi Iwai"<tiwai@suse.de>;
> Date: Thu, Mar 10, 2022 10:03 PM
> To: "黄文辉"<huangwenhuia@uniontech.com>;
> Cc: "perex"<perex@perex.cz>; "tiwai"<tiwai@suse.com>; "jeremy.szu"
> <jeremy.szu@canonical.com>; "hui.wang"<hui.wang@canonical.com>; "wse"
> <wse@tuxedocomputers.com>; "cam"<cam@neo-zeon.de>; "kailang"
> <kailang@realtek.com>; "tanureal"<tanureal@opensource.cirrus.com>; "sami"
> <sami@loone.fi>; "alsa-devel"<alsa-devel@alsa-project.org>; "linux-kernel"
> <linux-kernel@vger.kernel.org>;
> Subject: Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP
> machine with alc671
>
> On Thu, 10 Mar 2022 14:58:36 +0100,
> huangwenhui wrote:
> >
> > Hi Takashi,
> >
> > Thank you for your reply.
> >
> > When booting with plugged headset, the headphone will be muted.
>
> The muted state is the default behavior. Wouldn't it be unmuted if
> you adjust the corresponding mixer element?
>
> Takashi
>
> >
> > Thanks.
> >
> > ------------------ Original ------------------
> > From: "Takashi Iwai"<tiwai@suse.de>;
> > Date: Thu, Mar 10, 2022 09:29 PM
> > To: "huangwenhui"<huangwenhuia@uniontech.com>;
> > Cc: "perex"<perex@perex.cz>; "tiwai"<tiwai@suse.com>; "jeremy.szu"
> > <jeremy.szu@canonical.com>; "hui.wang"<hui.wang@canonical.com>; "wse"
> > <wse@tuxedocomputers.com>; "cam"<cam@neo-zeon.de>; "kailang"
> > <kailang@realtek.com>; "tanureal"<tanureal@opensource.cirrus.com>; "sami"
> > <sami@loone.fi>; "alsa-devel"<alsa-devel@alsa-project.org>; "linux-kernel"
> > <linux-kernel@vger.kernel.org>;
> > Subject: Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP
> > machine with alc671
> >
> > On Thu, 10 Mar 2022 14:03:01 +0100,
> > huangwenhui wrote:
> > >
> > > On a HP 288 Pro G8, the front Mic could not be detected.
> > >
> > > Signed-off-by: huangwenhui <huangwenhuia@uniontech.com>
> >
> > Thanks for the patch. Most of the changes look OK, but one thing I
> > still don't get:
> >
> > > + case HDA_FIXUP_ACT_INIT:
> > > + alc_write_coef_idx(codec, 0x19, 0xa054);
> > > + msleep(80);
> > > + snd_hda_codec_write(codec, hp_pin, 0,
> > > + AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE);
> >
> > Why this unconditional unmute is required for fixing the mic problem?
> >
> > Takashi
> >
> >
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671
@ 2022-07-12 9:22 Meng Tang
2022-07-12 9:31 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: Meng Tang @ 2022-07-12 9:22 UTC (permalink / raw)
To: perex, tiwai, tcrawford, kai.heng.feng, tanureal, cam, kailang,
sbinding, andy.chi, yong.wu
Cc: alsa-devel, linux-kernel, Meng Tang
On a HP 288 Pro G6, the front mic could not be detected.In order to
get it working, the pin configuration needs to be set correctly, and
the ALC671_FIXUP_HP_HEADSET_MIC2 fixup needs to be applied.
Signed-off-by: Meng Tang <tangmeng@uniontech.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index ecc737342fcc..34139c26795f 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -11219,6 +11219,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x1632, "HP RP5800", ALC662_FIXUP_HP_RP5800),
SND_PCI_QUIRK(0x103c, 0x8719, "HP", ALC897_FIXUP_HP_HSMIC_VERB),
SND_PCI_QUIRK(0x103c, 0x873e, "HP", ALC671_FIXUP_HP_HEADSET_MIC2),
+ SND_PCI_QUIRK(0x103c, 0x877e, "HP 288 Pro G6", ALC671_FIXUP_HP_HEADSET_MIC2),
SND_PCI_QUIRK(0x103c, 0x885f, "HP 288 Pro G8", ALC671_FIXUP_HP_HEADSET_MIC2),
SND_PCI_QUIRK(0x1043, 0x1080, "Asus UX501VW", ALC668_FIXUP_HEADSET_MODE),
SND_PCI_QUIRK(0x1043, 0x11cd, "Asus N550", ALC662_FIXUP_ASUS_Nx50),
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671
2022-07-12 9:22 Meng Tang
@ 2022-07-12 9:31 ` Takashi Iwai
0 siblings, 0 replies; 8+ messages in thread
From: Takashi Iwai @ 2022-07-12 9:31 UTC (permalink / raw)
To: Meng Tang
Cc: perex, tiwai, tcrawford, kai.heng.feng, tanureal, cam, kailang,
sbinding, andy.chi, yong.wu, alsa-devel, linux-kernel
On Tue, 12 Jul 2022 11:22:22 +0200,
Meng Tang wrote:
>
> On a HP 288 Pro G6, the front mic could not be detected.In order to
> get it working, the pin configuration needs to be set correctly, and
> the ALC671_FIXUP_HP_HEADSET_MIC2 fixup needs to be applied.
>
> Signed-off-by: Meng Tang <tangmeng@uniontech.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671
@ 2022-03-11 9:38 huangwenhui
2022-03-11 16:05 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: huangwenhui @ 2022-03-11 9:38 UTC (permalink / raw)
To: perex, tiwai
Cc: jeremy.szu, hui.wang, wse, cam, kailang, tanureal, sami,
alsa-devel, linux-kernel, huangwenhui
On a HP 288 Pro G8, the front mic could not be detected.In order to
get it working, the pin configuration needs to be set correctly, and
the ALC671_FIXUP_HP_HEADSET_MIC2 fixup needs to be applied.
Signed-off-by: huangwenhui <huangwenhuia@uniontech.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 3a42457984e9..e9c9b1d1bf0d 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -11067,6 +11067,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = {
SND_PCI_QUIRK(0x1028, 0x069f, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x103c, 0x1632, "HP RP5800", ALC662_FIXUP_HP_RP5800),
SND_PCI_QUIRK(0x103c, 0x873e, "HP", ALC671_FIXUP_HP_HEADSET_MIC2),
+ SND_PCI_QUIRK(0x103c, 0x885f, "HP 288 Pro G8", ALC671_FIXUP_HP_HEADSET_MIC2),
SND_PCI_QUIRK(0x1043, 0x1080, "Asus UX501VW", ALC668_FIXUP_HEADSET_MODE),
SND_PCI_QUIRK(0x1043, 0x11cd, "Asus N550", ALC662_FIXUP_ASUS_Nx50),
SND_PCI_QUIRK(0x1043, 0x129d, "Asus N750", ALC662_FIXUP_ASUS_Nx50),
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671
2022-03-11 9:38 huangwenhui
@ 2022-03-11 16:05 ` Takashi Iwai
0 siblings, 0 replies; 8+ messages in thread
From: Takashi Iwai @ 2022-03-11 16:05 UTC (permalink / raw)
To: huangwenhui
Cc: perex, tiwai, jeremy.szu, hui.wang, wse, cam, kailang, tanureal,
sami, alsa-devel, linux-kernel
On Fri, 11 Mar 2022 10:38:36 +0100,
huangwenhui wrote:
>
> On a HP 288 Pro G8, the front mic could not be detected.In order to
> get it working, the pin configuration needs to be set correctly, and
> the ALC671_FIXUP_HP_HEADSET_MIC2 fixup needs to be applied.
>
> Signed-off-by: huangwenhui <huangwenhuia@uniontech.com>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671
@ 2022-03-10 13:03 huangwenhui
2022-03-10 13:29 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: huangwenhui @ 2022-03-10 13:03 UTC (permalink / raw)
To: perex, tiwai
Cc: jeremy.szu, hui.wang, wse, cam, kailang, tanureal, sami,
alsa-devel, linux-kernel, huangwenhui
On a HP 288 Pro G8, the front Mic could not be detected.
Signed-off-by: huangwenhui <huangwenhuia@uniontech.com>
---
sound/pci/hda/patch_realtek.c | 37 +++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 3a42457984e9..bcd56cdc07af 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10519,6 +10519,37 @@ static void alc671_fixup_hp_headset_mic2(struct hda_codec *codec,
}
}
+static void alc671_fixup_hp288_headset_mic2(struct hda_codec *codec,
+ const struct hda_fixup *fix, int action)
+{
+ struct alc_spec *spec = codec->spec;
+ hda_nid_t hp_pin = alc_get_hp_pin(spec);
+
+ static const struct hda_pintbl pincfgs[] = {
+ { 0x19, 0x02a11040 }, /* use as headset mic, with its own jack detect */
+ { 0x1b, 0x0181304f },
+ { }
+ };
+
+ if (!hp_pin)
+ hp_pin = 0x21;
+
+ switch (action) {
+ case HDA_FIXUP_ACT_PRE_PROBE:
+ spec->gen.mixer_nid = 0;
+ spec->parse_flags |= HDA_PINCFG_HEADSET_MIC;
+ snd_hda_apply_pincfgs(codec, pincfgs);
+ break;
+ case HDA_FIXUP_ACT_INIT:
+ alc_write_coef_idx(codec, 0x19, 0xa054);
+ msleep(80);
+ snd_hda_codec_write(codec, hp_pin, 0,
+ AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE);
+ msleep(100);
+ break;
+ }
+}
+
static void alc897_hp_automute_hook(struct hda_codec *codec,
struct hda_jack_callback *jack)
{
@@ -10615,6 +10646,7 @@ enum {
ALC669_FIXUP_ACER_ASPIRE_ETHOS,
ALC669_FIXUP_ACER_ASPIRE_ETHOS_HEADSET,
ALC671_FIXUP_HP_HEADSET_MIC2,
+ ALC671_FIXUP_HP288_HEADSET_MIC2,
ALC662_FIXUP_ACER_X2660G_HEADSET_MODE,
ALC662_FIXUP_ACER_NITRO_HEADSET_MODE,
ALC668_FIXUP_ASUS_NO_HEADSET_MIC,
@@ -10986,6 +11018,10 @@ static const struct hda_fixup alc662_fixups[] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc671_fixup_hp_headset_mic2,
},
+ [ALC671_FIXUP_HP288_HEADSET_MIC2] = {
+ .type = HDA_FIXUP_FUNC,
+ .v.func = alc671_fixup_hp288_headset_mic2,
+ },
[ALC662_FIXUP_ACER_X2660G_HEADSET_MODE] = {
.type = HDA_FIXUP_PINS,
.v.pins = (const struct hda_pintbl[]) {
@@ -11067,6 +11103,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = {
SND_PCI_QUIRK(0x1028, 0x069f, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x103c, 0x1632, "HP RP5800", ALC662_FIXUP_HP_RP5800),
SND_PCI_QUIRK(0x103c, 0x873e, "HP", ALC671_FIXUP_HP_HEADSET_MIC2),
+ SND_PCI_QUIRK(0x103c, 0x885f, "HP 288 Pro G8", ALC671_FIXUP_HP288_HEADSET_MIC2),
SND_PCI_QUIRK(0x1043, 0x1080, "Asus UX501VW", ALC668_FIXUP_HEADSET_MODE),
SND_PCI_QUIRK(0x1043, 0x11cd, "Asus N550", ALC662_FIXUP_ASUS_Nx50),
SND_PCI_QUIRK(0x1043, 0x129d, "Asus N750", ALC662_FIXUP_ASUS_Nx50),
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671
2022-03-10 13:03 huangwenhui
@ 2022-03-10 13:29 ` Takashi Iwai
[not found] ` <tencent_0D06988048F675F173385A1F@qq.com>
0 siblings, 1 reply; 8+ messages in thread
From: Takashi Iwai @ 2022-03-10 13:29 UTC (permalink / raw)
To: huangwenhui
Cc: perex, tiwai, jeremy.szu, hui.wang, wse, cam, kailang, tanureal,
sami, alsa-devel, linux-kernel
On Thu, 10 Mar 2022 14:03:01 +0100,
huangwenhui wrote:
>
> On a HP 288 Pro G8, the front Mic could not be detected.
>
> Signed-off-by: huangwenhui <huangwenhuia@uniontech.com>
Thanks for the patch. Most of the changes look OK, but one thing I
still don't get:
> + case HDA_FIXUP_ACT_INIT:
> + alc_write_coef_idx(codec, 0x19, 0xa054);
> + msleep(80);
> + snd_hda_codec_write(codec, hp_pin, 0,
> + AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE);
Why this unconditional unmute is required for fixing the mic problem?
Takashi
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-07-12 9:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <tencent_080B040F1CE2D7D83D6FD0C8@qq.com>
2022-03-11 8:30 ` [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671 Takashi Iwai
2022-07-12 9:22 Meng Tang
2022-07-12 9:31 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2022-03-11 9:38 huangwenhui
2022-03-11 16:05 ` Takashi Iwai
2022-03-10 13:03 huangwenhui
2022-03-10 13:29 ` Takashi Iwai
[not found] ` <tencent_0D06988048F675F173385A1F@qq.com>
2022-03-10 14:02 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox