From: Takashi Iwai <tiwai@suse.de>
To: Coiby Xu <coiby.xu@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org (moderated list:SOUND),
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH 01/25] ALSA: core: pcm: remove unnecessary CONFIG_PM_SLEEP
Date: Thu, 29 Oct 2020 08:48:55 +0100 [thread overview]
Message-ID: <s5hpn51wjyw.wl-tiwai@suse.de> (raw)
In-Reply-To: <20201029074301.226644-1-coiby.xu@gmail.com>
On Thu, 29 Oct 2020 08:42:37 +0100,
Coiby Xu wrote:
>
> SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
>
> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
It caused compile warnings. Was it already addressed in general?
Or we may use __maybe_unused attribute instead, but it's just a matter
of taste.
thanks,
Takashi
> ---
> sound/core/pcm.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/core/pcm.c b/sound/core/pcm.c
> index be5714f1bb58..5a281ac92958 100644
> --- a/sound/core/pcm.c
> +++ b/sound/core/pcm.c
> @@ -599,7 +599,6 @@ static const struct attribute_group *pcm_dev_attr_groups[];
> * PM callbacks: we need to deal only with suspend here, as the resume is
> * triggered either from user-space or the driver's resume callback
> */
> -#ifdef CONFIG_PM_SLEEP
> static int do_pcm_suspend(struct device *dev)
> {
> struct snd_pcm_str *pstr = container_of(dev, struct snd_pcm_str, dev);
> @@ -608,7 +607,6 @@ static int do_pcm_suspend(struct device *dev)
> snd_pcm_suspend_all(pstr->pcm);
> return 0;
> }
> -#endif
>
> static const struct dev_pm_ops pcm_dev_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(do_pcm_suspend, NULL)
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-10-29 7:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 7:42 [PATCH 01/25] ALSA: core: pcm: remove unnecessary CONFIG_PM_SLEEP Coiby Xu
2020-10-29 7:42 ` [PATCH 02/25] ASoC: fsl: fsl_ssi: " Coiby Xu
2020-10-29 7:42 ` [PATCH 03/25] ASoC: fsl: " Coiby Xu
2020-10-29 7:42 ` [PATCH 04/25] ASoC: rockchip: " Coiby Xu
2020-10-29 10:33 ` Robin Murphy
2020-10-29 14:23 ` Coiby Xu
2020-10-29 7:42 ` [PATCH 05/25] ASoC: img: " Coiby Xu
2020-10-29 7:42 ` [PATCH 06/25] ASoC: img-spdif-in: " Coiby Xu
2020-10-29 7:42 ` [PATCH 07/25] ASoC: img-spdif-out: " Coiby Xu
2020-10-29 7:42 ` [PATCH 08/25] ASoC: img-i2s-out: " Coiby Xu
2020-10-29 7:42 ` [PATCH 09/25] ASoC: tegra: " Coiby Xu
2020-10-29 7:42 ` [PATCH 10/25] " Coiby Xu
2020-10-29 7:42 ` [PATCH 11/25] ASoC: hdac: " Coiby Xu
2020-10-29 7:42 ` [PATCH 12/25] ASoC: stm32: sai: " Coiby Xu
2020-10-29 7:42 ` [PATCH 13/25] ASoC: stm32: spdifrx: " Coiby Xu
2020-10-29 7:42 ` [PATCH 14/25] ASoC: stm32: i2s: " Coiby Xu
2020-10-29 7:42 ` [PATCH 15/25] ASoC: stm32: sai: " Coiby Xu
2020-10-29 7:42 ` [PATCH 16/25] ASoC: sirf: " Coiby Xu
2020-10-29 7:42 ` [PATCH 17/25] ASoC: hdac_hdmi: " Coiby Xu
2020-10-29 7:42 ` [PATCH 18/25] ASoC: codecs: max98373: " Coiby Xu
2020-10-29 7:42 ` [PATCH 19/25] ASoC: sirf-audio: " Coiby Xu
2020-10-29 7:42 ` [PATCH 20/25] ASoC: max98390: " Coiby Xu
2020-10-29 7:42 ` [PATCH 21/25] ASoC: codecs: max98090: " Coiby Xu
2020-10-29 7:42 ` [PATCH 22/25] ASoC: max98927: " Coiby Xu
2020-10-29 7:42 ` [PATCH 23/25] ASoC: ts3a227e: " Coiby Xu
2020-10-29 7:43 ` [PATCH 24/25] ASoC: wm8994: " Coiby Xu
2020-10-29 15:55 ` Charles Keepax
2020-10-29 7:43 ` [PATCH 25/25] ALSA: aoa: " Coiby Xu
2020-10-29 7:48 ` Takashi Iwai [this message]
2020-10-29 14:37 ` [PATCH 01/25] ALSA: core: pcm: " Coiby Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hpn51wjyw.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=coiby.xu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox