From: Takashi Iwai <tiwai@suse.de>
To: PC Liao <pc.liao@mediatek.com>
Cc: <broonie@kernel.org>, <srv_heupstream@mediatek.com>,
<linux-mediatek@lists.infradead.org>, <s.hauer@pengutronix.de>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<koro.chen@mediatek.com>,
Hidalgo Huang <hidalgo.huang@mediatek.com>
Subject: Re: [PATCH] ASoC: mediatek: Enable 33bit memory address to support 4GB DRAM
Date: Mon, 11 Jan 2016 10:02:21 +0100 [thread overview]
Message-ID: <s5hwprgcwv6.wl-tiwai@suse.de> (raw)
In-Reply-To: <1452499250-5202-1-git-send-email-pc.liao@mediatek.com>
On Mon, 11 Jan 2016 09:00:50 +0100,
PC Liao wrote:
>
> @@ -603,7 +606,10 @@ static int mtk_afe_dais_hw_params(struct snd_pcm_substream *substream,
> if (ret < 0)
> return ret;
>
> - memif->phys_buf_addr = substream->runtime->dma_addr;
> + if (sizeof(dma_addr_t) > 4)
> + msb_at_bit33 = (substream->runtime->dma_addr & 0x100000000) ? 1 : 0;
Better to put a proper suffix for the constant over 32bit.
Or use upper_32_bits(). Then sizeof() check can be omitted, as the
compiler should be smart enough to know it beforehand.
Takashi
next prev parent reply other threads:[~2016-01-11 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 8:00 [PATCH] ASoC: mediatek: Enable 33bit memory address to support 4GB DRAM PC Liao
2016-01-11 9:02 ` Takashi Iwai [this message]
2016-01-12 2:54 ` PC Liao
2016-01-12 5:42 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwprgcwv6.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hidalgo.huang@mediatek.com \
--cc=koro.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=pc.liao@mediatek.com \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox