drivers/scsi/aic7xxx/aic7xxx_core.c -Werror causes build to stop

drivers/scsi/aic7xxx/aic7xxx_core.c -Werror causes build to stop

[Kees Bakker]

To build 2.5.73 using my SuSE 8.2 system (gcc 3.3) I need the following
patch:

--- linux-2.5.73/drivers/scsi/aic7xxx/Makefile.orig	2003-06-22 20:33:34.000000000 +0200
+++ linux-2.5.73/drivers/scsi/aic7xxx/Makefile	2003-06-27 10:38:40.000000000 +0200
@@ -33,7 +33,7 @@
 						   aic79xx_proc.o	\
 						   aic79xx_osm_pci.o
 
-EXTRA_CFLAGS += -Idrivers/scsi -Werror
+EXTRA_CFLAGS += -Idrivers/scsi -Werror -Wno-sign-compare
 #EXTRA_CFLAGS += -g
 
 # Files generated that shall be removed upon make clean
--- linux-2.5.73/drivers/scsi/aic7xxx/aic7xxx_core.c.orig	2003-06-22 20:32:43.000000000 +0200
+++ linux-2.5.73/drivers/scsi/aic7xxx/aic7xxx_core.c	2003-06-27 11:35:37.000000000 +0200
@@ -73,7 +73,6 @@
 	"aic7892",
 	"aic7899"
 };
-static const u_int num_chip_names = NUM_ELEMENTS(ahc_chip_names);
 
 /*
  * Hardware error codes.

Re: drivers/scsi/aic7xxx/aic7xxx_core.c -Werror causes build to stop

[Adrian Bunk]

On Fri, Jun 27, 2003 at 12:17:19PM +0200, Kees Bakker wrote:
> To build 2.5.73 using my SuSE 8.2 system (gcc 3.3) I need the following
> patch:
> 
> --- linux-2.5.73/drivers/scsi/aic7xxx/Makefile.orig	2003-06-22 20:33:34.000000000 +0200
> +++ linux-2.5.73/drivers/scsi/aic7xxx/Makefile	2003-06-27 10:38:40.000000000 +0200
> @@ -33,7 +33,7 @@
>  						   aic79xx_proc.o	\
>  						   aic79xx_osm_pci.o
>  
> -EXTRA_CFLAGS += -Idrivers/scsi -Werror
> +EXTRA_CFLAGS += -Idrivers/scsi -Werror -Wno-sign-compare
>  #EXTRA_CFLAGS += -g
>  
>  # Files generated that shall be removed upon make clean
>...

The -Wno-sign-compare is not needed with the official gcc 3.3 release. 
It's only needed for beta versions of gcc 3.3 .

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed