* [PATCH v2 0/2] Add support for Amediatech X98Q (Amlogic S905W2)
@ 2026-04-20 6:18 christian.koever-draxl
2026-04-20 6:18 ` [PATCH v2 1/2] dt-bindings: arm: amlogic: add X98Q compatible christian.koever-draxl
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: christian.koever-draxl @ 2026-04-20 6:18 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, neil.armstrong, khilman
Cc: jbrunet, martin.blumenstingl, funderscore, devicetree,
linux-kernel, linux-arm-kernel, linux-amlogic,
christian.koever-draxl
From: Christian Stefan Kövér-Draxl <christian.koever-draxl@student.uibk.ac.at>
Supported features:
- 1GB/2GB RAM (via U-Boot memory fixup)
- 10/100 Ethernet (Internal PHY)
- eMMC and SD card storage
- PWM-based CPU voltage regulation
- UART (Serial console)
Changes in v2:
- Split dt-bindings and dts changes into separate patches.
- Updated model string to match documented vendor prefix.
- Put vddio_sd states array in a single line.
- Added a clarifying comment for the unsupported Amlogic W150S1 Wi-Fi module.
Notes:
- The console uses uart_b at 921600 baud.
- Verified memory via /proc/device-tree; U-Boot patches the node to around 2GB.
- Tested on the 2GB RAM plus 16GB eMMC variant.
Christian Stefan Kövér-Draxl (2):
dt-bindings: arm: amlogic: add X98Q compatible
arm64: dts: amlogic: add support for X98Q
.../devicetree/bindings/arm/amlogic.yaml | 7 +
arch/arm64/boot/dts/amlogic/Makefile | 1 +
.../boot/dts/amlogic/meson-s4-s905w2-x98q.dts | 250 ++++++++++++++++++
3 files changed, 258 insertions(+)
create mode 100644 arch/arm64/boot/dts/amlogic/meson-s4-s905w2-x98q.dts
--
2.53.0
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2 1/2] dt-bindings: arm: amlogic: add X98Q compatible 2026-04-20 6:18 [PATCH v2 0/2] Add support for Amediatech X98Q (Amlogic S905W2) christian.koever-draxl @ 2026-04-20 6:18 ` christian.koever-draxl 2026-04-20 16:11 ` Conor Dooley 2026-04-20 6:18 ` [PATCH v2 2/2] arm64: dts: amlogic: add support for X98Q christian.koever-draxl 2026-04-20 9:56 ` [PATCH v2 0/2] Add support for Amediatech X98Q (Amlogic S905W2) Ferass El Hafidi 2 siblings, 1 reply; 7+ messages in thread From: christian.koever-draxl @ 2026-04-20 6:18 UTC (permalink / raw) To: robh, krzk+dt, conor+dt, neil.armstrong, khilman Cc: jbrunet, martin.blumenstingl, funderscore, devicetree, linux-kernel, linux-arm-kernel, linux-amlogic, christian.koever-draxl From: Christian Stefan Kövér-Draxl <christian.koever-draxl@student.uibk.ac.at> Signed-off-by: Christian Stefan Kövér-Draxl <christian.koever-draxl@student.uibk.ac.at> --- Documentation/devicetree/bindings/arm/amlogic.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml index a885278bc4e2..82671d58d1da 100644 --- a/Documentation/devicetree/bindings/arm/amlogic.yaml +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml @@ -254,6 +254,13 @@ properties: - khadas,vim1s - const: amlogic,s905y4 - const: amlogic,s4 + + - description: Boards with the Amlogic Meson S4 S905W2 SoC + items: + - enum: + - amediatech,x98q + - const: amlogic,s905w2 + - const: amlogic,s4 - description: Boards with the Amlogic S6 S905X5 SoC items: -- 2.53.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add X98Q compatible 2026-04-20 6:18 ` [PATCH v2 1/2] dt-bindings: arm: amlogic: add X98Q compatible christian.koever-draxl @ 2026-04-20 16:11 ` Conor Dooley 0 siblings, 0 replies; 7+ messages in thread From: Conor Dooley @ 2026-04-20 16:11 UTC (permalink / raw) To: christian.koever-draxl Cc: robh, krzk+dt, conor+dt, neil.armstrong, khilman, jbrunet, martin.blumenstingl, funderscore, devicetree, linux-kernel, linux-arm-kernel, linux-amlogic [-- Attachment #1: Type: text/plain, Size: 1257 bytes --] On Mon, Apr 20, 2026 at 08:18:53AM +0200, christian.koever-draxl@student.uibk.ac.at wrote: > From: Christian Stefan Kövér-Draxl <christian.koever-draxl@student.uibk.ac.at> > Even if a patch is simple, you still need a commit message. pw-bot: changes-requested Cheers, Conor. > Signed-off-by: Christian Stefan Kövér-Draxl <christian.koever-draxl@student.uibk.ac.at> > --- > Documentation/devicetree/bindings/arm/amlogic.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml > index a885278bc4e2..82671d58d1da 100644 > --- a/Documentation/devicetree/bindings/arm/amlogic.yaml > +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml > @@ -254,6 +254,13 @@ properties: > - khadas,vim1s > - const: amlogic,s905y4 > - const: amlogic,s4 > + > + - description: Boards with the Amlogic Meson S4 S905W2 SoC > + items: > + - enum: > + - amediatech,x98q > + - const: amlogic,s905w2 > + - const: amlogic,s4 > > - description: Boards with the Amlogic S6 S905X5 SoC > items: > -- > 2.53.0 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] arm64: dts: amlogic: add support for X98Q 2026-04-20 6:18 [PATCH v2 0/2] Add support for Amediatech X98Q (Amlogic S905W2) christian.koever-draxl 2026-04-20 6:18 ` [PATCH v2 1/2] dt-bindings: arm: amlogic: add X98Q compatible christian.koever-draxl @ 2026-04-20 6:18 ` christian.koever-draxl 2026-04-20 10:43 ` Ferass El Hafidi 2026-04-21 10:22 ` Krzysztof Kozlowski 2026-04-20 9:56 ` [PATCH v2 0/2] Add support for Amediatech X98Q (Amlogic S905W2) Ferass El Hafidi 2 siblings, 2 replies; 7+ messages in thread From: christian.koever-draxl @ 2026-04-20 6:18 UTC (permalink / raw) To: robh, krzk+dt, conor+dt, neil.armstrong, khilman Cc: jbrunet, martin.blumenstingl, funderscore, devicetree, linux-kernel, linux-arm-kernel, linux-amlogic, christian.koever-draxl From: Christian Stefan Kövér-Draxl <christian.koever-draxl@student.uibk.ac.at> Signed-off-by: Christian Stefan Kövér-Draxl <christian.koever-draxl@student.uibk.ac.at> --- arch/arm64/boot/dts/amlogic/Makefile | 1 + .../boot/dts/amlogic/meson-s4-s905w2-x98q.dts | 250 ++++++++++++++++++ 2 files changed, 251 insertions(+) create mode 100644 arch/arm64/boot/dts/amlogic/meson-s4-s905w2-x98q.dts diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile index 15f9c817e502..c7752684dea6 100644 --- a/arch/arm64/boot/dts/amlogic/Makefile +++ b/arch/arm64/boot/dts/amlogic/Makefile @@ -85,6 +85,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-ugoos-am3.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxm-vega-s96.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxm-wetek-core2.dtb dtb-$(CONFIG_ARCH_MESON) += meson-s4-s805x2-aq222.dtb +dtb-$(CONFIG_ARCH_MESON) += meson-s4-s905w2-x98q.dtb dtb-$(CONFIG_ARCH_MESON) += meson-s4-s905y4-khadas-vim1s.dtb dtb-$(CONFIG_ARCH_MESON) += meson-sm1-a95xf3-air-gbit.dtb dtb-$(CONFIG_ARCH_MESON) += meson-sm1-a95xf3-air.dtb diff --git a/arch/arm64/boot/dts/amlogic/meson-s4-s905w2-x98q.dts b/arch/arm64/boot/dts/amlogic/meson-s4-s905w2-x98q.dts new file mode 100644 index 000000000000..26c60a4c2a43 --- /dev/null +++ b/arch/arm64/boot/dts/amlogic/meson-s4-s905w2-x98q.dts @@ -0,0 +1,250 @@ + +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2026 Christian Stefan Köver-Draxl + * Based on meson-s4-s905y4-khadas-vim1s.dts: + * - Copyright (c) 2026 Khadas Technology Co., Ltd. + */ + +/dts-v1/; + +#include "meson-s4.dtsi" + +/ { + model = "Shenzhen Amediatech Technology Co., Ltd X98Q"; + compatible = "amediatech,x98q", "amlogic,s905w2", "amlogic,s4"; + interrupt-parent = <&gic>; + #address-cells = <2>; + #size-cells = <2>; + + aliases { + mmc0 = &emmc; /* eMMC */ + mmc1 = &sd; /* SD card */ + mmc2 = &sdio; /* SDIO */ + serial0 = &uart_b; + }; + + memory@0 { + device_type = "memory"; + reg = <0x0 0x0 0x0 0x40000000>; + }; + + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + /* 52 MiB reserved for ARM Trusted Firmware */ + secmon_reserved: secmon@5000000 { + reg = <0x0 0x05000000 0x0 0x3400000>; + no-map; + }; + }; + + emmc_pwrseq: emmc-pwrseq { + compatible = "mmc-pwrseq-emmc"; + reset-gpios = <&gpio GPIOB_9 GPIO_ACTIVE_LOW>; + }; + + sdio_32k: sdio-32k { + compatible = "pwm-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + pwms = <&pwm_ef 0 30518 0>; /* PWM_E at 32.768KHz */ + }; + + sdio_pwrseq: sdio-pwrseq { + compatible = "mmc-pwrseq-simple"; + reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>; + clocks = <&sdio_32k>; + clock-names = "ext_clock"; + }; + + main_5v: regulator-main-5v { + compatible = "regulator-fixed"; + regulator-name = "5V"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-always-on; + }; + + sd_3v3: regulator-sd-3v3 { + compatible = "regulator-fixed"; + regulator-name = "SD_3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&gpio GPIOD_4 GPIO_ACTIVE_LOW>; + regulator-always-on; + }; + + vddio_sd: regulator-vddio-sd { + compatible = "regulator-gpio"; + regulator-name = "VDDIO_SD"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + gpios = <&gpio GPIOD_9 GPIO_ACTIVE_HIGH>; + gpios-states = <1>; + states = <1800000 1 3300000 0>; + }; + + vddao_3v3: regulator-vddao-3v3 { + compatible = "regulator-fixed"; + regulator-name = "VDDAO_3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + vin-supply = <&main_5v>; + regulator-always-on; + }; + + vddio_ao1v8: regulator-vddio-ao1v8 { + compatible = "regulator-fixed"; + regulator-name = "VDDIO_AO1V8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + vin-supply = <&vddao_3v3>; + regulator-always-on; + }; + + /* SY8120B1ABC DC/DC Regulator. */ + vddcpu: regulator-vddcpu { + compatible = "pwm-regulator"; + + regulator-name = "VDDCPU"; + regulator-min-microvolt = <689000>; + regulator-max-microvolt = <1049000>; + + vin-supply = <&main_5v>; + + pwms = <&pwm_ij 1 1500 0>; + pwm-dutycycle-range = <100 0>; + + regulator-boot-on; + regulator-always-on; + /* Voltage Duty-Cycle */ + voltage-table = <1049000 0>, + <1039000 3>, + <1029000 6>, + <1019000 9>, + <1009000 12>, + <999000 14>, + <989000 17>, + <979000 20>, + <969000 23>, + <959000 26>, + <949000 29>, + <939000 31>, + <929000 34>, + <919000 37>, + <909000 40>, + <899000 43>, + <889000 45>, + <879000 48>, + <869000 51>, + <859000 54>, + <849000 56>, + <839000 59>, + <829000 62>, + <819000 65>, + <809000 68>, + <799000 70>, + <789000 73>, + <779000 76>, + <769000 79>, + <759000 81>, + <749000 84>, + <739000 87>, + <729000 89>, + <719000 92>, + <709000 95>, + <699000 98>, + <689000 100>; + }; +}; + +&emmc { + status = "okay"; + pinctrl-0 = <&emmc_pins>, <&emmc_ds_pins>; + pinctrl-1 = <&emmc_clk_gate_pins>; + pinctrl-names = "default", "clk-gate"; + + bus-width = <8>; + cap-mmc-highspeed; + mmc-ddr-1_8v; + mmc-hs200-1_8v; + max-frequency = <200000000>; + non-removable; + disable-wp; + + mmc-pwrseq = <&emmc_pwrseq>; + vmmc-supply = <&vddao_3v3>; + vqmmc-supply = <&vddio_ao1v8>; +}; + +ðmac { + status = "okay"; + phy-handle = <&internal_ephy>; + phy-mode = "rmii"; +}; + +&ir { + status = "okay"; + pinctrl-0 = <&remote_pins>; + pinctrl-names = "default"; +}; + +&pwm_ef { + status = "okay"; + pinctrl-0 = <&pwm_e_pins1>; + pinctrl-names = "default"; +}; + +&pwm_ij { + status = "okay"; +}; + +&sd { + status = "okay"; + pinctrl-0 = <&sdcard_pins>; + pinctrl-1 = <&sdcard_clk_gate_pins>; + pinctrl-names = "default", "clk-gate"; + bus-width = <4>; + cap-sd-highspeed; + max-frequency = <50000000>; + disable-wp; + + cd-gpios = <&gpio GPIOC_6 GPIO_ACTIVE_LOW>; + + vmmc-supply = <&vddao_3v3>; + vqmmc-supply = <&vddao_3v3>; +}; + +/* +* Wireless SDIO Module (Amlogic W150S1) +* Note: There is no driver for this at the moment. +*/ + +&sdio { + status = "okay"; + pinctrl-0 = <&sdio_pins>; + pinctrl-1 = <&sdio_clk_gate_pins>; + pinctrl-names = "default", "clk-gate"; + #address-cells = <1>; + #size-cells = <0>; + bus-width = <4>; + cap-sd-highspeed; + sd-uhs-sdr50; + sd-uhs-sdr104; + max-frequency = <200000000>; + non-removable; + disable-wp; + + no-sd; + no-mmc; + mmc-pwrseq = <&sdio_pwrseq>; + vmmc-supply = <&vddao_3v3>; + vqmmc-supply = <&vddio_ao1v8>; +}; + +&uart_b { + status = "okay"; +}; -- 2.53.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: amlogic: add support for X98Q 2026-04-20 6:18 ` [PATCH v2 2/2] arm64: dts: amlogic: add support for X98Q christian.koever-draxl @ 2026-04-20 10:43 ` Ferass El Hafidi 2026-04-21 10:22 ` Krzysztof Kozlowski 1 sibling, 0 replies; 7+ messages in thread From: Ferass El Hafidi @ 2026-04-20 10:43 UTC (permalink / raw) To: linux-amlogic, christian.koever-draxl, robh, krzk+dt, conor+dt, neil.armstrong, khilman Cc: jbrunet, martin.blumenstingl, funderscore, devicetree, linux-kernel, linux-arm-kernel, linux-amlogic, christian.koever-draxl On Mon, 20 Apr 2026 06:18, christian.koever-draxl@student.uibk.ac.at wrote: >From: Christian Stefan Kövér-Draxl <christian.koever-draxl@student.uibk.ac.at> > >Signed-off-by: Christian Stefan Kövér-Draxl <christian.koever-draxl@student.uibk.ac.at> >--- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > .../boot/dts/amlogic/meson-s4-s905w2-x98q.dts | 250 ++++++++++++++++++ > 2 files changed, 251 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-s4-s905w2-x98q.dts > >diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile >index 15f9c817e502..c7752684dea6 100644 >--- a/arch/arm64/boot/dts/amlogic/Makefile >+++ b/arch/arm64/boot/dts/amlogic/Makefile >@@ -85,6 +85,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-ugoos-am3.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-vega-s96.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-wetek-core2.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-s4-s805x2-aq222.dtb >+dtb-$(CONFIG_ARCH_MESON) += meson-s4-s905w2-x98q.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-s4-s905y4-khadas-vim1s.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-sm1-a95xf3-air-gbit.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-sm1-a95xf3-air.dtb >diff --git a/arch/arm64/boot/dts/amlogic/meson-s4-s905w2-x98q.dts b/arch/arm64/boot/dts/amlogic/meson-s4-s905w2-x98q.dts >new file mode 100644 >index 000000000000..26c60a4c2a43 >--- /dev/null >+++ b/arch/arm64/boot/dts/amlogic/meson-s4-s905w2-x98q.dts >@@ -0,0 +1,250 @@ >+ nit: Trailing newline >+// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >+/* >+ * Copyright (c) 2026 Christian Stefan Köver-Draxl >+ * Based on meson-s4-s905y4-khadas-vim1s.dts: >+ * - Copyright (c) 2026 Khadas Technology Co., Ltd. >+ */ >+ >+/dts-v1/; >+ >+#include "meson-s4.dtsi" >+ >+/ { >+ model = "Shenzhen Amediatech Technology Co., Ltd X98Q"; >+ compatible = "amediatech,x98q", "amlogic,s905w2", "amlogic,s4"; >+ interrupt-parent = <&gic>; >+ #address-cells = <2>; >+ #size-cells = <2>; >+ >+ aliases { >+ mmc0 = &emmc; /* eMMC */ >+ mmc1 = &sd; /* SD card */ >+ mmc2 = &sdio; /* SDIO */ >+ serial0 = &uart_b; >+ }; >+ >+ memory@0 { >+ device_type = "memory"; >+ reg = <0x0 0x0 0x0 0x40000000>; >+ }; >+ >+ reserved-memory { >+ #address-cells = <2>; >+ #size-cells = <2>; >+ ranges; >+ >+ /* 52 MiB reserved for ARM Trusted Firmware */ >+ secmon_reserved: secmon@5000000 { >+ reg = <0x0 0x05000000 0x0 0x3400000>; >+ no-map; >+ }; >+ }; >+ >+ emmc_pwrseq: emmc-pwrseq { >+ compatible = "mmc-pwrseq-emmc"; >+ reset-gpios = <&gpio GPIOB_9 GPIO_ACTIVE_LOW>; >+ }; >+ >+ sdio_32k: sdio-32k { >+ compatible = "pwm-clock"; >+ #clock-cells = <0>; >+ clock-frequency = <32768>; >+ pwms = <&pwm_ef 0 30518 0>; /* PWM_E at 32.768KHz */ >+ }; >+ >+ sdio_pwrseq: sdio-pwrseq { >+ compatible = "mmc-pwrseq-simple"; >+ reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>; >+ clocks = <&sdio_32k>; >+ clock-names = "ext_clock"; >+ }; >+ >+ main_5v: regulator-main-5v { >+ compatible = "regulator-fixed"; >+ regulator-name = "5V"; >+ regulator-min-microvolt = <5000000>; >+ regulator-max-microvolt = <5000000>; >+ regulator-always-on; >+ }; >+ >+ sd_3v3: regulator-sd-3v3 { >+ compatible = "regulator-fixed"; >+ regulator-name = "SD_3V3"; >+ regulator-min-microvolt = <3300000>; >+ regulator-max-microvolt = <3300000>; >+ gpio = <&gpio GPIOD_4 GPIO_ACTIVE_LOW>; >+ regulator-always-on; >+ }; >+ >+ vddio_sd: regulator-vddio-sd { >+ compatible = "regulator-gpio"; >+ regulator-name = "VDDIO_SD"; >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <3300000>; >+ gpios = <&gpio GPIOD_9 GPIO_ACTIVE_HIGH>; >+ gpios-states = <1>; >+ states = <1800000 1 3300000 0>; >+ }; >+ >+ vddao_3v3: regulator-vddao-3v3 { >+ compatible = "regulator-fixed"; >+ regulator-name = "VDDAO_3V3"; >+ regulator-min-microvolt = <3300000>; >+ regulator-max-microvolt = <3300000>; >+ vin-supply = <&main_5v>; >+ regulator-always-on; >+ }; >+ >+ vddio_ao1v8: regulator-vddio-ao1v8 { >+ compatible = "regulator-fixed"; >+ regulator-name = "VDDIO_AO1V8"; >+ regulator-min-microvolt = <1800000>; >+ regulator-max-microvolt = <1800000>; >+ vin-supply = <&vddao_3v3>; >+ regulator-always-on; >+ }; >+ >+ /* SY8120B1ABC DC/DC Regulator. */ >+ vddcpu: regulator-vddcpu { >+ compatible = "pwm-regulator"; >+ >+ regulator-name = "VDDCPU"; >+ regulator-min-microvolt = <689000>; >+ regulator-max-microvolt = <1049000>; >+ >+ vin-supply = <&main_5v>; >+ >+ pwms = <&pwm_ij 1 1500 0>; >+ pwm-dutycycle-range = <100 0>; >+ >+ regulator-boot-on; >+ regulator-always-on; >+ /* Voltage Duty-Cycle */ >+ voltage-table = <1049000 0>, >+ <1039000 3>, >+ <1029000 6>, >+ <1019000 9>, >+ <1009000 12>, >+ <999000 14>, >+ <989000 17>, >+ <979000 20>, >+ <969000 23>, >+ <959000 26>, >+ <949000 29>, >+ <939000 31>, >+ <929000 34>, >+ <919000 37>, >+ <909000 40>, >+ <899000 43>, >+ <889000 45>, >+ <879000 48>, >+ <869000 51>, >+ <859000 54>, >+ <849000 56>, >+ <839000 59>, >+ <829000 62>, >+ <819000 65>, >+ <809000 68>, >+ <799000 70>, >+ <789000 73>, >+ <779000 76>, >+ <769000 79>, >+ <759000 81>, >+ <749000 84>, >+ <739000 87>, >+ <729000 89>, >+ <719000 92>, >+ <709000 95>, >+ <699000 98>, >+ <689000 100>; >+ }; >+}; >+ >+&emmc { >+ status = "okay"; >+ pinctrl-0 = <&emmc_pins>, <&emmc_ds_pins>; >+ pinctrl-1 = <&emmc_clk_gate_pins>; >+ pinctrl-names = "default", "clk-gate"; >+ >+ bus-width = <8>; >+ cap-mmc-highspeed; >+ mmc-ddr-1_8v; >+ mmc-hs200-1_8v; >+ max-frequency = <200000000>; >+ non-removable; >+ disable-wp; >+ >+ mmc-pwrseq = <&emmc_pwrseq>; >+ vmmc-supply = <&vddao_3v3>; >+ vqmmc-supply = <&vddio_ao1v8>; >+}; >+ >+ðmac { >+ status = "okay"; >+ phy-handle = <&internal_ephy>; >+ phy-mode = "rmii"; >+}; >+ >+&ir { >+ status = "okay"; >+ pinctrl-0 = <&remote_pins>; >+ pinctrl-names = "default"; >+}; >+ >+&pwm_ef { >+ status = "okay"; >+ pinctrl-0 = <&pwm_e_pins1>; >+ pinctrl-names = "default"; >+}; >+ >+&pwm_ij { >+ status = "okay"; >+}; >+ >+&sd { >+ status = "okay"; >+ pinctrl-0 = <&sdcard_pins>; >+ pinctrl-1 = <&sdcard_clk_gate_pins>; >+ pinctrl-names = "default", "clk-gate"; >+ bus-width = <4>; >+ cap-sd-highspeed; >+ max-frequency = <50000000>; >+ disable-wp; >+ >+ cd-gpios = <&gpio GPIOC_6 GPIO_ACTIVE_LOW>; >+ >+ vmmc-supply = <&vddao_3v3>; >+ vqmmc-supply = <&vddao_3v3>; >+}; >+ >+/* >+* Wireless SDIO Module (Amlogic W150S1) >+* Note: There is no driver for this at the moment. >+*/ Align like this: /* * Wireless SDIO Module (Amlogic W150S1) * Note: There is no driver for this at the moment. */ >+ >+&sdio { >+ status = "okay"; >+ pinctrl-0 = <&sdio_pins>; >+ pinctrl-1 = <&sdio_clk_gate_pins>; >+ pinctrl-names = "default", "clk-gate"; >+ #address-cells = <1>; >+ #size-cells = <0>; >+ bus-width = <4>; >+ cap-sd-highspeed; >+ sd-uhs-sdr50; >+ sd-uhs-sdr104; >+ max-frequency = <200000000>; >+ non-removable; >+ disable-wp; >+ >+ no-sd; >+ no-mmc; >+ mmc-pwrseq = <&sdio_pwrseq>; >+ vmmc-supply = <&vddao_3v3>; >+ vqmmc-supply = <&vddio_ao1v8>; >+}; >+ >+&uart_b { >+ status = "okay"; >+}; >-- >2.53.0 -- Best regards, Ferass ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: amlogic: add support for X98Q 2026-04-20 6:18 ` [PATCH v2 2/2] arm64: dts: amlogic: add support for X98Q christian.koever-draxl 2026-04-20 10:43 ` Ferass El Hafidi @ 2026-04-21 10:22 ` Krzysztof Kozlowski 1 sibling, 0 replies; 7+ messages in thread From: Krzysztof Kozlowski @ 2026-04-21 10:22 UTC (permalink / raw) To: christian.koever-draxl, robh, krzk+dt, conor+dt, neil.armstrong, khilman Cc: jbrunet, martin.blumenstingl, funderscore, devicetree, linux-kernel, linux-arm-kernel, linux-amlogic On 20/04/2026 08:18, christian.koever-draxl@student.uibk.ac.at wrote: > From: Christian Stefan Kövér-Draxl <christian.koever-draxl@student.uibk.ac.at> > > Signed-off-by: Christian Stefan Kövér-Draxl <christian.koever-draxl@student.uibk.ac.at> > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > .../boot/dts/amlogic/meson-s4-s905w2-x98q.dts | 250 ++++++++++++++++++ > 2 files changed, 251 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-s4-s905w2-x98q.dts > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > index 15f9c817e502..c7752684dea6 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -85,6 +85,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-ugoos-am3.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-vega-s96.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-wetek-core2.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-s4-s805x2-aq222.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-s4-s905w2-x98q.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-s4-s905y4-khadas-vim1s.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-sm1-a95xf3-air-gbit.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-sm1-a95xf3-air.dtb > diff --git a/arch/arm64/boot/dts/amlogic/meson-s4-s905w2-x98q.dts b/arch/arm64/boot/dts/amlogic/meson-s4-s905w2-x98q.dts > new file mode 100644 > index 000000000000..26c60a4c2a43 > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-s4-s905w2-x98q.dts > @@ -0,0 +1,250 @@ > + > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) You have still the same warnings as before. Fix them ALL, not just one warning. Are you sure you tested your work with standard tools? Please run scripts/checkpatch.pl on the patches and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' on the patches and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 0/2] Add support for Amediatech X98Q (Amlogic S905W2) 2026-04-20 6:18 [PATCH v2 0/2] Add support for Amediatech X98Q (Amlogic S905W2) christian.koever-draxl 2026-04-20 6:18 ` [PATCH v2 1/2] dt-bindings: arm: amlogic: add X98Q compatible christian.koever-draxl 2026-04-20 6:18 ` [PATCH v2 2/2] arm64: dts: amlogic: add support for X98Q christian.koever-draxl @ 2026-04-20 9:56 ` Ferass El Hafidi 2 siblings, 0 replies; 7+ messages in thread From: Ferass El Hafidi @ 2026-04-20 9:56 UTC (permalink / raw) To: linux-amlogic, christian.koever-draxl, robh, krzk+dt, conor+dt, neil.armstrong, khilman Cc: jbrunet, martin.blumenstingl, funderscore, devicetree, linux-kernel, linux-arm-kernel, linux-amlogic, christian.koever-draxl Hi, On Mon, 20 Apr 2026 06:18, christian.koever-draxl@student.uibk.ac.at wrote: >From: Christian Stefan Kövér-Draxl <christian.koever-draxl@student.uibk.ac.at> > >Supported features: >- 1GB/2GB RAM (via U-Boot memory fixup) >- 10/100 Ethernet (Internal PHY) >- eMMC and SD card storage >- PWM-based CPU voltage regulation >- UART (Serial console) > >Changes in v2: >- Split dt-bindings and dts changes into separate patches. >- Updated model string to match documented vendor prefix. >- Put vddio_sd states array in a single line. >- Added a clarifying comment for the unsupported Amlogic W150S1 Wi-Fi module. > >Notes: >- The console uses uart_b at 921600 baud. >- Verified memory via /proc/device-tree; U-Boot patches the node to around 2GB. >- Tested on the 2GB RAM plus 16GB eMMC variant. > Sorry I was not clear, but the patches need to have a description. checkpatch.pl should complain about this. Please use it to check that your patches are in the correct format. See the kernel docs about sending patches here: https://docs.kernel.org/process/submitting-patches.html#describe-your-changes >Christian Stefan Kövér-Draxl (2): > dt-bindings: arm: amlogic: add X98Q compatible > arm64: dts: amlogic: add support for X98Q > > .../devicetree/bindings/arm/amlogic.yaml | 7 + > arch/arm64/boot/dts/amlogic/Makefile | 1 + > .../boot/dts/amlogic/meson-s4-s905w2-x98q.dts | 250 ++++++++++++++++++ > 3 files changed, 258 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-s4-s905w2-x98q.dts > >-- >2.53.0 -- Best regards, Ferass ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-04-21 10:22 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-04-20 6:18 [PATCH v2 0/2] Add support for Amediatech X98Q (Amlogic S905W2) christian.koever-draxl 2026-04-20 6:18 ` [PATCH v2 1/2] dt-bindings: arm: amlogic: add X98Q compatible christian.koever-draxl 2026-04-20 16:11 ` Conor Dooley 2026-04-20 6:18 ` [PATCH v2 2/2] arm64: dts: amlogic: add support for X98Q christian.koever-draxl 2026-04-20 10:43 ` Ferass El Hafidi 2026-04-21 10:22 ` Krzysztof Kozlowski 2026-04-20 9:56 ` [PATCH v2 0/2] Add support for Amediatech X98Q (Amlogic S905W2) Ferass El Hafidi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox