[PATCH -next] x86/amd_nb: Make hygon_nb_misc_ids static

[PATCH -next] x86/amd_nb: Make hygon_nb_misc_ids static

[YueHaibing]

Fix sparse warning:

arch/x86/kernel/amd_nb.c:74:28: warning:
 symbol 'hygon_nb_misc_ids' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 arch/x86/kernel/amd_nb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/amd_nb.c b/arch/x86/kernel/amd_nb.c
index cc51275..922e8fd 100644
--- a/arch/x86/kernel/amd_nb.c
+++ b/arch/x86/kernel/amd_nb.c
@@ -71,7 +71,7 @@ static const struct pci_device_id hygon_root_ids[] = {
 	{}
 };
 
-const struct pci_device_id hygon_nb_misc_ids[] = {
+static const struct pci_device_id hygon_nb_misc_ids[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_HYGON, PCI_DEVICE_ID_AMD_17H_DF_F3) },
 	{}
 };
-- 
2.7.4

Re: [PATCH -next] x86/amd_nb: Make hygon_nb_misc_ids static

[Borislav Petkov]

On Fri, Jun 14, 2019 at 11:54:41PM +0800, YueHaibing wrote:
> Fix sparse warning:
> 
> arch/x86/kernel/amd_nb.c:74:28: warning:
>  symbol 'hygon_nb_misc_ids' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
	       ^^^^^^^^^^^^^^^^^

Ha, what is that? :)

A new test bot?

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH -next] x86/amd_nb: Make hygon_nb_misc_ids static

[Yuehaibing]

On 2019/6/15 1:51, Borislav Petkov wrote:
> On Fri, Jun 14, 2019 at 11:54:41PM +0800, YueHaibing wrote:
>> Fix sparse warning:
>>
>> arch/x86/kernel/amd_nb.c:74:28: warning:
>>  symbol 'hygon_nb_misc_ids' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
> 	       ^^^^^^^^^^^^^^^^^
> 
> Ha, what is that? :)
> 
> A new test bot?

Yes, our internal CI robot.

> 

[tip:x86/cleanups] x86/amd_nb: Make hygon_nb_misc_ids static

[tip-bot for YueHaibing]

Commit-ID:  025e32048f39e24d8ddf9369d679644ea2bdcce6
Gitweb:     https://git.kernel.org/tip/025e32048f39e24d8ddf9369d679644ea2bdcce6
Author:     YueHaibing <yuehaibing@huawei.com>
AuthorDate: Fri, 14 Jun 2019 23:54:41 +0800
Committer:  Borislav Petkov <bp@suse.de>
CommitDate: Fri, 14 Jun 2019 20:25:58 +0200

x86/amd_nb: Make hygon_nb_misc_ids static

Fix the following sparse warning:

  arch/x86/kernel/amd_nb.c:74:28: warning:
    symbol 'hygon_nb_misc_ids' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Brian Woods <Brian.Woods@amd.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Pu Wen <puwen@hygon.cn>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/20190614155441.22076-1-yuehaibing@huawei.com
---
 arch/x86/kernel/amd_nb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/amd_nb.c b/arch/x86/kernel/amd_nb.c
index cc51275c8759..922e8fd5426f 100644
--- a/arch/x86/kernel/amd_nb.c
+++ b/arch/x86/kernel/amd_nb.c
@@ -71,7 +71,7 @@ static const struct pci_device_id hygon_root_ids[] = {
 	{}
 };
 
-const struct pci_device_id hygon_nb_misc_ids[] = {
+static const struct pci_device_id hygon_nb_misc_ids[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_HYGON, PCI_DEVICE_ID_AMD_17H_DF_F3) },
 	{}
 };