The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [tip:irq/urgent] sh: Kill off set_irq_flags usage
       [not found] <1440889285-5637-4-git-send-email-robh@kernel.org>
@ 2015-09-16 20:58 ` tip-bot for Rob Herring
  0 siblings, 0 replies; only message in thread
From: tip-bot for Rob Herring @ 2015-09-16 20:58 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, magnus.damm, horms, robh, tglx, linux, hpa, mingo

Commit-ID:  3e15135b98ecaa0228eb5dad42be7516cac38aa0
Gitweb:     http://git.kernel.org/tip/3e15135b98ecaa0228eb5dad42be7516cac38aa0
Author:     Rob Herring <robh@kernel.org>
AuthorDate: Sat, 29 Aug 2015 18:01:23 -0500
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 16 Sep 2015 16:53:39 +0200

sh: Kill off set_irq_flags usage

set_irq_flags is ARM specific with custom flags which have genirq
equivalents. Convert drivers to use the genirq interfaces directly, so we
can kill off set_irq_flags. The translation of flags is as follows:

IRQF_VALID -> !IRQ_NOREQUEST
IRQF_PROBE -> !IRQ_NOPROBE
IRQF_NOAUTOEN -> IRQ_NOAUTOEN

For IRQs managed by an irqdomain, the irqdomain core code handles clearing
and setting IRQ_NOREQUEST already, so there is no need to do this in
.map() functions and we can simply remove the set_irq_flags calls. Some
users also modify IRQ_NOPROBE and this has been maintained although it
is not clear that is really needed. There appears to be a great deal of
blind copy and paste of this code.

Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Simon Horman <horms@verge.net.au>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-sh@vger.kernel.org
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Magnus Damm <magnus.damm@gmail.com>
Link: http://lkml.kernel.org/r/1440889285-5637-4-git-send-email-robh@kernel.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/sh/intc/internals.h | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/sh/intc/internals.h b/drivers/sh/intc/internals.h
index 7dff08e..6ce7f0d 100644
--- a/drivers/sh/intc/internals.h
+++ b/drivers/sh/intc/internals.h
@@ -99,15 +99,7 @@ static inline struct intc_desc_int *get_intc_desc(unsigned int irq)
  */
 static inline void activate_irq(int irq)
 {
-#ifdef CONFIG_ARM
-	/* ARM requires an extra step to clear IRQ_NOREQUEST, which it
-	 * sets on behalf of every irq_chip.  Also sets IRQ_NOPROBE.
-	 */
-	set_irq_flags(irq, IRQF_VALID);
-#else
-	/* same effect on other architectures */
-	irq_set_noprobe(irq);
-#endif
+	irq_modify_status(irq, IRQ_NOREQUEST, IRQ_NOPROBE);
 }
 
 static inline int intc_handle_int_cmp(const void *a, const void *b)

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-09-16 20:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1440889285-5637-4-git-send-email-robh@kernel.org>
2015-09-16 20:58 ` [tip:irq/urgent] sh: Kill off set_irq_flags usage tip-bot for Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox