[PATCH 0/3] Minor fixes around perf bench

[PATCH 0/3] Minor fixes around perf bench

[Ramkumar Ramachandra]

Hi,

I just started looking at 'perf bench' this afternoon. Here are some
simple patches fixing the minor issues I had while starting out.

Thanks.

Ram

Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>

Ramkumar Ramachandra (3):
  perf bench: Set more defaults in the 'numa' suite
  perf bench: Update manpage to mention numa and futex
  perf bench: Fix segfault at the end of an 'all' execution

 tools/perf/Documentation/perf-bench.txt | 22 ++++++++++++++++++++++
 tools/perf/bench/numa.c                 |  4 ++++
 tools/perf/builtin-bench.c              |  2 +-
 3 files changed, 27 insertions(+), 1 deletion(-)

-- 
1.9.0.431.g014438b

[PATCH 1/3] perf bench: Set more defaults in the 'numa' suite

[Ramkumar Ramachandra]

Currently,

  $ perf bench numa mem

errors out with usage information. To make this more user-friendly, let
us provide a minimum set of default values required for a test
run. As an added bonus,

  $ perf bench all

now goes all the way to completion.

Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 tools/perf/bench/numa.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c
index d4c83c6..20697fb 100644
--- a/tools/perf/bench/numa.c
+++ b/tools/perf/bench/numa.c
@@ -1593,6 +1593,10 @@ static void init_params(struct params *p, const char *name, int argc, const char
 	p->data_rand_walk		= true;
 	p->nr_loops			= -1;
 	p->init_random			= true;
+	p->mb_global_str		= "1";
+	p->nr_proc			= 1;
+	p->nr_threads			= 1;
+	p->nr_secs			= 5;
 }
 
 static int run_bench_numa(const char *name, const char **argv)
-- 
1.9.0.431.g014438b

Re: [PATCH 1/3] perf bench: Set more defaults in the 'numa' suite

[Jiri Olsa]

On Thu, Mar 27, 2014 at 07:50:17PM -0400, Ramkumar Ramachandra wrote:
> Currently,
> 
>   $ perf bench numa mem
> 
> errors out with usage information. To make this more user-friendly, let
> us provide a minimum set of default values required for a test
> run. As an added bonus,
> 
>   $ perf bench all
> 
> now goes all the way to completion.
> 
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---
>  tools/perf/bench/numa.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c
> index d4c83c6..20697fb 100644
> --- a/tools/perf/bench/numa.c
> +++ b/tools/perf/bench/numa.c
> @@ -1593,6 +1593,10 @@ static void init_params(struct params *p, const char *name, int argc, const char
>  	p->data_rand_walk		= true;
>  	p->nr_loops			= -1;
>  	p->init_random			= true;
> +	p->mb_global_str		= "1";
> +	p->nr_proc			= 1;
> +	p->nr_threads			= 1;
> +	p->nr_secs			= 5;

hi,
I dont claim to understand this benchmark, but I'm now getting this:

$ ./perf bench numa all
# Running numa/mem benchmark...

SNIP

 ###
 # 1 task will execute (on 1 nodes, 4 CPUs):
 #         -1x     1MB global  shared mem operations
 #         -1x     0MB process shared mem operations
 #         -1x     0MB thread  local  mem operations
 ###
...


'-1x' does not seem right/intentional for default case

thanks,
jirka

Re: [PATCH 1/3] perf bench: Set more defaults in the 'numa' suite

[Ramkumar Ramachandra]

Jiri Olsa wrote:
>  ###
>  # 1 task will execute (on 1 nodes, 4 CPUs):
>  #         -1x     1MB global  shared mem operations
>  #         -1x     0MB process shared mem operations
>  #         -1x     0MB thread  local  mem operations
>  ###
> ...
>
>
> '-1x' does not seem right/intentional for default case

As you can see from print_summary(), -1 is the value of nr_loops. In
init_params(), Ingo set nr_loops is set to -1 in his original patch --
I haven't touched that. So, unless I'm missing something, it's quite
an apt default case.

Ram

Re: [PATCH 1/3] perf bench: Set more defaults in the 'numa' suite

[Jiri Olsa]

On Thu, Apr 10, 2014 at 08:31:32PM -0400, Ramkumar Ramachandra wrote:
> Jiri Olsa wrote:
> >  ###
> >  # 1 task will execute (on 1 nodes, 4 CPUs):
> >  #         -1x     1MB global  shared mem operations
> >  #         -1x     0MB process shared mem operations
> >  #         -1x     0MB thread  local  mem operations
> >  ###
> > ...
> >
> >
> > '-1x' does not seem right/intentional for default case
> 
> As you can see from print_summary(), -1 is the value of nr_loops. In
> init_params(), Ingo set nr_loops is set to -1 in his original patch --
> I haven't touched that. So, unless I'm missing something, it's quite
> an apt default case.

fair enough ;-) ok

thanks,
jirka

[tip:perf/urgent] perf bench: Set more defaults in the 'numa' suite

[tip-bot for Ramkumar Ramachandra]

Commit-ID:  40ba93e3aa001246110320edbe8cf2eb488c1fe7
Gitweb:     http://git.kernel.org/tip/40ba93e3aa001246110320edbe8cf2eb488c1fe7
Author:     Ramkumar Ramachandra <artagnon@gmail.com>
AuthorDate: Thu, 27 Mar 2014 19:50:17 -0400
Committer:  Jiri Olsa <jolsa@redhat.com>
CommitDate: Mon, 14 Apr 2014 12:55:58 +0200

perf bench: Set more defaults in the 'numa' suite

Currently,

  $ perf bench numa mem

errors out with usage information. To make this more user-friendly, let
us provide a minimum set of default values required for a test
run. As an added bonus,

  $ perf bench all

now goes all the way to completion.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1395964219-22173-2-git-send-email-artagnon@gmail.com
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
 tools/perf/bench/numa.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c
index d4c83c6..20697fb 100644
--- a/tools/perf/bench/numa.c
+++ b/tools/perf/bench/numa.c
@@ -1593,6 +1593,10 @@ static void init_params(struct params *p, const char *name, int argc, const char
 	p->data_rand_walk		= true;
 	p->nr_loops			= -1;
 	p->init_random			= true;
+	p->mb_global_str		= "1";
+	p->nr_proc			= 1;
+	p->nr_threads			= 1;
+	p->nr_secs			= 5;
 }
 
 static int run_bench_numa(const char *name, const char **argv)

[PATCH 2/3] perf bench: Update manpage to mention numa and futex

[Ramkumar Ramachandra]

Cc: Jiri Olsa <jolsa@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 tools/perf/Documentation/perf-bench.txt | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/tools/perf/Documentation/perf-bench.txt b/tools/perf/Documentation/perf-bench.txt
index 7065cd6..4464ad7 100644
--- a/tools/perf/Documentation/perf-bench.txt
+++ b/tools/perf/Documentation/perf-bench.txt
@@ -48,6 +48,12 @@ SUBSYSTEM
 'mem'::
 	Memory access performance.
 
+'numa'::
+	NUMA scheduling and MM benchmarks.
+
+'futex'::
+	Futex stressing benchmarks.
+
 'all'::
 	All benchmark subsystems.
 
@@ -187,6 +193,22 @@ Show only the result with page faults before memset.
 --no-prefault::
 Show only the result without page faults before memset.
 
+SUITES FOR 'numa'
+~~~~~~~~~~~~~~~~~
+*mem*::
+Suite for evaluating NUMA workloads.
+
+SUITES FOR 'futex'
+~~~~~~~~~~~~~~~~~~
+*hash*::
+Suite for evaluating hash tables.
+
+*wake*::
+Suite for evaluating wake calls.
+
+*requeue*::
+Suite for evaluating requeue calls.
+
 SEE ALSO
 --------
 linkperf:perf[1]
-- 
1.9.0.431.g014438b

[tip:perf/urgent] perf bench: Update manpage to mention numa and futex

[tip-bot for Ramkumar Ramachandra]

Commit-ID:  95a2b3c0a9e2a8038edbf3f9776d5a3d76146459
Gitweb:     http://git.kernel.org/tip/95a2b3c0a9e2a8038edbf3f9776d5a3d76146459
Author:     Ramkumar Ramachandra <artagnon@gmail.com>
AuthorDate: Thu, 27 Mar 2014 19:50:18 -0400
Committer:  Jiri Olsa <jolsa@redhat.com>
CommitDate: Mon, 14 Apr 2014 12:55:41 +0200

perf bench: Update manpage to mention numa and futex

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1395964219-22173-3-git-send-email-artagnon@gmail.com
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
 tools/perf/Documentation/perf-bench.txt | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/tools/perf/Documentation/perf-bench.txt b/tools/perf/Documentation/perf-bench.txt
index 7065cd6..4464ad7 100644
--- a/tools/perf/Documentation/perf-bench.txt
+++ b/tools/perf/Documentation/perf-bench.txt
@@ -48,6 +48,12 @@ SUBSYSTEM
 'mem'::
 	Memory access performance.
 
+'numa'::
+	NUMA scheduling and MM benchmarks.
+
+'futex'::
+	Futex stressing benchmarks.
+
 'all'::
 	All benchmark subsystems.
 
@@ -187,6 +193,22 @@ Show only the result with page faults before memset.
 --no-prefault::
 Show only the result without page faults before memset.
 
+SUITES FOR 'numa'
+~~~~~~~~~~~~~~~~~
+*mem*::
+Suite for evaluating NUMA workloads.
+
+SUITES FOR 'futex'
+~~~~~~~~~~~~~~~~~~
+*hash*::
+Suite for evaluating hash tables.
+
+*wake*::
+Suite for evaluating wake calls.
+
+*requeue*::
+Suite for evaluating requeue calls.
+
 SEE ALSO
 --------
 linkperf:perf[1]

[PATCH 3/3] perf bench: Fix segfault at the end of an 'all' execution

[Ramkumar Ramachandra]

At the end of

  $ perf bench all

the program segfaults because it attempts to dereference a NULL
pointer. Fix this fault.

Cc: Jiri Olsa <jolsa@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 tools/perf/builtin-bench.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-bench.c b/tools/perf/builtin-bench.c
index f600b74..1e6e777 100644
--- a/tools/perf/builtin-bench.c
+++ b/tools/perf/builtin-bench.c
@@ -86,7 +86,7 @@ static struct collection collections[] = {
 
 /* Iterate over all benchmarks within a collection: */
 #define for_each_bench(coll, bench) \
-	for (bench = coll->benchmarks; bench->name; bench++)
+	for (bench = coll->benchmarks; bench && bench->name; bench++)
 
 static void dump_benchmarks(struct collection *coll)
 {
-- 
1.9.0.431.g014438b

[tip:perf/urgent] perf bench: Fix segfault at the end of an 'all' execution

[tip-bot for Ramkumar Ramachandra]

Commit-ID:  5673872d4afd2584e075cf2b1adb2cccec46a0f3
Gitweb:     http://git.kernel.org/tip/5673872d4afd2584e075cf2b1adb2cccec46a0f3
Author:     Ramkumar Ramachandra <artagnon@gmail.com>
AuthorDate: Thu, 27 Mar 2014 19:50:19 -0400
Committer:  Jiri Olsa <jolsa@redhat.com>
CommitDate: Mon, 14 Apr 2014 12:55:53 +0200

perf bench: Fix segfault at the end of an 'all' execution

At the end of

  $ perf bench all

the program segfaults because it attempts to dereference a NULL
pointer. Fix this fault.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1395964219-22173-4-git-send-email-artagnon@gmail.com
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
 tools/perf/builtin-bench.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-bench.c b/tools/perf/builtin-bench.c
index f600b74..1e6e777 100644
--- a/tools/perf/builtin-bench.c
+++ b/tools/perf/builtin-bench.c
@@ -86,7 +86,7 @@ static struct collection collections[] = {
 
 /* Iterate over all benchmarks within a collection: */
 #define for_each_bench(coll, bench) \
-	for (bench = coll->benchmarks; bench->name; bench++)
+	for (bench = coll->benchmarks; bench && bench->name; bench++)
 
 static void dump_benchmarks(struct collection *coll)
 {

Re: [PATCH 0/3] Minor fixes around perf bench

[Davidlohr Bueso]

On Thu, 2014-03-27 at 19:50 -0400, Ramkumar Ramachandra wrote:
> Hi,
> 
> I just started looking at 'perf bench' this afternoon. Here are some
> simple patches fixing the minor issues I had while starting out.
> 
> Thanks.
> 
> Ram
> 
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> Ramkumar Ramachandra (3):
>   perf bench: Set more defaults in the 'numa' suite
>   perf bench: Update manpage to mention numa and futex
>   perf bench: Fix segfault at the end of an 'all' execution

Acked-by: Davidlohr Bueso <davidlohr@hp.com>

Re: [PATCH 0/3] Minor fixes around perf bench

[Jiri Olsa]

On Thu, Mar 27, 2014 at 07:50:16PM -0400, Ramkumar Ramachandra wrote:
> Hi,
> 
> I just started looking at 'perf bench' this afternoon. Here are some
> simple patches fixing the minor issues I had while starting out.

look good to me, will merge them

thanks,
jirka