* [PATCH] tracing/ftrace: fix missing include string.h
@ 2009-03-27 13:18 Frederic Weisbecker
2009-03-27 13:22 ` [PATCH v2] " Frederic Weisbecker
0 siblings, 1 reply; 4+ messages in thread
From: Frederic Weisbecker @ 2009-03-27 13:18 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Steven Rostedt, LKML, Frederic Weisbecker
Building a kernel with tracing can raise the following warning on
tip/master:
kernel/trace/trace.c:1249: error: implicit declaration of function 'vbin_printf'
We are missing an include to string.h
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
kernel/trace/trace.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 2a81dec..704cd7f 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -30,6 +30,7 @@
#include <linux/percpu.h>
#include <linux/splice.h>
#include <linux/kdebug.h>
+#include <linux/string.h>
#include <linux/ctype.h>
#include <linux/init.h>
#include <linux/poll.h>
--
1.6.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] tracing/ftrace: fix missing include string.h
2009-03-27 13:18 [PATCH] tracing/ftrace: fix missing include string.h Frederic Weisbecker
@ 2009-03-27 13:22 ` Frederic Weisbecker
2009-04-03 16:18 ` Steven Rostedt
2009-04-07 13:12 ` [tip:tracing/urgent] " Frederic Weisbecker
0 siblings, 2 replies; 4+ messages in thread
From: Frederic Weisbecker @ 2009-03-27 13:22 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Steven Rostedt, LKML, Frederic Weisbecker
Building a kernel with tracing can raise the following warning on
tip/master:
kernel/trace/trace.c:1249: error: implicit declaration of function 'vbin_printf'
We are missing an include to string.h
[v2: add reported-by]
Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
kernel/trace/trace.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 2a81dec..704cd7f 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -30,6 +30,7 @@
#include <linux/percpu.h>
#include <linux/splice.h>
#include <linux/kdebug.h>
+#include <linux/string.h>
#include <linux/ctype.h>
#include <linux/init.h>
#include <linux/poll.h>
--
1.6.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] tracing/ftrace: fix missing include string.h
2009-03-27 13:22 ` [PATCH v2] " Frederic Weisbecker
@ 2009-04-03 16:18 ` Steven Rostedt
2009-04-07 13:12 ` [tip:tracing/urgent] " Frederic Weisbecker
1 sibling, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2009-04-03 16:18 UTC (permalink / raw)
To: Frederic Weisbecker; +Cc: Ingo Molnar, LKML
On Fri, 27 Mar 2009, Frederic Weisbecker wrote:
> Building a kernel with tracing can raise the following warning on
> tip/master:
>
> kernel/trace/trace.c:1249: error: implicit declaration of function 'vbin_printf'
>
> We are missing an include to string.h
>
> [v2: add reported-by]
>
> Reported-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Thanks, applied.
-- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:tracing/urgent] tracing/ftrace: fix missing include string.h
2009-03-27 13:22 ` [PATCH v2] " Frederic Weisbecker
2009-04-03 16:18 ` Steven Rostedt
@ 2009-04-07 13:12 ` Frederic Weisbecker
1 sibling, 0 replies; 4+ messages in thread
From: Frederic Weisbecker @ 2009-04-07 13:12 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, fweisbec, rostedt, tglx, mingo
Commit-ID: 5f0c6c03c5fee91c02c696bc9bf4c0d41392abe7
Gitweb: http://git.kernel.org/tip/5f0c6c03c5fee91c02c696bc9bf4c0d41392abe7
Author: Frederic Weisbecker <fweisbec@gmail.com>
AuthorDate: Fri, 27 Mar 2009 14:22:10 +0100
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 7 Apr 2009 14:00:18 +0200
tracing/ftrace: fix missing include string.h
Building a kernel with tracing can raise the following warning on
tip/master:
kernel/trace/trace.c:1249: error: implicit declaration of function 'vbin_printf'
We are missing an include to string.h
Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <1238160130-7437-1-git-send-email-fweisbec@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/trace/trace.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 457dd8c..2230b46 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -30,6 +30,7 @@
#include <linux/percpu.h>
#include <linux/splice.h>
#include <linux/kdebug.h>
+#include <linux/string.h>
#include <linux/ctype.h>
#include <linux/init.h>
#include <linux/poll.h>
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-04-07 13:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-27 13:18 [PATCH] tracing/ftrace: fix missing include string.h Frederic Weisbecker
2009-03-27 13:22 ` [PATCH v2] " Frederic Weisbecker
2009-04-03 16:18 ` Steven Rostedt
2009-04-07 13:12 ` [tip:tracing/urgent] " Frederic Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox