public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perf: Make the install relative to DESTDIR if specified
@ 2010-03-11 12:57 John Kacur
  2010-03-11 13:50 ` John Kacur
  2010-03-11 14:39 ` [tip:perf/urgent] " tip-bot for John Kacur
  0 siblings, 2 replies; 6+ messages in thread
From: John Kacur @ 2010-03-11 12:57 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: lkml, Peter Zijlstra, Paul Mackerras, Arnaldo Carvalho de Melo,
	Frederic Weisbecker, Tom Zanussi, Kyle McMartin, John Kacur

Without this change, the install path is relative to
prefix/DESTDIR
where prefix is automatically set to $HOME

This can produce unexpected results. For example

make -C tools/perf DESTDIR=/home/jkacur/tmp install-man

creates the directory:		/home/jkacur/home/jkacur/tmp/share/...
instead of  the expected:	/home/jkacur/tmp/share/...

Signed-off-by: John Kacur <jkacur@redhat.com>
---
 tools/perf/Documentation/Makefile |    4 +++-
 tools/perf/Makefile               |    4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/tools/perf/Documentation/Makefile b/tools/perf/Documentation/Makefile
index bdd3b7e..bd498d4 100644
--- a/tools/perf/Documentation/Makefile
+++ b/tools/perf/Documentation/Makefile
@@ -24,7 +24,10 @@ DOC_MAN1=$(patsubst %.txt,%.1,$(MAN1_TXT))
 DOC_MAN5=$(patsubst %.txt,%.5,$(MAN5_TXT))
 DOC_MAN7=$(patsubst %.txt,%.7,$(MAN7_TXT))
 
+# Make the path relative to DESTDIR, not prefix
+ifndef DESTDIR
 prefix?=$(HOME)
+endif
 bindir?=$(prefix)/bin
 htmldir?=$(prefix)/share/doc/perf-doc
 pdfdir?=$(prefix)/share/doc/perf-doc
@@ -32,7 +35,6 @@ mandir?=$(prefix)/share/man
 man1dir=$(mandir)/man1
 man5dir=$(mandir)/man5
 man7dir=$(mandir)/man7
-# DESTDIR=
 
 ASCIIDOC=asciidoc
 ASCIIDOC_EXTRA = --unsafe
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 2d53738..5da0cd0 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -216,7 +216,10 @@ STRIP ?= strip
 # runtime figures out where they are based on the path to the executable.
 # This can help installing the suite in a relocatable way.
 
+# Make the path relative to DESTDIR, not to prefix
+ifndef DESTDIR
 prefix = $(HOME)
+endif
 bindir_relative = bin
 bindir = $(prefix)/$(bindir_relative)
 mandir = share/man
@@ -233,7 +236,6 @@ sysconfdir = $(prefix)/etc
 ETC_PERFCONFIG = etc/perfconfig
 endif
 lib = lib
-# DESTDIR=
 
 export prefix bindir sharedir sysconfdir
 
-- 
1.6.6.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] perf: Make the install relative to DESTDIR if specified
  2010-03-11 12:57 [PATCH] perf: Make the install relative to DESTDIR if specified John Kacur
@ 2010-03-11 13:50 ` John Kacur
  2010-03-11 14:14   ` Ingo Molnar
  2010-03-11 14:39 ` [tip:perf/urgent] " tip-bot for John Kacur
  1 sibling, 1 reply; 6+ messages in thread
From: John Kacur @ 2010-03-11 13:50 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: lkml, Peter Zijlstra, Paul Mackerras, Arnaldo Carvalho de Melo,
	Frederic Weisbecker, Tom Zanussi, Kyle McMartin, John Kacur

On Thu, Mar 11, 2010 at 1:57 PM, John Kacur <jkacur@redhat.com> wrote:
> Without this change, the install path is relative to
> prefix/DESTDIR
> where prefix is automatically set to $HOME
>
> This can produce unexpected results. For example
>
> make -C tools/perf DESTDIR=/home/jkacur/tmp install-man
>
> creates the directory:          /home/jkacur/home/jkacur/tmp/share/...
> instead of  the expected:       /home/jkacur/tmp/share/...
>
> Signed-off-by: John Kacur <jkacur@redhat.com>
> ---
>  tools/perf/Documentation/Makefile |    4 +++-
>  tools/perf/Makefile               |    4 +++-
>  2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/Documentation/Makefile b/tools/perf/Documentation/Makefile
> index bdd3b7e..bd498d4 100644
> --- a/tools/perf/Documentation/Makefile
> +++ b/tools/perf/Documentation/Makefile
> @@ -24,7 +24,10 @@ DOC_MAN1=$(patsubst %.txt,%.1,$(MAN1_TXT))
>  DOC_MAN5=$(patsubst %.txt,%.5,$(MAN5_TXT))
>  DOC_MAN7=$(patsubst %.txt,%.7,$(MAN7_TXT))
>
> +# Make the path relative to DESTDIR, not prefix
> +ifndef DESTDIR
>  prefix?=$(HOME)
> +endif
>  bindir?=$(prefix)/bin
>  htmldir?=$(prefix)/share/doc/perf-doc
>  pdfdir?=$(prefix)/share/doc/perf-doc
> @@ -32,7 +35,6 @@ mandir?=$(prefix)/share/man
>  man1dir=$(mandir)/man1
>  man5dir=$(mandir)/man5
>  man7dir=$(mandir)/man7
> -# DESTDIR=
>
>  ASCIIDOC=asciidoc
>  ASCIIDOC_EXTRA = --unsafe
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 2d53738..5da0cd0 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -216,7 +216,10 @@ STRIP ?= strip
>  # runtime figures out where they are based on the path to the executable.
>  # This can help installing the suite in a relocatable way.
>
> +# Make the path relative to DESTDIR, not to prefix
> +ifndef DESTDIR
>  prefix = $(HOME)
> +endif
>  bindir_relative = bin
>  bindir = $(prefix)/$(bindir_relative)
>  mandir = share/man
> @@ -233,7 +236,6 @@ sysconfdir = $(prefix)/etc
>  ETC_PERFCONFIG = etc/perfconfig
>  endif
>  lib = lib
> -# DESTDIR=
>
>  export prefix bindir sharedir sysconfdir
>
> --
> 1.6.6.1

Sorry, I'd like to withdraw this patch.

I see I can achieve my desired ends without changing the behaviour for
others who expect the old behaviour,
simply by setting "prefix" on the command line, eg:
make -C tools/perf prefix="" DESTDIR=/home/jkacur/tmp install-man

Thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] perf: Make the install relative to DESTDIR if specified
  2010-03-11 13:50 ` John Kacur
@ 2010-03-11 14:14   ` Ingo Molnar
  2010-03-11 14:46     ` John Kacur
  0 siblings, 1 reply; 6+ messages in thread
From: Ingo Molnar @ 2010-03-11 14:14 UTC (permalink / raw)
  To: John Kacur
  Cc: lkml, Peter Zijlstra, Paul Mackerras, Arnaldo Carvalho de Melo,
	Frederic Weisbecker, Tom Zanussi, Kyle McMartin


* John Kacur <jkacur@redhat.com> wrote:

> On Thu, Mar 11, 2010 at 1:57 PM, John Kacur <jkacur@redhat.com> wrote:
> > Without this change, the install path is relative to
> > prefix/DESTDIR
> > where prefix is automatically set to $HOME
> >
> > This can produce unexpected results. For example
> >
> > make -C tools/perf DESTDIR=/home/jkacur/tmp install-man
> >
> > creates the directory: ? ? ? ? ?/home/jkacur/home/jkacur/tmp/share/...
> > instead of ?the expected: ? ? ? /home/jkacur/tmp/share/...
> >
> > Signed-off-by: John Kacur <jkacur@redhat.com>
> > ---
> > ?tools/perf/Documentation/Makefile | ? ?4 +++-
> > ?tools/perf/Makefile ? ? ? ? ? ? ? | ? ?4 +++-
> > ?2 files changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/perf/Documentation/Makefile b/tools/perf/Documentation/Makefile
> > index bdd3b7e..bd498d4 100644
> > --- a/tools/perf/Documentation/Makefile
> > +++ b/tools/perf/Documentation/Makefile
> > @@ -24,7 +24,10 @@ DOC_MAN1=$(patsubst %.txt,%.1,$(MAN1_TXT))
> > ?DOC_MAN5=$(patsubst %.txt,%.5,$(MAN5_TXT))
> > ?DOC_MAN7=$(patsubst %.txt,%.7,$(MAN7_TXT))
> >
> > +# Make the path relative to DESTDIR, not prefix
> > +ifndef DESTDIR
> > ?prefix?=$(HOME)
> > +endif
> > ?bindir?=$(prefix)/bin
> > ?htmldir?=$(prefix)/share/doc/perf-doc
> > ?pdfdir?=$(prefix)/share/doc/perf-doc
> > @@ -32,7 +35,6 @@ mandir?=$(prefix)/share/man
> > ?man1dir=$(mandir)/man1
> > ?man5dir=$(mandir)/man5
> > ?man7dir=$(mandir)/man7
> > -# DESTDIR=
> >
> > ?ASCIIDOC=asciidoc
> > ?ASCIIDOC_EXTRA = --unsafe
> > diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> > index 2d53738..5da0cd0 100644
> > --- a/tools/perf/Makefile
> > +++ b/tools/perf/Makefile
> > @@ -216,7 +216,10 @@ STRIP ?= strip
> > ?# runtime figures out where they are based on the path to the executable.
> > ?# This can help installing the suite in a relocatable way.
> >
> > +# Make the path relative to DESTDIR, not to prefix
> > +ifndef DESTDIR
> > ?prefix = $(HOME)
> > +endif
> > ?bindir_relative = bin
> > ?bindir = $(prefix)/$(bindir_relative)
> > ?mandir = share/man
> > @@ -233,7 +236,6 @@ sysconfdir = $(prefix)/etc
> > ?ETC_PERFCONFIG = etc/perfconfig
> > ?endif
> > ?lib = lib
> > -# DESTDIR=
> >
> > ?export prefix bindir sharedir sysconfdir
> >
> > --
> > 1.6.6.1
> 
> Sorry, I'd like to withdraw this patch.
> 
> I see I can achieve my desired ends without changing the behaviour for
> others who expect the old behaviour,

The old behavior doesnt look very logical though, right?

	Ingo

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [tip:perf/urgent] perf: Make the install relative to DESTDIR if specified
  2010-03-11 12:57 [PATCH] perf: Make the install relative to DESTDIR if specified John Kacur
  2010-03-11 13:50 ` John Kacur
@ 2010-03-11 14:39 ` tip-bot for John Kacur
  1 sibling, 0 replies; 6+ messages in thread
From: tip-bot for John Kacur @ 2010-03-11 14:39 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, acme, paulus, hpa, mingo, tzanussi, jkacur,
	a.p.zijlstra, kyle, fweisbec, stable, tglx, mingo

Commit-ID:  7ae5f21361fea11f58c398701da635f778635d13
Gitweb:     http://git.kernel.org/tip/7ae5f21361fea11f58c398701da635f778635d13
Author:     John Kacur <jkacur@redhat.com>
AuthorDate: Thu, 11 Mar 2010 13:57:00 +0100
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 11 Mar 2010 14:08:11 +0100

perf: Make the install relative to DESTDIR if specified

Without this change, the install path is relative to
prefix/DESTDIR where prefix is automatically set to $HOME.

This can produce unexpected results. For example:

  make -C tools/perf DESTDIR=/home/jkacur/tmp install-man

creates the directory:		/home/jkacur/home/jkacur/tmp/share/...
instead of the expected:	/home/jkacur/tmp/share/...

Signed-off-by: John Kacur <jkacur@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
Cc: Kyle McMartin <kyle@redhat.com>
Cc: <stable@kernel.org>
LKML-Reference: <1268312220-12880-1-git-send-email-jkacur@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 tools/perf/Documentation/Makefile |    4 +++-
 tools/perf/Makefile               |    4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/tools/perf/Documentation/Makefile b/tools/perf/Documentation/Makefile
index bdd3b7e..bd498d4 100644
--- a/tools/perf/Documentation/Makefile
+++ b/tools/perf/Documentation/Makefile
@@ -24,7 +24,10 @@ DOC_MAN1=$(patsubst %.txt,%.1,$(MAN1_TXT))
 DOC_MAN5=$(patsubst %.txt,%.5,$(MAN5_TXT))
 DOC_MAN7=$(patsubst %.txt,%.7,$(MAN7_TXT))
 
+# Make the path relative to DESTDIR, not prefix
+ifndef DESTDIR
 prefix?=$(HOME)
+endif
 bindir?=$(prefix)/bin
 htmldir?=$(prefix)/share/doc/perf-doc
 pdfdir?=$(prefix)/share/doc/perf-doc
@@ -32,7 +35,6 @@ mandir?=$(prefix)/share/man
 man1dir=$(mandir)/man1
 man5dir=$(mandir)/man5
 man7dir=$(mandir)/man7
-# DESTDIR=
 
 ASCIIDOC=asciidoc
 ASCIIDOC_EXTRA = --unsafe
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 5840499..8a8f52d 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -216,7 +216,10 @@ STRIP ?= strip
 # runtime figures out where they are based on the path to the executable.
 # This can help installing the suite in a relocatable way.
 
+# Make the path relative to DESTDIR, not to prefix
+ifndef DESTDIR
 prefix = $(HOME)
+endif
 bindir_relative = bin
 bindir = $(prefix)/$(bindir_relative)
 mandir = share/man
@@ -233,7 +236,6 @@ sysconfdir = $(prefix)/etc
 ETC_PERFCONFIG = etc/perfconfig
 endif
 lib = lib
-# DESTDIR=
 
 export prefix bindir sharedir sysconfdir
 

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] perf: Make the install relative to DESTDIR if specified
  2010-03-11 14:14   ` Ingo Molnar
@ 2010-03-11 14:46     ` John Kacur
  2010-03-11 15:24       ` Ingo Molnar
  0 siblings, 1 reply; 6+ messages in thread
From: John Kacur @ 2010-03-11 14:46 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: lkml, Peter Zijlstra, Paul Mackerras, Arnaldo Carvalho de Melo,
	Frederic Weisbecker, Tom Zanussi, Kyle McMartin


----- "Ingo Molnar" <mingo@elte.hu> wrote:

> * John Kacur <jkacur@redhat.com> wrote:
> 
> > On Thu, Mar 11, 2010 at 1:57 PM, John Kacur <jkacur@redhat.com>
> wrote:
> > > Without this change, the install path is relative to
> > > prefix/DESTDIR
> > > where prefix is automatically set to $HOME
> > >
> > > This can produce unexpected results. For example
> > >
> > > make -C tools/perf DESTDIR=/home/jkacur/tmp install-man
> > >
> > > creates the directory: ? ? ? ?
> ?/home/jkacur/home/jkacur/tmp/share/...
> > > instead of ?the expected: ? ? ? /home/jkacur/tmp/share/...
> > >
> > > Signed-off-by: John Kacur <jkacur@redhat.com>
> > > ---
> > > ?tools/perf/Documentation/Makefile | ? ?4 +++-
> > > ?tools/perf/Makefile ? ? ? ? ? ? ? | ? ?4 +++-
> > > ?2 files changed, 6 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/tools/perf/Documentation/Makefile
> b/tools/perf/Documentation/Makefile
> > > index bdd3b7e..bd498d4 100644
> > > --- a/tools/perf/Documentation/Makefile
> > > +++ b/tools/perf/Documentation/Makefile
> > > @@ -24,7 +24,10 @@ DOC_MAN1=$(patsubst %.txt,%.1,$(MAN1_TXT))
> > > ?DOC_MAN5=$(patsubst %.txt,%.5,$(MAN5_TXT))
> > > ?DOC_MAN7=$(patsubst %.txt,%.7,$(MAN7_TXT))
> > >
> > > +# Make the path relative to DESTDIR, not prefix
> > > +ifndef DESTDIR
> > > ?prefix?=$(HOME)
> > > +endif
> > > ?bindir?=$(prefix)/bin
> > > ?htmldir?=$(prefix)/share/doc/perf-doc
> > > ?pdfdir?=$(prefix)/share/doc/perf-doc
> > > @@ -32,7 +35,6 @@ mandir?=$(prefix)/share/man
> > > ?man1dir=$(mandir)/man1
> > > ?man5dir=$(mandir)/man5
> > > ?man7dir=$(mandir)/man7
> > > -# DESTDIR=
> > >
> > > ?ASCIIDOC=asciidoc
> > > ?ASCIIDOC_EXTRA = --unsafe
> > > diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> > > index 2d53738..5da0cd0 100644
> > > --- a/tools/perf/Makefile
> > > +++ b/tools/perf/Makefile
> > > @@ -216,7 +216,10 @@ STRIP ?= strip
> > > ?# runtime figures out where they are based on the path to the
> executable.
> > > ?# This can help installing the suite in a relocatable way.
> > >
> > > +# Make the path relative to DESTDIR, not to prefix
> > > +ifndef DESTDIR
> > > ?prefix = $(HOME)
> > > +endif
> > > ?bindir_relative = bin
> > > ?bindir = $(prefix)/$(bindir_relative)
> > > ?mandir = share/man
> > > @@ -233,7 +236,6 @@ sysconfdir = $(prefix)/etc
> > > ?ETC_PERFCONFIG = etc/perfconfig
> > > ?endif
> > > ?lib = lib
> > > -# DESTDIR=
> > >
> > > ?export prefix bindir sharedir sysconfdir
> > >
> > > --
> > > 1.6.6.1
> > 
> > Sorry, I'd like to withdraw this patch.
> > 
> > I see I can achieve my desired ends without changing the behaviour
> for
> > others who expect the old behaviour,
> 
> The old behavior doesnt look very logical though, right?

No, not really. Well, logical for people quickly prototyping code
on their own machines, but perf has grown beyond that.

However, I don't like my quick fix either, maybe I can come-up
with something cleaner.

John

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] perf: Make the install relative to DESTDIR if specified
  2010-03-11 14:46     ` John Kacur
@ 2010-03-11 15:24       ` Ingo Molnar
  0 siblings, 0 replies; 6+ messages in thread
From: Ingo Molnar @ 2010-03-11 15:24 UTC (permalink / raw)
  To: John Kacur
  Cc: lkml, Peter Zijlstra, Paul Mackerras, Arnaldo Carvalho de Melo,
	Frederic Weisbecker, Tom Zanussi, Kyle McMartin


* John Kacur <jkacur@redhat.com> wrote:

> 
> ----- "Ingo Molnar" <mingo@elte.hu> wrote:
> 
> > * John Kacur <jkacur@redhat.com> wrote:
> > 
> > > On Thu, Mar 11, 2010 at 1:57 PM, John Kacur <jkacur@redhat.com>
> > wrote:
> > > > Without this change, the install path is relative to
> > > > prefix/DESTDIR
> > > > where prefix is automatically set to $HOME
> > > >
> > > > This can produce unexpected results. For example
> > > >
> > > > make -C tools/perf DESTDIR=/home/jkacur/tmp install-man
> > > >
> > > > creates the directory: ? ? ? ?
> > ?/home/jkacur/home/jkacur/tmp/share/...
> > > > instead of ?the expected: ? ? ? /home/jkacur/tmp/share/...
> > > >
> > > > Signed-off-by: John Kacur <jkacur@redhat.com>
> > > > ---
> > > > ?tools/perf/Documentation/Makefile | ? ?4 +++-
> > > > ?tools/perf/Makefile ? ? ? ? ? ? ? | ? ?4 +++-
> > > > ?2 files changed, 6 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/tools/perf/Documentation/Makefile
> > b/tools/perf/Documentation/Makefile
> > > > index bdd3b7e..bd498d4 100644
> > > > --- a/tools/perf/Documentation/Makefile
> > > > +++ b/tools/perf/Documentation/Makefile
> > > > @@ -24,7 +24,10 @@ DOC_MAN1=$(patsubst %.txt,%.1,$(MAN1_TXT))
> > > > ?DOC_MAN5=$(patsubst %.txt,%.5,$(MAN5_TXT))
> > > > ?DOC_MAN7=$(patsubst %.txt,%.7,$(MAN7_TXT))
> > > >
> > > > +# Make the path relative to DESTDIR, not prefix
> > > > +ifndef DESTDIR
> > > > ?prefix?=$(HOME)
> > > > +endif
> > > > ?bindir?=$(prefix)/bin
> > > > ?htmldir?=$(prefix)/share/doc/perf-doc
> > > > ?pdfdir?=$(prefix)/share/doc/perf-doc
> > > > @@ -32,7 +35,6 @@ mandir?=$(prefix)/share/man
> > > > ?man1dir=$(mandir)/man1
> > > > ?man5dir=$(mandir)/man5
> > > > ?man7dir=$(mandir)/man7
> > > > -# DESTDIR=
> > > >
> > > > ?ASCIIDOC=asciidoc
> > > > ?ASCIIDOC_EXTRA = --unsafe
> > > > diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> > > > index 2d53738..5da0cd0 100644
> > > > --- a/tools/perf/Makefile
> > > > +++ b/tools/perf/Makefile
> > > > @@ -216,7 +216,10 @@ STRIP ?= strip
> > > > ?# runtime figures out where they are based on the path to the
> > executable.
> > > > ?# This can help installing the suite in a relocatable way.
> > > >
> > > > +# Make the path relative to DESTDIR, not to prefix
> > > > +ifndef DESTDIR
> > > > ?prefix = $(HOME)
> > > > +endif
> > > > ?bindir_relative = bin
> > > > ?bindir = $(prefix)/$(bindir_relative)
> > > > ?mandir = share/man
> > > > @@ -233,7 +236,6 @@ sysconfdir = $(prefix)/etc
> > > > ?ETC_PERFCONFIG = etc/perfconfig
> > > > ?endif
> > > > ?lib = lib
> > > > -# DESTDIR=
> > > >
> > > > ?export prefix bindir sharedir sysconfdir
> > > >
> > > > --
> > > > 1.6.6.1
> > > 
> > > Sorry, I'd like to withdraw this patch.
> > > 
> > > I see I can achieve my desired ends without changing the behaviour
> > for
> > > others who expect the old behaviour,
> > 
> > The old behavior doesnt look very logical though, right?
> 
> No, not really. Well, logical for people quickly prototyping code
> on their own machines, but perf has grown beyond that.
> 
> However, I don't like my quick fix either, maybe I can come-up
> with something cleaner.

I've applied it meanwhile though, as /home/jkacur/home/jkacur/ is clearly a 
misbehavior :-)

	Ingo

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-03-11 15:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-11 12:57 [PATCH] perf: Make the install relative to DESTDIR if specified John Kacur
2010-03-11 13:50 ` John Kacur
2010-03-11 14:14   ` Ingo Molnar
2010-03-11 14:46     ` John Kacur
2010-03-11 15:24       ` Ingo Molnar
2010-03-11 14:39 ` [tip:perf/urgent] " tip-bot for John Kacur

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox