* [PATCH -tip] x86: ptrace.c ptrace_get_debugreg() should be static
@ 2009-07-01 14:22 Jaswinder Singh Rajput
2009-11-21 13:33 ` [tip:perf/core] x86: Mark ptrace_get_debugreg() as static tip-bot for Jaswinder Singh Rajput
0 siblings, 1 reply; 2+ messages in thread
From: Jaswinder Singh Rajput @ 2009-07-01 14:22 UTC (permalink / raw)
To: Ingo Molnar, Steven Rostedt, x86 maintainers, LKML
This sparse warning:
arch/x86/kernel/ptrace.c:560:15: warning: symbol 'ptrace_get_debugreg' was not declared. Should it be static?
triggers because ptrace_get_debugreg() is global but is only used in a single .c file.
change ptrace_get_debugreg() to static to fix that - this also address the sparse warning.
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/kernel/ptrace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
index b457f78..cabdabc 100644
--- a/arch/x86/kernel/ptrace.c
+++ b/arch/x86/kernel/ptrace.c
@@ -557,7 +557,7 @@ restore:
/*
* Handle PTRACE_PEEKUSR calls for the debug register area.
*/
-unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n)
+static unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n)
{
struct thread_struct *thread = &(tsk->thread);
unsigned long val = 0;
--
1.6.0.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* [tip:perf/core] x86: Mark ptrace_get_debugreg() as static
2009-07-01 14:22 [PATCH -tip] x86: ptrace.c ptrace_get_debugreg() should be static Jaswinder Singh Rajput
@ 2009-11-21 13:33 ` tip-bot for Jaswinder Singh Rajput
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Jaswinder Singh Rajput @ 2009-11-21 13:33 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, jaswinder, jaswinderrajput, rostedt,
tglx, mingo
Commit-ID: 9d22b536609abf0d64648f99518676ea58245e3b
Gitweb: http://git.kernel.org/tip/9d22b536609abf0d64648f99518676ea58245e3b
Author: Jaswinder Singh Rajput <jaswinder@kernel.org>
AuthorDate: Wed, 1 Jul 2009 19:52:30 +0530
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 1 Jul 2009 16:53:27 +0200
x86: Mark ptrace_get_debugreg() as static
This sparse warning:
arch/x86/kernel/ptrace.c:560:15: warning: symbol 'ptrace_get_debugreg' was not declared. Should it be static?
triggers because ptrace_get_debugreg() is global but is only
used in a single .c file. change ptrace_get_debugreg() to
static to fix that - this also addresses the sparse warning.
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <1246458150.6940.19.camel@hpdv5.satnam>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/ptrace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
index b457f78..cabdabc 100644
--- a/arch/x86/kernel/ptrace.c
+++ b/arch/x86/kernel/ptrace.c
@@ -557,7 +557,7 @@ restore:
/*
* Handle PTRACE_PEEKUSR calls for the debug register area.
*/
-unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n)
+static unsigned long ptrace_get_debugreg(struct task_struct *tsk, int n)
{
struct thread_struct *thread = &(tsk->thread);
unsigned long val = 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-21 13:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-01 14:22 [PATCH -tip] x86: ptrace.c ptrace_get_debugreg() should be static Jaswinder Singh Rajput
2009-11-21 13:33 ` [tip:perf/core] x86: Mark ptrace_get_debugreg() as static tip-bot for Jaswinder Singh Rajput
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox