From: tip-bot for Jan Beulich <JBeulich@novell.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
jbeulich@novell.com, JBeulich@novell.com, tglx@linutronix.de,
mingo@elte.hu
Subject: [tip:x86/debug] x86: Don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler()
Date: Fri, 18 Feb 2011 10:39:37 GMT [thread overview]
Message-ID: <tip-bb3e6251a69e67d7620373ee18e35b404964273e@git.kernel.org> (raw)
In-Reply-To: <4D5D512902000078000326EE@vpn.id2.novell.com>
Commit-ID: bb3e6251a69e67d7620373ee18e35b404964273e
Gitweb: http://git.kernel.org/tip/bb3e6251a69e67d7620373ee18e35b404964273e
Author: Jan Beulich <JBeulich@novell.com>
AuthorDate: Thu, 17 Feb 2011 15:47:37 +0000
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 18 Feb 2011 08:52:29 +0100
x86: Don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler()
show_regs() already prints two(!) stack traces, no need for a third one.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
LKML-Reference: <4D5D512902000078000326EE@vpn.id2.novell.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/apic/hw_nmi.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/apic/hw_nmi.c b/arch/x86/kernel/apic/hw_nmi.c
index 79fd43c..c4e557a 100644
--- a/arch/x86/kernel/apic/hw_nmi.c
+++ b/arch/x86/kernel/apic/hw_nmi.c
@@ -83,7 +83,6 @@ arch_trigger_all_cpu_backtrace_handler(struct notifier_block *self,
arch_spin_lock(&lock);
printk(KERN_WARNING "NMI backtrace for cpu %d\n", cpu);
show_regs(regs);
- dump_stack();
arch_spin_unlock(&lock);
cpumask_clear_cpu(cpu, to_cpumask(backtrace_mask));
return NOTIFY_STOP;
prev parent reply other threads:[~2011-02-18 10:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 15:47 [PATCH] x86: don't call dump_stack() from arch_trigger_all_cpu_backtrace_handler() Jan Beulich
2011-02-18 7:44 ` Ingo Molnar
2011-02-18 7:59 ` Jan Beulich
2011-02-18 10:39 ` tip-bot for Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-bb3e6251a69e67d7620373ee18e35b404964273e@git.kernel.org \
--to=jbeulich@novell.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox