The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux-kernel@vger.kernel.org
Cc: linux1394-devel@vger.kernel.org,
	Kristian Hoegsberg <krh@bitplanet.net>,
	Randy Dunlap <randy.dunlap@oracle.com>
Subject: [review patch 3/2] firewire: nosy: note ioctls in ioctl-number.txt
Date: Thu, 22 Jul 2010 19:50:32 +0200 (CEST)	[thread overview]
Message-ID: <tkrat.8da176e6aa2f4ff6@s5r6.in-berlin.de> (raw)
In-Reply-To: <4C487F2B.4040405@s5r6.in-berlin.de>

These are the ioctls for the special-purpose misc device /dev/nosy, the
interface to the IEEE 1394 packet sniffer/ protocol analyzer driver.
Currently only the numbers 00...02 are in use; let's block a few more
for unforeseen use cases.

Cc: Randy Dunlap <rdunlap@xenotime.net>
Cc: Kristian Høgsberg <krh@bitplanet.net>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---

As mentioned in patch 1/2, this is up for discussion.  These ioctls have
been used during nosy's out-of-tree life for several years; but due to
the nature of this driver and its frontend as special-purpose
application on special hardware, an incompatible change of these ioctls
in the process of mainline merge won't be overly hurtful.

 Documentation/ioctl/ioctl-number.txt |    1 +
 1 file changed, 1 insertion(+)

Index: b/Documentation/ioctl/ioctl-number.txt
===================================================================
--- a/Documentation/ioctl/ioctl-number.txt
+++ b/Documentation/ioctl/ioctl-number.txt
@@ -79,6 +79,7 @@ Code  Seq#(hex)	Include File		Comments
 0x22	all	scsi/sg.h
 '#'	00-3F	IEEE 1394 Subsystem	Block for the entire subsystem
 '$'	00-0F	linux/perf_counter.h, linux/perf_event.h
+'&'	00-07	drivers/firewire/nosy-user.h
 '1'	00-1F	<linux/timepps.h>	PPS kit from Ulrich Windl
 					<ftp://ftp.de.kernel.org/pub/linux/daemons/ntp/PPS/>
 '2'	01-04	linux/i2o.h

-- 
Stefan Richter
-=====-==-=- -=== =-==-
http://arcgraph.de/sr/


  reply	other threads:[~2010-07-22 17:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-22  9:55 [review patch 0/2] new driver: Nosy, a low-budget FireWire packet sniffer Stefan Richter
2010-07-22  9:56 ` [review patch 1/2] firewire: new driver: nosy - IEEE 1394 traffic sniffer Stefan Richter
2010-07-22 16:07   ` Randy Dunlap
2010-07-22 17:26     ` Stefan Richter
2010-07-22 17:50       ` Stefan Richter [this message]
2010-07-22 18:04         ` [review patch 3/2] firewire: nosy: note ioctls in ioctl-number.txt Stefan Richter
2010-07-22  9:58 ` [review patch 2/2] tools/firewire: add nosy-dump, frontend to the driver nosy Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tkrat.8da176e6aa2f4ff6@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=krh@bitplanet.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox