Re: [review patch 3/2] firewire: nosy: note ioctls in ioctl-number.txt

[Stefan Richter <stefanr@s5r6.in-berlin.de>]

On 22 Jul, Stefan Richter wrote:
> These are the ioctls for the special-purpose misc device /dev/nosy, the
> interface to the IEEE 1394 packet sniffer/ protocol analyzer driver.
> Currently only the numbers 00...02 are in use; let's block a few more
> for unforeseen use cases.
> 
> Cc: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Kristian Høgsberg <krh@bitplanet.net>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> ---
> 
> As mentioned in patch 1/2, this is up for discussion.  These ioctls have
> been used during nosy's out-of-tree life for several years; but due to
> the nature of this driver and its frontend as special-purpose
> application on special hardware, an incompatible change of these ioctls
> in the process of mainline merge won't be overly hurtful.
> 
>  Documentation/ioctl/ioctl-number.txt |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: b/Documentation/ioctl/ioctl-number.txt
> ===================================================================
> --- a/Documentation/ioctl/ioctl-number.txt
> +++ b/Documentation/ioctl/ioctl-number.txt
> @@ -79,6 +79,7 @@ Code  Seq#(hex)	Include File		Comments
>  0x22	all	scsi/sg.h
>  '#'	00-3F	IEEE 1394 Subsystem	Block for the entire subsystem
>  '$'	00-0F	linux/perf_counter.h, linux/perf_event.h
> +'&'	00-07	drivers/firewire/nosy-user.h
>  '1'	00-1F	<linux/timepps.h>	PPS kit from Ulrich Windl
>  					<ftp://ftp.de.kernel.org/pub/linux/daemons/ntp/PPS/>
>  '2'	01-04	linux/i2o.h
> 

(Sorry, I mistyped the mailinglist address in that posting...)
-- 
Stefan Richter
-=====-==-=- -=== =-==-
http://arcgraph.de/sr/