From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] firewire: fw-ohci: fix debug logging of phy packets
Date: Sat, 12 Apr 2008 18:14:37 +0200 (CEST) [thread overview]
Message-ID: <tkrat.d9db3519cd83e9ff@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.f3c267b896f5d604@s5r6.in-berlin.de>
I wrote:
> --- linux.orig/drivers/firewire/fw-ohci.c
> +++ linux/drivers/firewire/fw-ohci.c
> @@ -371,10 +371,10 @@ static void log_ar_at_event(char dir, in
> if (unlikely(evt >= ARRAY_SIZE(evts)))
> evt = 0x1f;
>
> - if (header[0] == ~header[1]) {
> + if (header[1] == ~header[2]) {
> printk(KERN_DEBUG "A%c %s, %s, %08x\n",
> - dir, evts[evt], phys[header[0] >> 30 & 0x3],
> - header[0]);
> + dir, evts[evt], phys[header[1] >> 30 & 0x3],
> + header[1]);
This patch is bogus. The indices were right.
--
Stefan Richter
-=====-==--- -=-- -==--
http://arcgraph.de/sr/
prev parent reply other threads:[~2008-04-12 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 22:49 [PATCH 1/2] firewire: fw-ohci: fix debug logging of phy packets Stefan Richter
2008-04-10 22:51 ` [PATCH 2/2] firewire: fw-ohci: extend logging of bus generations and node ID Stefan Richter
2008-04-13 2:18 ` Jarod Wilson
2008-04-12 16:14 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.d9db3519cd83e9ff@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox