public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] firewire: fw-ohci: fix debug logging of phy packets
Date: Fri, 11 Apr 2008 00:49:38 +0200 (CEST)	[thread overview]
Message-ID: <tkrat.f3c267b896f5d604@s5r6.in-berlin.de> (raw)

Fix harmless but irritating off-by-one bug in patch "firewire: debug
interrupt events".  Should be folded into that one.

See OHCI 1.1 clause 8.7.1.4.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
 drivers/firewire/fw-ohci.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: linux/drivers/firewire/fw-ohci.c
===================================================================
--- linux.orig/drivers/firewire/fw-ohci.c
+++ linux/drivers/firewire/fw-ohci.c
@@ -371,10 +371,10 @@ static void log_ar_at_event(char dir, in
 	if (unlikely(evt >= ARRAY_SIZE(evts)))
 			evt = 0x1f;
 
-	if (header[0] == ~header[1]) {
+	if (header[1] == ~header[2]) {
 		printk(KERN_DEBUG "A%c %s, %s, %08x\n",
-		       dir, evts[evt], phys[header[0] >> 30 & 0x3],
-		       header[0]);
+		       dir, evts[evt], phys[header[1] >> 30 & 0x3],
+		       header[1]);
 		return;
 	}
 

-- 
Stefan Richter
-=====-==--- -=-- -=-==
http://arcgraph.de/sr/


             reply	other threads:[~2008-04-10 22:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-10 22:49 Stefan Richter [this message]
2008-04-10 22:51 ` [PATCH 2/2] firewire: fw-ohci: extend logging of bus generations and node ID Stefan Richter
2008-04-13  2:18   ` Jarod Wilson
2008-04-12 16:14 ` [PATCH 1/2] firewire: fw-ohci: fix debug logging of phy packets Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tkrat.f3c267b896f5d604@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox