* [PATCH] scsi: qla2xxx: Fix an loop timeout test
@ 2026-08-13 7:09 Dan Carpenter
2026-08-24 1:48 ` Martin K. Petersen (Oracle)
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2026-08-13 7:09 UTC (permalink / raw)
To: Atul Deshmukh
Cc: Nilesh Javali, GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, Saurav Kashyap, James Bottomley, linux-scsi,
linux-kernel, kernel-janitors
This loop timeout with "retries" set to -1, not 0. Fix the test
for failure.
Fixes: 7ec0effd30bb ("[SCSI] qla2xxx: Add support for ISP8044.")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/scsi/qla2xxx/qla_nx2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_nx2.c b/drivers/scsi/qla2xxx/qla_nx2.c
index 41ff6fbdb933..04d7ab6ad037 100644
--- a/drivers/scsi/qla2xxx/qla_nx2.c
+++ b/drivers/scsi/qla2xxx/qla_nx2.c
@@ -3507,7 +3507,7 @@ qla8044_poll_flash_status_reg(struct scsi_qla_host *vha)
msleep(QLA8044_FLASH_STATUS_REG_POLL_DELAY);
}
- if (!retries)
+ if (retries == -1)
ret_val = QLA_FUNCTION_FAILED;
return ret_val;
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Fix an loop timeout test
2026-08-13 7:09 [PATCH] scsi: qla2xxx: Fix an loop timeout test Dan Carpenter
@ 2026-08-24 1:48 ` Martin K. Petersen (Oracle)
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen (Oracle) @ 2026-08-24 1:48 UTC (permalink / raw)
To: Dan Carpenter
Cc: Atul Deshmukh, Nilesh Javali, GR-QLogic-Storage-Upstream,
James E.J. Bottomley, Martin K. Petersen, Saurav Kashyap,
James Bottomley, linux-scsi, linux-kernel, kernel-janitors
Dan,
> This loop timeout with "retries" set to -1, not 0. Fix the test for
> failure.
Applied to 7.3/scsi-staging, thanks!
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-24 1:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-13 7:09 [PATCH] scsi: qla2xxx: Fix an loop timeout test Dan Carpenter
2026-08-24 1:48 ` Martin K. Petersen (Oracle)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox