* [PATCH 1/1] scsi: pm8001: pm8001_hwi: Remove unused variable 'value'
@ 2020-11-16 10:41 Lee Jones
2020-11-16 10:44 ` Jinpu Wang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lee Jones @ 2020-11-16 10:41 UTC (permalink / raw)
To: jejb, martin.petersen; +Cc: linux-kernel, linux-scsi, Lee Jones, Jack Wang
Hasn't been used since 2009.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/pm8001/pm8001_hwi.c: In function ‘mpi_set_phys_g3_with_ssc’:
drivers/scsi/pm8001/pm8001_hwi.c:415:6: warning: variable ‘value’ set but not used [-Wunused-but-set-variable]
Cc: Jack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/pm8001/pm8001_hwi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c
index 2054c2b03d928..0a1e09b1cd580 100644
--- a/drivers/scsi/pm8001/pm8001_hwi.c
+++ b/drivers/scsi/pm8001/pm8001_hwi.c
@@ -416,7 +416,7 @@ int pm8001_bar4_shift(struct pm8001_hba_info *pm8001_ha, u32 shiftValue)
static void mpi_set_phys_g3_with_ssc(struct pm8001_hba_info *pm8001_ha,
u32 SSCbit)
{
- u32 value, offset, i;
+ u32 offset, i;
unsigned long flags;
#define SAS2_SETTINGS_LOCAL_PHY_0_3_SHIFT_ADDR 0x00030000
@@ -467,7 +467,7 @@ static void mpi_set_phys_g3_with_ssc(struct pm8001_hba_info *pm8001_ha,
so that the written value will be 0x8090c016.
This will ensure only down-spreading SSC is enabled on the SPC.
*************************************************************/
- value = pm8001_cr32(pm8001_ha, 2, 0xd8);
+ pm8001_cr32(pm8001_ha, 2, 0xd8);
pm8001_cw32(pm8001_ha, 2, 0xd8, 0x8000C016);
/*set the shifted destination address to 0x0 to avoid error operation */
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] scsi: pm8001: pm8001_hwi: Remove unused variable 'value'
2020-11-16 10:41 [PATCH 1/1] scsi: pm8001: pm8001_hwi: Remove unused variable 'value' Lee Jones
@ 2020-11-16 10:44 ` Jinpu Wang
2020-11-17 3:56 ` Martin K. Petersen
2020-11-20 3:31 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Jinpu Wang @ 2020-11-16 10:44 UTC (permalink / raw)
To: Lee Jones
Cc: James E.J. Bottomley, Martin K. Petersen, linux-kernel,
Linux SCSI Mailinglist
On Mon, Nov 16, 2020 at 11:41 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> Hasn't been used since 2009.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/scsi/pm8001/pm8001_hwi.c: In function ‘mpi_set_phys_g3_with_ssc’:
> drivers/scsi/pm8001/pm8001_hwi.c:415:6: warning: variable ‘value’ set but not used [-Wunused-but-set-variable]
>
> Cc: Jack Wang <jinpu.wang@cloud.ionos.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Thanks Lee.
> ---
> drivers/scsi/pm8001/pm8001_hwi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c
> index 2054c2b03d928..0a1e09b1cd580 100644
> --- a/drivers/scsi/pm8001/pm8001_hwi.c
> +++ b/drivers/scsi/pm8001/pm8001_hwi.c
> @@ -416,7 +416,7 @@ int pm8001_bar4_shift(struct pm8001_hba_info *pm8001_ha, u32 shiftValue)
> static void mpi_set_phys_g3_with_ssc(struct pm8001_hba_info *pm8001_ha,
> u32 SSCbit)
> {
> - u32 value, offset, i;
> + u32 offset, i;
> unsigned long flags;
>
> #define SAS2_SETTINGS_LOCAL_PHY_0_3_SHIFT_ADDR 0x00030000
> @@ -467,7 +467,7 @@ static void mpi_set_phys_g3_with_ssc(struct pm8001_hba_info *pm8001_ha,
> so that the written value will be 0x8090c016.
> This will ensure only down-spreading SSC is enabled on the SPC.
> *************************************************************/
> - value = pm8001_cr32(pm8001_ha, 2, 0xd8);
> + pm8001_cr32(pm8001_ha, 2, 0xd8);
> pm8001_cw32(pm8001_ha, 2, 0xd8, 0x8000C016);
>
> /*set the shifted destination address to 0x0 to avoid error operation */
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] scsi: pm8001: pm8001_hwi: Remove unused variable 'value'
2020-11-16 10:41 [PATCH 1/1] scsi: pm8001: pm8001_hwi: Remove unused variable 'value' Lee Jones
2020-11-16 10:44 ` Jinpu Wang
@ 2020-11-17 3:56 ` Martin K. Petersen
2020-11-20 3:31 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-11-17 3:56 UTC (permalink / raw)
To: Lee Jones; +Cc: jejb, martin.petersen, linux-kernel, linux-scsi, Jack Wang
Lee,
> Hasn't been used since 2009.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/scsi/pm8001/pm8001_hwi.c: In function ‘mpi_set_phys_g3_with_ssc’:
> drivers/scsi/pm8001/pm8001_hwi.c:415:6: warning: variable ‘value’ set but not used [-Wunused-but-set-variable]
Applied to 5.11/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] scsi: pm8001: pm8001_hwi: Remove unused variable 'value'
2020-11-16 10:41 [PATCH 1/1] scsi: pm8001: pm8001_hwi: Remove unused variable 'value' Lee Jones
2020-11-16 10:44 ` Jinpu Wang
2020-11-17 3:56 ` Martin K. Petersen
@ 2020-11-20 3:31 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-11-20 3:31 UTC (permalink / raw)
To: jejb, Lee Jones; +Cc: Martin K . Petersen, Jack Wang, linux-kernel, linux-scsi
On Mon, 16 Nov 2020 10:41:19 +0000, Lee Jones wrote:
> Hasn't been used since 2009.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/scsi/pm8001/pm8001_hwi.c: In function ‘mpi_set_phys_g3_with_ssc’:
> drivers/scsi/pm8001/pm8001_hwi.c:415:6: warning: variable ‘value’ set but not used [-Wunused-but-set-variable]
Applied to 5.11/scsi-queue, thanks!
[1/1] scsi: pm8001: Remove unused variable 'value'
https://git.kernel.org/mkp/scsi/c/a364a3ea32da
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-20 3:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-16 10:41 [PATCH 1/1] scsi: pm8001: pm8001_hwi: Remove unused variable 'value' Lee Jones
2020-11-16 10:44 ` Jinpu Wang
2020-11-17 3:56 ` Martin K. Petersen
2020-11-20 3:31 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox