[PATCH] scsi: aic7xxx: Fix REQUEST SENSE allocation length on big-endian hosts

[PATCH] scsi: aic7xxx: Fix REQUEST SENSE allocation length on big-endian hosts

[Imre Kaloz]

The REQUEST SENSE length was taken from sg->len after the
AHC_DMA_LAST_SEG flag was or-ed in and the value converted to
little-endian, so the 8-bit field is 0x80 on big-endian hosts and the
target is asked for 128 bytes into a 32-byte buffer. Use the buffer
size, as aic79xx does. On an SGI O2 with a Fujitsu MAX3147NC, the sense
data of its CHECK CONDITIONs during probe was lost.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Imre Kaloz <kaloz@kernel.org>
---
 drivers/scsi/aic7xxx/aic7xxx_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c
index b9761f9f0bbc..db330ca92767 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_core.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_core.c
@@ -1097,7 +1097,7 @@ ahc_handle_seqint(struct ahc_softc *ahc, u_int intstat)
 				sc->byte2 = SCB_GET_LUN(scb) << 5;
 			sc->unused[0] = 0;
 			sc->unused[1] = 0;
-			sc->length = sg->len;
+			sc->length = ahc_get_sense_bufsize(ahc, scb);
 			sc->control = 0;
 
 			/*

base-commit: 24a19b953e2a3d0ea5a8c4951a0ab8f32720c907
-- 
2.47.3

Re: [PATCH] scsi: aic7xxx: Fix REQUEST SENSE allocation length on big-endian hosts

[Martin K. Petersen]

Imre,

> The REQUEST SENSE length was taken from sg->len after the
> AHC_DMA_LAST_SEG flag was or-ed in and the value converted to
> little-endian, so the 8-bit field is 0x80 on big-endian hosts and the
> target is asked for 128 bytes into a 32-byte buffer. Use the buffer
> size, as aic79xx does. On an SGI O2 with a Fujitsu MAX3147NC, the
> sense data of its CHECK CONDITIONs during probe was lost.

Applied to 7.4/scsi-staging, thanks!

-- 
Martin K. Petersen

Re: [PATCH] scsi: aic7xxx: Fix REQUEST SENSE allocation length on big-endian hosts

[Martin K. Petersen (Oracle)]

On Tue, 13 Oct 2026 11:42:53 +0200, Imre Kaloz wrote:

> The REQUEST SENSE length was taken from sg->len after the
> AHC_DMA_LAST_SEG flag was or-ed in and the value converted to
> little-endian, so the 8-bit field is 0x80 on big-endian hosts and the
> target is asked for 128 bytes into a 32-byte buffer. Use the buffer
> size, as aic79xx does. On an SGI O2 with a Fujitsu MAX3147NC, the sense
> data of its CHECK CONDITIONs during probe was lost.
> 
> [...]

Applied to 7.4/scsi-queue, thanks!

[1/1] scsi: aic7xxx: Fix REQUEST SENSE allocation length on big-endian hosts
      https://git.kernel.org/mkp/scsi/c/9a2690eb4bbe

-- 
Martin K. Petersen