* [PATCH][next] scsi: dc395x: remove unused variable fact
@ 2026-07-14 7:35 Colin Ian King
2026-07-26 19:20 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2026-07-14 7:35 UTC (permalink / raw)
To: Oliver Neukum, Ali Akcaagac, Jamie Lenehan,
James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
The variable fact was used for debug but this was removed
in commit 62b434b0db2c ("scsi: dc395x: Remove DEBUG conditional
compilation"). The variable is now redundant and can be removed.
Cleans up clang scan build warning:
drivers/scsi/dc395x.c: In function ‘msgin_set_sync’:
drivers/scsi/dc395x.c:2185:13: warning: variable ‘fact’ set but not used [-Wunused-but-set-variable]
2185 | int fact;
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/scsi/dc395x.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index 6183ce05d8cf..ba490174a417 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -2182,7 +2182,6 @@ static void msgin_set_sync(struct AdapterCtlBlk *acb, struct ScsiReqBlk *srb)
{
struct DeviceCtlBlk *dcb = srb->dcb;
u8 bval;
- int fact;
if (srb->msgin_buf[4] > 15)
srb->msgin_buf[4] = 15;
@@ -2205,11 +2204,6 @@ static void msgin_set_sync(struct AdapterCtlBlk *acb, struct ScsiReqBlk *srb)
dcb->sync_period |= ALT_SYNC | bval;
dcb->min_nego_period = srb->msgin_buf[3];
- if (dcb->sync_period & WIDE_SYNC)
- fact = 500;
- else
- fact = 250;
-
if (!(srb->state & SRB_DO_SYNC_NEGO)) {
/* Reply with corrected SDTR Message */
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] scsi: dc395x: remove unused variable fact
2026-07-14 7:35 [PATCH][next] scsi: dc395x: remove unused variable fact Colin Ian King
@ 2026-07-26 19:20 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2026-07-26 19:20 UTC (permalink / raw)
To: Colin Ian King
Cc: Oliver Neukum, Ali Akcaagac, Jamie Lenehan,
James E . J . Bottomley, Martin K . Petersen, linux-scsi,
kernel-janitors, linux-kernel
Colin,
> The variable fact was used for debug but this was removed in commit
> 62b434b0db2c ("scsi: dc395x: Remove DEBUG conditional compilation").
> The variable is now redundant and can be removed.
Applied to 7.3/scsi-staging, thanks!
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-26 19:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-14 7:35 [PATCH][next] scsi: dc395x: remove unused variable fact Colin Ian King
2026-07-26 19:20 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox