* [PATCH 0/2] tools/nolibc: support for 32-bit s390
@ 2025-01-22 18:43 Thomas Weißschuh
2025-01-22 18:43 ` [PATCH 1/2] selftests/nolibc: rename s390 to s390x Thomas Weißschuh
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Thomas Weißschuh @ 2025-01-22 18:43 UTC (permalink / raw)
To: Willy Tarreau, Shuah Khan
Cc: linux-kselftest, linux-kernel, Thomas Weißschuh
Support for 32-bit s390 is very easy to implement and useful for
testing. For example I used to test some generic compat_ptr() logic,
which is only testable on 32-bit s390.
The series depends on my other series
"selftests/nolibc: test kernel configuration cleanups".
(It's not a hard dependency, only a minor diff conflict)
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Thomas Weißschuh (2):
selftests/nolibc: rename s390 to s390x
tools/nolibc: add support for 32-bit s390
tools/include/nolibc/arch-s390.h | 5 +++++
tools/include/nolibc/arch.h | 2 +-
tools/testing/selftests/nolibc/Makefile | 10 ++++++++--
tools/testing/selftests/nolibc/run-tests.sh | 8 +++++++-
4 files changed, 21 insertions(+), 4 deletions(-)
---
base-commit: 0597614d84c8593ba906418bf3c0c0de1e02e82a
change-id: 20250122-nolibc-s390-e57141682c88
Best regards,
--
Thomas Weißschuh <linux@weissschuh.net>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/2] selftests/nolibc: rename s390 to s390x 2025-01-22 18:43 [PATCH 0/2] tools/nolibc: support for 32-bit s390 Thomas Weißschuh @ 2025-01-22 18:43 ` Thomas Weißschuh 2025-01-22 18:43 ` [PATCH 2/2] tools/nolibc: add support for 32-bit s390 Thomas Weißschuh 2025-02-01 10:19 ` [PATCH 0/2] tools/nolibc: " Willy Tarreau 2 siblings, 0 replies; 5+ messages in thread From: Thomas Weißschuh @ 2025-01-22 18:43 UTC (permalink / raw) To: Willy Tarreau, Shuah Khan Cc: linux-kselftest, linux-kernel, Thomas Weißschuh Support for 32-bit s390 is about to be added. As "s39032" would look horrible, use the another naming scheme. 32-bit s390 is "s390" and 64-bit s390 is "s390x", similar to how it is handled in various toolchain components. Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> --- tools/testing/selftests/nolibc/Makefile | 11 ++++++----- tools/testing/selftests/nolibc/run-tests.sh | 3 ++- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/nolibc/Makefile b/tools/testing/selftests/nolibc/Makefile index b74fa74e5ce296f032bec76ce9b3f5a3debe2b40..dad0d9fd7702f8dc9a9a552cda5305f8973c5469 100644 --- a/tools/testing/selftests/nolibc/Makefile +++ b/tools/testing/selftests/nolibc/Makefile @@ -54,6 +54,7 @@ ARCH_mips32le = mips ARCH_mips32be = mips ARCH_riscv32 = riscv ARCH_riscv64 = riscv +ARCH_s390x = s390 ARCH := $(or $(ARCH_$(XARCH)),$(XARCH)) # kernel image names by architecture @@ -70,7 +71,7 @@ IMAGE_ppc64le = arch/powerpc/boot/zImage IMAGE_riscv = arch/riscv/boot/Image IMAGE_riscv32 = arch/riscv/boot/Image IMAGE_riscv64 = arch/riscv/boot/Image -IMAGE_s390 = arch/s390/boot/bzImage +IMAGE_s390x = arch/s390/boot/bzImage IMAGE_loongarch = arch/loongarch/boot/vmlinuz.efi IMAGE = $(objtree)/$(IMAGE_$(XARCH)) IMAGE_NAME = $(notdir $(IMAGE)) @@ -89,7 +90,7 @@ DEFCONFIG_ppc64le = powernv_defconfig DEFCONFIG_riscv = defconfig DEFCONFIG_riscv32 = rv32_defconfig DEFCONFIG_riscv64 = defconfig -DEFCONFIG_s390 = defconfig +DEFCONFIG_s390x = defconfig DEFCONFIG_loongarch = defconfig DEFCONFIG = $(DEFCONFIG_$(XARCH)) @@ -110,7 +111,7 @@ QEMU_ARCH_ppc64le = ppc64 QEMU_ARCH_riscv = riscv64 QEMU_ARCH_riscv32 = riscv32 QEMU_ARCH_riscv64 = riscv64 -QEMU_ARCH_s390 = s390x +QEMU_ARCH_s390x = s390x QEMU_ARCH_loongarch = loongarch64 QEMU_ARCH = $(QEMU_ARCH_$(XARCH)) @@ -138,7 +139,7 @@ QEMU_ARGS_ppc64le = -M powernv -append "console=hvc0 panic=-1 $(TEST:%=NOLIBC QEMU_ARGS_riscv = -M virt -append "console=ttyS0 panic=-1 $(TEST:%=NOLIBC_TEST=%)" QEMU_ARGS_riscv32 = -M virt -append "console=ttyS0 panic=-1 $(TEST:%=NOLIBC_TEST=%)" QEMU_ARGS_riscv64 = -M virt -append "console=ttyS0 panic=-1 $(TEST:%=NOLIBC_TEST=%)" -QEMU_ARGS_s390 = -M s390-ccw-virtio -append "console=ttyS0 panic=-1 $(TEST:%=NOLIBC_TEST=%)" +QEMU_ARGS_s390x = -M s390-ccw-virtio -append "console=ttyS0 panic=-1 $(TEST:%=NOLIBC_TEST=%)" QEMU_ARGS_loongarch = -M virt -append "console=ttyS0,115200 panic=-1 $(TEST:%=NOLIBC_TEST=%)" QEMU_ARGS = -m 1G $(QEMU_ARGS_$(XARCH)) $(QEMU_ARGS_BIOS) $(QEMU_ARGS_EXTRA) @@ -156,7 +157,7 @@ CFLAGS_i386 = $(call cc-option,-m32) CFLAGS_ppc = -m32 -mbig-endian -mno-vsx $(call cc-option,-mmultiple) CFLAGS_ppc64 = -m64 -mbig-endian -mno-vsx $(call cc-option,-mmultiple) CFLAGS_ppc64le = -m64 -mlittle-endian -mno-vsx $(call cc-option,-mabi=elfv2) -CFLAGS_s390 = -m64 +CFLAGS_s390x = -m64 CFLAGS_mips32le = -EL -mabi=32 -fPIC CFLAGS_mips32be = -EB -mabi=32 CFLAGS_STACKPROTECTOR ?= $(call cc-option,-mstack-protector-guard=global $(call cc-option,-fstack-protector-all)) diff --git a/tools/testing/selftests/nolibc/run-tests.sh b/tools/testing/selftests/nolibc/run-tests.sh index 664f92e1c5500f726ab33247321b96e8602ce185..fe4d48cc054abb1e922b31aa7b6a2395aaf61f5f 100755 --- a/tools/testing/selftests/nolibc/run-tests.sh +++ b/tools/testing/selftests/nolibc/run-tests.sh @@ -17,7 +17,7 @@ perform_download=0 test_mode=system werror=1 llvm= -archs="i386 x86_64 arm64 arm mips32le mips32be ppc ppc64 ppc64le riscv32 riscv64 s390 loongarch" +archs="i386 x86_64 arm64 arm mips32le mips32be ppc ppc64 ppc64le riscv32 riscv64 s390x loongarch" TEMP=$(getopt -o 'j:d:c:b:a:m:pelh' -n "$0" -- "$@") @@ -100,6 +100,7 @@ crosstool_arch() { riscv) echo riscv64;; loongarch) echo loongarch64;; mips*) echo mips;; + s390*) echo s390;; *) echo "$1";; esac } -- 2.48.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] tools/nolibc: add support for 32-bit s390 2025-01-22 18:43 [PATCH 0/2] tools/nolibc: support for 32-bit s390 Thomas Weißschuh 2025-01-22 18:43 ` [PATCH 1/2] selftests/nolibc: rename s390 to s390x Thomas Weißschuh @ 2025-01-22 18:43 ` Thomas Weißschuh 2025-02-05 8:00 ` Sven Schnelle 2025-02-01 10:19 ` [PATCH 0/2] tools/nolibc: " Willy Tarreau 2 siblings, 1 reply; 5+ messages in thread From: Thomas Weißschuh @ 2025-01-22 18:43 UTC (permalink / raw) To: Willy Tarreau, Shuah Khan Cc: linux-kselftest, linux-kernel, Thomas Weißschuh 32-bit s390 is very close to the existing 64-bit implementation. Some special handling is necessary as there is neither LLVM nor QEMU support. Also the kernel itself can not build natively for 32-bit s390, so instead the test program is executed with a 64-bit kernel. Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> --- tools/include/nolibc/arch-s390.h | 5 +++++ tools/include/nolibc/arch.h | 2 +- tools/testing/selftests/nolibc/Makefile | 5 +++++ tools/testing/selftests/nolibc/run-tests.sh | 7 ++++++- 4 files changed, 17 insertions(+), 2 deletions(-) diff --git a/tools/include/nolibc/arch-s390.h b/tools/include/nolibc/arch-s390.h index f9ab83a219b8a2d5e53b0b303d8bf0bf78280d5f..3f2fb00ca101cc052f3b794b743e9e5734fe5a77 100644 --- a/tools/include/nolibc/arch-s390.h +++ b/tools/include/nolibc/arch-s390.h @@ -143,8 +143,13 @@ void __attribute__((weak, noreturn)) __nolibc_entrypoint __no_stack_protector _start(void) { __asm__ volatile ( +#ifdef __s390x__ "lgr %r2, %r15\n" /* save stack pointer to %r2, as arg1 of _start_c */ "aghi %r15, -160\n" /* allocate new stackframe */ +#else + "lr %r2, %r15\n" + "ahi %r15, -160\n" +#endif "xc 0(8,%r15), 0(%r15)\n" /* clear backchain */ "brasl %r14, _start_c\n" /* transfer to c runtime */ ); diff --git a/tools/include/nolibc/arch.h b/tools/include/nolibc/arch.h index c8f4e5d3add9eb5b8a438900c084dc0449fcfbd6..8a2c143c0fba288147e5a7bf9db38ffb08367616 100644 --- a/tools/include/nolibc/arch.h +++ b/tools/include/nolibc/arch.h @@ -29,7 +29,7 @@ #include "arch-powerpc.h" #elif defined(__riscv) #include "arch-riscv.h" -#elif defined(__s390x__) +#elif defined(__s390x__) || defined(__s390__) #include "arch-s390.h" #elif defined(__loongarch__) #include "arch-loongarch.h" diff --git a/tools/testing/selftests/nolibc/Makefile b/tools/testing/selftests/nolibc/Makefile index dad0d9fd7702f8dc9a9a552cda5305f8973c5469..dc5cf19dd74389336b619e15e07f1c635241b7d7 100644 --- a/tools/testing/selftests/nolibc/Makefile +++ b/tools/testing/selftests/nolibc/Makefile @@ -72,6 +72,7 @@ IMAGE_riscv = arch/riscv/boot/Image IMAGE_riscv32 = arch/riscv/boot/Image IMAGE_riscv64 = arch/riscv/boot/Image IMAGE_s390x = arch/s390/boot/bzImage +IMAGE_s390 = arch/s390/boot/bzImage IMAGE_loongarch = arch/loongarch/boot/vmlinuz.efi IMAGE = $(objtree)/$(IMAGE_$(XARCH)) IMAGE_NAME = $(notdir $(IMAGE)) @@ -91,6 +92,7 @@ DEFCONFIG_riscv = defconfig DEFCONFIG_riscv32 = rv32_defconfig DEFCONFIG_riscv64 = defconfig DEFCONFIG_s390x = defconfig +DEFCONFIG_s390 = defconfig compat.config DEFCONFIG_loongarch = defconfig DEFCONFIG = $(DEFCONFIG_$(XARCH)) @@ -112,6 +114,7 @@ QEMU_ARCH_riscv = riscv64 QEMU_ARCH_riscv32 = riscv32 QEMU_ARCH_riscv64 = riscv64 QEMU_ARCH_s390x = s390x +QEMU_ARCH_s390 = s390x QEMU_ARCH_loongarch = loongarch64 QEMU_ARCH = $(QEMU_ARCH_$(XARCH)) @@ -140,6 +143,7 @@ QEMU_ARGS_riscv = -M virt -append "console=ttyS0 panic=-1 $(TEST:%=NOLIBC_T QEMU_ARGS_riscv32 = -M virt -append "console=ttyS0 panic=-1 $(TEST:%=NOLIBC_TEST=%)" QEMU_ARGS_riscv64 = -M virt -append "console=ttyS0 panic=-1 $(TEST:%=NOLIBC_TEST=%)" QEMU_ARGS_s390x = -M s390-ccw-virtio -append "console=ttyS0 panic=-1 $(TEST:%=NOLIBC_TEST=%)" +QEMU_ARGS_s390 = -M s390-ccw-virtio -append "console=ttyS0 panic=-1 $(TEST:%=NOLIBC_TEST=%)" QEMU_ARGS_loongarch = -M virt -append "console=ttyS0,115200 panic=-1 $(TEST:%=NOLIBC_TEST=%)" QEMU_ARGS = -m 1G $(QEMU_ARGS_$(XARCH)) $(QEMU_ARGS_BIOS) $(QEMU_ARGS_EXTRA) @@ -158,6 +162,7 @@ CFLAGS_ppc = -m32 -mbig-endian -mno-vsx $(call cc-option,-mmultiple) CFLAGS_ppc64 = -m64 -mbig-endian -mno-vsx $(call cc-option,-mmultiple) CFLAGS_ppc64le = -m64 -mlittle-endian -mno-vsx $(call cc-option,-mabi=elfv2) CFLAGS_s390x = -m64 +CFLAGS_s390 = -m31 CFLAGS_mips32le = -EL -mabi=32 -fPIC CFLAGS_mips32be = -EB -mabi=32 CFLAGS_STACKPROTECTOR ?= $(call cc-option,-mstack-protector-guard=global $(call cc-option,-fstack-protector-all)) diff --git a/tools/testing/selftests/nolibc/run-tests.sh b/tools/testing/selftests/nolibc/run-tests.sh index fe4d48cc054abb1e922b31aa7b6a2395aaf61f5f..79874f669b2a364ad1cb2399b4ebbab5ec6c9de9 100755 --- a/tools/testing/selftests/nolibc/run-tests.sh +++ b/tools/testing/selftests/nolibc/run-tests.sh @@ -17,7 +17,7 @@ perform_download=0 test_mode=system werror=1 llvm= -archs="i386 x86_64 arm64 arm mips32le mips32be ppc ppc64 ppc64le riscv32 riscv64 s390x loongarch" +archs="i386 x86_64 arm64 arm mips32le mips32be ppc ppc64 ppc64le riscv32 riscv64 s390x s390 loongarch" TEMP=$(getopt -o 'j:d:c:b:a:m:pelh' -n "$0" -- "$@") @@ -171,6 +171,11 @@ test_arch() { exit 1 esac printf '%-15s' "$arch:" + if [ "$arch" = "s390" ] && ([ "$llvm" = "1" ] || [ "$test_mode" = "user" ]); then + echo "Unsupported configuration" + return + fi + swallow_output "${MAKE[@]}" CFLAGS_EXTRA="$CFLAGS_EXTRA" defconfig "$test_target" V=1 cp run.out run.out."${arch}" "${MAKE[@]}" report | grep passed -- 2.48.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] tools/nolibc: add support for 32-bit s390 2025-01-22 18:43 ` [PATCH 2/2] tools/nolibc: add support for 32-bit s390 Thomas Weißschuh @ 2025-02-05 8:00 ` Sven Schnelle 0 siblings, 0 replies; 5+ messages in thread From: Sven Schnelle @ 2025-02-05 8:00 UTC (permalink / raw) To: Thomas Weißschuh Cc: Willy Tarreau, Shuah Khan, linux-kselftest, linux-kernel Hi Thomas, Thomas Weißschuh <linux@weissschuh.net> writes: > 32-bit s390 is very close to the existing 64-bit implementation. > > Some special handling is necessary as there is neither LLVM nor > QEMU support. Also the kernel itself can not build natively for 32-bit > s390, so instead the test program is executed with a 64-bit kernel. > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > --- > tools/include/nolibc/arch-s390.h | 5 +++++ > tools/include/nolibc/arch.h | 2 +- > tools/testing/selftests/nolibc/Makefile | 5 +++++ > tools/testing/selftests/nolibc/run-tests.sh | 7 ++++++- > 4 files changed, 17 insertions(+), 2 deletions(-) > > diff --git a/tools/include/nolibc/arch-s390.h b/tools/include/nolibc/arch-s390.h > index f9ab83a219b8a2d5e53b0b303d8bf0bf78280d5f..3f2fb00ca101cc052f3b794b743e9e5734fe5a77 100644 > --- a/tools/include/nolibc/arch-s390.h > +++ b/tools/include/nolibc/arch-s390.h > @@ -143,8 +143,13 @@ > void __attribute__((weak, noreturn)) __nolibc_entrypoint __no_stack_protector _start(void) > { > __asm__ volatile ( > +#ifdef __s390x__ > "lgr %r2, %r15\n" /* save stack pointer to %r2, as arg1 of _start_c */ > "aghi %r15, -160\n" /* allocate new stackframe */ > +#else > + "lr %r2, %r15\n" > + "ahi %r15, -160\n" > +#endif compat mode is using a stack size of 96 bytes, so the ahi above needs to be adjusted. > "xc 0(8,%r15), 0(%r15)\n" /* clear backchain */ > "brasl %r14, _start_c\n" /* transfer to c runtime */ > ); > diff --git a/tools/include/nolibc/arch.h b/tools/include/nolibc/arch.h > index c8f4e5d3add9eb5b8a438900c084dc0449fcfbd6..8a2c143c0fba288147e5a7bf9db38ffb08367616 100644 > --- a/tools/include/nolibc/arch.h > +++ b/tools/include/nolibc/arch.h > @@ -29,7 +29,7 @@ > #include "arch-powerpc.h" > #elif defined(__riscv) > #include "arch-riscv.h" > -#elif defined(__s390x__) > +#elif defined(__s390x__) || defined(__s390__) > #include "arch-s390.h" > #elif defined(__loongarch__) > #include "arch-loongarch.h" > diff --git a/tools/testing/selftests/nolibc/Makefile b/tools/testing/selftests/nolibc/Makefile > index dad0d9fd7702f8dc9a9a552cda5305f8973c5469..dc5cf19dd74389336b619e15e07f1c635241b7d7 100644 > --- a/tools/testing/selftests/nolibc/Makefile > +++ b/tools/testing/selftests/nolibc/Makefile > @@ -72,6 +72,7 @@ IMAGE_riscv = arch/riscv/boot/Image > IMAGE_riscv32 = arch/riscv/boot/Image > IMAGE_riscv64 = arch/riscv/boot/Image > IMAGE_s390x = arch/s390/boot/bzImage > +IMAGE_s390 = arch/s390/boot/bzImage > IMAGE_loongarch = arch/loongarch/boot/vmlinuz.efi > IMAGE = $(objtree)/$(IMAGE_$(XARCH)) > IMAGE_NAME = $(notdir $(IMAGE)) > @@ -91,6 +92,7 @@ DEFCONFIG_riscv = defconfig > DEFCONFIG_riscv32 = rv32_defconfig > DEFCONFIG_riscv64 = defconfig > DEFCONFIG_s390x = defconfig > +DEFCONFIG_s390 = defconfig compat.config > DEFCONFIG_loongarch = defconfig > DEFCONFIG = $(DEFCONFIG_$(XARCH)) > > @@ -112,6 +114,7 @@ QEMU_ARCH_riscv = riscv64 > QEMU_ARCH_riscv32 = riscv32 > QEMU_ARCH_riscv64 = riscv64 > QEMU_ARCH_s390x = s390x > +QEMU_ARCH_s390 = s390x > QEMU_ARCH_loongarch = loongarch64 > QEMU_ARCH = $(QEMU_ARCH_$(XARCH)) > > @@ -140,6 +143,7 @@ QEMU_ARGS_riscv = -M virt -append "console=ttyS0 panic=-1 $(TEST:%=NOLIBC_T > QEMU_ARGS_riscv32 = -M virt -append "console=ttyS0 panic=-1 $(TEST:%=NOLIBC_TEST=%)" > QEMU_ARGS_riscv64 = -M virt -append "console=ttyS0 panic=-1 $(TEST:%=NOLIBC_TEST=%)" > QEMU_ARGS_s390x = -M s390-ccw-virtio -append "console=ttyS0 panic=-1 $(TEST:%=NOLIBC_TEST=%)" > +QEMU_ARGS_s390 = -M s390-ccw-virtio -append "console=ttyS0 panic=-1 $(TEST:%=NOLIBC_TEST=%)" > QEMU_ARGS_loongarch = -M virt -append "console=ttyS0,115200 panic=-1 $(TEST:%=NOLIBC_TEST=%)" > QEMU_ARGS = -m 1G $(QEMU_ARGS_$(XARCH)) $(QEMU_ARGS_BIOS) $(QEMU_ARGS_EXTRA) > > @@ -158,6 +162,7 @@ CFLAGS_ppc = -m32 -mbig-endian -mno-vsx $(call cc-option,-mmultiple) > CFLAGS_ppc64 = -m64 -mbig-endian -mno-vsx $(call cc-option,-mmultiple) > CFLAGS_ppc64le = -m64 -mlittle-endian -mno-vsx $(call cc-option,-mabi=elfv2) > CFLAGS_s390x = -m64 > +CFLAGS_s390 = -m31 > CFLAGS_mips32le = -EL -mabi=32 -fPIC > CFLAGS_mips32be = -EB -mabi=32 > CFLAGS_STACKPROTECTOR ?= $(call cc-option,-mstack-protector-guard=global $(call cc-option,-fstack-protector-all)) > diff --git a/tools/testing/selftests/nolibc/run-tests.sh b/tools/testing/selftests/nolibc/run-tests.sh > index fe4d48cc054abb1e922b31aa7b6a2395aaf61f5f..79874f669b2a364ad1cb2399b4ebbab5ec6c9de9 100755 > --- a/tools/testing/selftests/nolibc/run-tests.sh > +++ b/tools/testing/selftests/nolibc/run-tests.sh > @@ -17,7 +17,7 @@ perform_download=0 > test_mode=system > werror=1 > llvm= > -archs="i386 x86_64 arm64 arm mips32le mips32be ppc ppc64 ppc64le riscv32 riscv64 s390x loongarch" > +archs="i386 x86_64 arm64 arm mips32le mips32be ppc ppc64 ppc64le riscv32 riscv64 s390x s390 loongarch" > > TEMP=$(getopt -o 'j:d:c:b:a:m:pelh' -n "$0" -- "$@") > > @@ -171,6 +171,11 @@ test_arch() { > exit 1 > esac > printf '%-15s' "$arch:" > + if [ "$arch" = "s390" ] && ([ "$llvm" = "1" ] || [ "$test_mode" = "user" ]); then > + echo "Unsupported configuration" > + return > + fi > + > swallow_output "${MAKE[@]}" CFLAGS_EXTRA="$CFLAGS_EXTRA" defconfig "$test_target" V=1 > cp run.out run.out."${arch}" > "${MAKE[@]}" report | grep passed ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] tools/nolibc: support for 32-bit s390 2025-01-22 18:43 [PATCH 0/2] tools/nolibc: support for 32-bit s390 Thomas Weißschuh 2025-01-22 18:43 ` [PATCH 1/2] selftests/nolibc: rename s390 to s390x Thomas Weißschuh 2025-01-22 18:43 ` [PATCH 2/2] tools/nolibc: add support for 32-bit s390 Thomas Weißschuh @ 2025-02-01 10:19 ` Willy Tarreau 2 siblings, 0 replies; 5+ messages in thread From: Willy Tarreau @ 2025-02-01 10:19 UTC (permalink / raw) To: Thomas Weißschuh Cc: Shuah Khan, linux-kselftest, linux-kernel, Sven Schnelle On Wed, Jan 22, 2025 at 07:43:44PM +0100, Thomas Weißschuh wrote: > Support for 32-bit s390 is very easy to implement and useful for > testing. For example I used to test some generic compat_ptr() logic, > which is only testable on 32-bit s390. > > The series depends on my other series > "selftests/nolibc: test kernel configuration cleanups". > (It's not a hard dependency, only a minor diff conflict) > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> I'm generally fine with the series from the nolibc perspective. I've added Sven in Cc in case he wants to double-check anything, given that he initially contributed the s390 support. Acked-by: Willy Tarreau <w@1wt.eu> Thanks! Willy ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-02-05 8:01 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-01-22 18:43 [PATCH 0/2] tools/nolibc: support for 32-bit s390 Thomas Weißschuh 2025-01-22 18:43 ` [PATCH 1/2] selftests/nolibc: rename s390 to s390x Thomas Weißschuh 2025-01-22 18:43 ` [PATCH 2/2] tools/nolibc: add support for 32-bit s390 Thomas Weißschuh 2025-02-05 8:00 ` Sven Schnelle 2025-02-01 10:19 ` [PATCH 0/2] tools/nolibc: " Willy Tarreau
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox