* [PATCH v2] selftests/mqueue: fix 5 warnings about signed/unsigned mismatches
@ 2024-05-08 20:00 John Hubbard
2024-05-09 12:42 ` Ryan Roberts
2024-05-10 11:41 ` Muhammad Usama Anjum
0 siblings, 2 replies; 4+ messages in thread
From: John Hubbard @ 2024-05-08 20:00 UTC (permalink / raw)
To: Shuah Khan
Cc: Andrew Morton, David Hildenbrand, Ryan Roberts, SeongJae Park,
Valentin Obst, linux-kselftest, LKML, llvm, John Hubbard
When building with clang, via:
make LLVM=1 -C tools/testing/selftest
...clang warns about several cases of using a signed integer for the
priority argument to mq_receive(3), which expects an unsigned int.
Fix this by declaring the type as unsigned int in all cases.
Also, both input and output priority are unsigned, per the man pages, so
let's change the type of both priorities throughout, even though clang
did not warn about the prio_out variable.
Also, add an argument name to test->func(), in order to address another
warning from clang.
Cc: Ryan Roberts <ryan.roberts@arm.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
tools/testing/selftests/mqueue/mq_perf_tests.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/tools/testing/selftests/mqueue/mq_perf_tests.c b/tools/testing/selftests/mqueue/mq_perf_tests.c
index 5c16159d0bcd..9380c656581f 100644
--- a/tools/testing/selftests/mqueue/mq_perf_tests.c
+++ b/tools/testing/selftests/mqueue/mq_perf_tests.c
@@ -323,7 +323,8 @@ void *fake_cont_thread(void *arg)
void *cont_thread(void *arg)
{
char buff[MSG_SIZE];
- int i, priority;
+ int i;
+ unsigned int priority;
for (i = 0; i < num_cpus_to_pin; i++)
if (cpu_threads[i] == pthread_self())
@@ -373,27 +374,27 @@ void *cont_thread(void *arg)
struct test {
char *desc;
- void (*func)(int *);
+ void (*func)(unsigned int *prio);
};
-void const_prio(int *prio)
+void const_prio(unsigned int *prio)
{
return;
}
-void inc_prio(int *prio)
+void inc_prio(unsigned int *prio)
{
if (++*prio == mq_prio_max)
*prio = 0;
}
-void dec_prio(int *prio)
+void dec_prio(unsigned int *prio)
{
if (--*prio < 0)
*prio = mq_prio_max - 1;
}
-void random_prio(int *prio)
+void random_prio(unsigned int *prio)
{
*prio = random() % mq_prio_max;
}
@@ -425,7 +426,7 @@ struct test test2[] = {
void *perf_test_thread(void *arg)
{
char buff[MSG_SIZE];
- int prio_out, prio_in;
+ unsigned int prio_out, prio_in;
int i;
clockid_t clock;
pthread_t *t;
base-commit: 45db3ab70092637967967bfd8e6144017638563c
prerequisite-patch-id: b901ece2a5b78503e2fb5480f20e304d36a0ea27
--
2.45.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] selftests/mqueue: fix 5 warnings about signed/unsigned mismatches
2024-05-08 20:00 [PATCH v2] selftests/mqueue: fix 5 warnings about signed/unsigned mismatches John Hubbard
@ 2024-05-09 12:42 ` Ryan Roberts
2024-05-10 11:41 ` Muhammad Usama Anjum
1 sibling, 0 replies; 4+ messages in thread
From: Ryan Roberts @ 2024-05-09 12:42 UTC (permalink / raw)
To: John Hubbard, Shuah Khan
Cc: Andrew Morton, David Hildenbrand, SeongJae Park, Valentin Obst,
linux-kselftest, LKML, llvm
On 08/05/2024 21:00, John Hubbard wrote:
> When building with clang, via:
>
> make LLVM=1 -C tools/testing/selftest
>
> ...clang warns about several cases of using a signed integer for the
> priority argument to mq_receive(3), which expects an unsigned int.
>
> Fix this by declaring the type as unsigned int in all cases.
>
> Also, both input and output priority are unsigned, per the man pages, so
> let's change the type of both priorities throughout, even though clang
> did not warn about the prio_out variable.
>
> Also, add an argument name to test->func(), in order to address another
> warning from clang.
>
> Cc: Ryan Roberts <ryan.roberts@arm.com>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Ryan Roberts <ryan.roberts@arm.com>
> ---
> tools/testing/selftests/mqueue/mq_perf_tests.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/tools/testing/selftests/mqueue/mq_perf_tests.c b/tools/testing/selftests/mqueue/mq_perf_tests.c
> index 5c16159d0bcd..9380c656581f 100644
> --- a/tools/testing/selftests/mqueue/mq_perf_tests.c
> +++ b/tools/testing/selftests/mqueue/mq_perf_tests.c
> @@ -323,7 +323,8 @@ void *fake_cont_thread(void *arg)
> void *cont_thread(void *arg)
> {
> char buff[MSG_SIZE];
> - int i, priority;
> + int i;
> + unsigned int priority;
>
> for (i = 0; i < num_cpus_to_pin; i++)
> if (cpu_threads[i] == pthread_self())
> @@ -373,27 +374,27 @@ void *cont_thread(void *arg)
>
> struct test {
> char *desc;
> - void (*func)(int *);
> + void (*func)(unsigned int *prio);
> };
>
> -void const_prio(int *prio)
> +void const_prio(unsigned int *prio)
> {
> return;
> }
>
> -void inc_prio(int *prio)
> +void inc_prio(unsigned int *prio)
> {
> if (++*prio == mq_prio_max)
> *prio = 0;
> }
>
> -void dec_prio(int *prio)
> +void dec_prio(unsigned int *prio)
> {
> if (--*prio < 0)
> *prio = mq_prio_max - 1;
> }
>
> -void random_prio(int *prio)
> +void random_prio(unsigned int *prio)
> {
> *prio = random() % mq_prio_max;
> }
> @@ -425,7 +426,7 @@ struct test test2[] = {
> void *perf_test_thread(void *arg)
> {
> char buff[MSG_SIZE];
> - int prio_out, prio_in;
> + unsigned int prio_out, prio_in;
> int i;
> clockid_t clock;
> pthread_t *t;
>
> base-commit: 45db3ab70092637967967bfd8e6144017638563c
> prerequisite-patch-id: b901ece2a5b78503e2fb5480f20e304d36a0ea27
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] selftests/mqueue: fix 5 warnings about signed/unsigned mismatches
2024-05-08 20:00 [PATCH v2] selftests/mqueue: fix 5 warnings about signed/unsigned mismatches John Hubbard
2024-05-09 12:42 ` Ryan Roberts
@ 2024-05-10 11:41 ` Muhammad Usama Anjum
1 sibling, 0 replies; 4+ messages in thread
From: Muhammad Usama Anjum @ 2024-05-10 11:41 UTC (permalink / raw)
To: John Hubbard, Shuah Khan
Cc: Muhammad Usama Anjum, Andrew Morton, David Hildenbrand,
Ryan Roberts, SeongJae Park, Valentin Obst, linux-kselftest, LKML,
llvm
On 5/9/24 1:00 AM, John Hubbard wrote:
> When building with clang, via:
>
> make LLVM=1 -C tools/testing/selftest
>
> ...clang warns about several cases of using a signed integer for the
> priority argument to mq_receive(3), which expects an unsigned int.
>
> Fix this by declaring the type as unsigned int in all cases.
>
> Also, both input and output priority are unsigned, per the man pages, so
> let's change the type of both priorities throughout, even though clang
> did not warn about the prio_out variable.
>
> Also, add an argument name to test->func(), in order to address another
> warning from clang.
>
> Cc: Ryan Roberts <ryan.roberts@arm.com>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
LGTM
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> tools/testing/selftests/mqueue/mq_perf_tests.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/tools/testing/selftests/mqueue/mq_perf_tests.c b/tools/testing/selftests/mqueue/mq_perf_tests.c
> index 5c16159d0bcd..9380c656581f 100644
> --- a/tools/testing/selftests/mqueue/mq_perf_tests.c
> +++ b/tools/testing/selftests/mqueue/mq_perf_tests.c
> @@ -323,7 +323,8 @@ void *fake_cont_thread(void *arg)
> void *cont_thread(void *arg)
> {
> char buff[MSG_SIZE];
> - int i, priority;
> + int i;
> + unsigned int priority;
>
> for (i = 0; i < num_cpus_to_pin; i++)
> if (cpu_threads[i] == pthread_self())
> @@ -373,27 +374,27 @@ void *cont_thread(void *arg)
>
> struct test {
> char *desc;
> - void (*func)(int *);
> + void (*func)(unsigned int *prio);
> };
>
> -void const_prio(int *prio)
> +void const_prio(unsigned int *prio)
> {
> return;
> }
>
> -void inc_prio(int *prio)
> +void inc_prio(unsigned int *prio)
> {
> if (++*prio == mq_prio_max)
> *prio = 0;
> }
>
> -void dec_prio(int *prio)
> +void dec_prio(unsigned int *prio)
> {
> if (--*prio < 0)
> *prio = mq_prio_max - 1;
> }
>
> -void random_prio(int *prio)
> +void random_prio(unsigned int *prio)
> {
> *prio = random() % mq_prio_max;
> }
> @@ -425,7 +426,7 @@ struct test test2[] = {
> void *perf_test_thread(void *arg)
> {
> char buff[MSG_SIZE];
> - int prio_out, prio_in;
> + unsigned int prio_out, prio_in;
> int i;
> clockid_t clock;
> pthread_t *t;
>
> base-commit: 45db3ab70092637967967bfd8e6144017638563c
> prerequisite-patch-id: b901ece2a5b78503e2fb5480f20e304d36a0ea27
--
BR,
Muhammad Usama Anjum
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] selftests/mqueue: fix 5 warnings about signed/unsigned mismatches
@ 2024-05-27 20:08 John Hubbard
0 siblings, 0 replies; 4+ messages in thread
From: John Hubbard @ 2024-05-27 20:08 UTC (permalink / raw)
To: Shuah Khan
Cc: Andrew Morton, David Hildenbrand, Ryan Roberts, SeongJae Park,
Valentin Obst, linux-kselftest, LKML, llvm, John Hubbard,
Muhammad Usama Anjum
When building with clang, via:
make LLVM=1 -C tools/testing/selftest
...clang warns about several cases of using a signed integer for the
priority argument to mq_receive(3), which expects an unsigned int.
Fix this by declaring the type as unsigned int in all cases.
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Reviewed-by: Ryan Roberts <ryan.roberts@arm.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
Changes since the first version:
1) Rebased onto Linux 6.10-rc1
2) Reviewed-by's added.
thanks,
John Hubbard
tools/testing/selftests/mqueue/mq_perf_tests.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/mqueue/mq_perf_tests.c b/tools/testing/selftests/mqueue/mq_perf_tests.c
index 5c16159d0bcd..fb898850867c 100644
--- a/tools/testing/selftests/mqueue/mq_perf_tests.c
+++ b/tools/testing/selftests/mqueue/mq_perf_tests.c
@@ -323,7 +323,8 @@ void *fake_cont_thread(void *arg)
void *cont_thread(void *arg)
{
char buff[MSG_SIZE];
- int i, priority;
+ int i;
+ unsigned int priority;
for (i = 0; i < num_cpus_to_pin; i++)
if (cpu_threads[i] == pthread_self())
@@ -425,7 +426,8 @@ struct test test2[] = {
void *perf_test_thread(void *arg)
{
char buff[MSG_SIZE];
- int prio_out, prio_in;
+ int prio_out;
+ unsigned int prio_in;
int i;
clockid_t clock;
pthread_t *t;
base-commit: 2bfcfd584ff5ccc8bb7acde19b42570414bf880b
--
2.45.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-27 20:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-08 20:00 [PATCH v2] selftests/mqueue: fix 5 warnings about signed/unsigned mismatches John Hubbard
2024-05-09 12:42 ` Ryan Roberts
2024-05-10 11:41 ` Muhammad Usama Anjum
-- strict thread matches above, loose matches on Subject: below --
2024-05-27 20:08 John Hubbard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox