* Re: [PATCH 1/1] mm: vmscan: Reduce throttling due to a failure to make progress
[not found] <20211202131842.9217-1-mgorman@techsingularity.net>
@ 2021-12-02 16:02 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-12-02 16:02 UTC (permalink / raw)
To: Mel Gorman, Andrew Morton
Cc: llvm, kbuild-all, Linux Memory Management List, Michal Hocko,
Vlastimil Babka, Alexey Avramov, Rik van Riel, Mike Galbraith,
Darrick Wong, regressions, Linux-fsdevel
Hi Mel,
I love your patch! Perhaps something to improve:
[auto build test WARNING on hnaz-mm/master]
url: https://github.com/0day-ci/linux/commits/Mel-Gorman/mm-vmscan-Reduce-throttling-due-to-a-failure-to-make-progress/20211202-212004
base: https://github.com/hnaz/linux-mm master
config: x86_64-buildonly-randconfig-r001-20211202 (https://download.01.org/0day-ci/archive/20211203/202112030001.HUiErCyK-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b553297ef3ee4dc2119d5429adf3072e90fac38)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/01dada07590ae9c69a9415ba9af96d5ae184d861
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mel-Gorman/mm-vmscan-Reduce-throttling-due-to-a-failure-to-make-progress/20211202-212004
git checkout 01dada07590ae9c69a9415ba9af96d5ae184d861
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> mm/vmscan.c:1024:6: warning: no previous prototype for function 'skip_throttle_noprogress' [-Wmissing-prototypes]
bool skip_throttle_noprogress(pg_data_t *pgdat)
^
mm/vmscan.c:1024:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
bool skip_throttle_noprogress(pg_data_t *pgdat)
^
static
1 warning generated.
vim +/skip_throttle_noprogress +1024 mm/vmscan.c
1023
> 1024 bool skip_throttle_noprogress(pg_data_t *pgdat)
1025 {
1026 int reclaimable = 0, write_pending = 0;
1027 int i;
1028
1029 /*
1030 * If kswapd is disabled, reschedule if necessary but do not
1031 * throttle as the system is likely near OOM.
1032 */
1033 if (pgdat->kswapd_failures >= MAX_RECLAIM_RETRIES)
1034 return true;
1035
1036 /*
1037 * If there are a lot of dirty/writeback pages then do not
1038 * throttle as throttling will occur when the pages cycle
1039 * towards the end of the LRU if still under writeback.
1040 */
1041 for (i = 0; i < MAX_NR_ZONES; i++) {
1042 struct zone *zone = pgdat->node_zones + i;
1043
1044 if (!populated_zone(zone))
1045 continue;
1046
1047 reclaimable += zone_reclaimable_pages(zone);
1048 write_pending += zone_page_state_snapshot(zone,
1049 NR_ZONE_WRITE_PENDING);
1050 }
1051 if (2 * write_pending <= reclaimable)
1052 return true;
1053
1054 return false;
1055 }
1056
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] only message in thread