* Re: [PATCH 13/73] sata_dwc_460ex: use generic tracepoints
[not found] <20211208163255.114660-14-hare@suse.de>
@ 2021-12-09 12:28 ` kernel test robot
2021-12-09 19:52 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-12-09 12:28 UTC (permalink / raw)
To: Hannes Reinecke; +Cc: llvm, kbuild-all
Hi Hannes,
I love your patch! Perhaps something to improve:
[auto build test WARNING on rostedt-trace/for-next]
[also build test WARNING on axboe-block/for-next linus/master v5.16-rc4 next-20211208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hannes-Reinecke/libata-rework-logging-take-II/20211209-003634
base: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
config: i386-randconfig-a012-20211209 (https://download.01.org/0day-ci/archive/20211209/202112092036.fKbXi4EI-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 097a1cb1d5ebb3a0ec4bcaed8ba3ff6a8e33c00a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/b3bb5eac4170da8a3e9c477ad4c1c8f97164abc5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hannes-Reinecke/libata-rework-logging-take-II/20211209-003634
git checkout b3bb5eac4170da8a3e9c477ad4c1c8f97164abc5
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/ata/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/ata/sata_dwc_460ex.c:744:5: error: implicit declaration of function 'get_dma_dir_descript' [-Werror,-Wimplicit-function-declaration]
get_dma_dir_descript(qc->dma_dir),
^
>> drivers/ata/sata_dwc_460ex.c:744:5: warning: format specifies type 'char *' but the argument has type 'int' [-Wformat]
get_dma_dir_descript(qc->dma_dir),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:150:67: note: expanded from macro 'dev_info'
dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap'
_p_func(dev, fmt, ##__VA_ARGS__); \
~~~ ^~~~~~~~~~~
1 warning and 1 error generated.
vim +744 drivers/ata/sata_dwc_460ex.c
62936009f35a66 Rupjyoti Sarmah 2010-07-06 724
62936009f35a66 Rupjyoti Sarmah 2010-07-06 725 static void sata_dwc_dma_xfer_complete(struct ata_port *ap, u32 check_status)
62936009f35a66 Rupjyoti Sarmah 2010-07-06 726 {
62936009f35a66 Rupjyoti Sarmah 2010-07-06 727 struct ata_queued_cmd *qc;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 728 struct sata_dwc_device_port *hsdevp = HSDEVP_FROM_AP(ap);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 729 struct sata_dwc_device *hsdev = HSDEV_FROM_AP(ap);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 730 u8 tag = 0;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 731
62936009f35a66 Rupjyoti Sarmah 2010-07-06 732 tag = ap->link.active_tag;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 733 qc = ata_qc_from_tag(ap, tag);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 734 if (!qc) {
62936009f35a66 Rupjyoti Sarmah 2010-07-06 735 dev_err(ap->dev, "failed to get qc");
62936009f35a66 Rupjyoti Sarmah 2010-07-06 736 return;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 737 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 738
62936009f35a66 Rupjyoti Sarmah 2010-07-06 739 #ifdef DEBUG_NCQ
62936009f35a66 Rupjyoti Sarmah 2010-07-06 740 if (tag > 0) {
d578514b271e7c Andy Shevchenko 2015-03-03 741 dev_info(ap->dev,
d578514b271e7c Andy Shevchenko 2015-03-03 742 "%s tag=%u cmd=0x%02x dma dir=%s proto=%s dmacr=0x%08x\n",
4e5b6260cc9ba8 Jens Axboe 2018-05-11 743 __func__, qc->hw_tag, qc->tf.command,
84b47e3b16f8a5 Sergei Shtylyov 2011-01-28 @744 get_dma_dir_descript(qc->dma_dir),
84b47e3b16f8a5 Sergei Shtylyov 2011-01-28 745 get_prot_descript(qc->tf.protocol),
ee81d6cc8e8aa6 Mans Rullgard 2016-04-26 746 sata_dwc_readl(&hsdev->sata_dwc_regs->dmacr));
62936009f35a66 Rupjyoti Sarmah 2010-07-06 747 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 748 #endif
62936009f35a66 Rupjyoti Sarmah 2010-07-06 749
62936009f35a66 Rupjyoti Sarmah 2010-07-06 750 if (ata_is_dma(qc->tf.protocol)) {
62936009f35a66 Rupjyoti Sarmah 2010-07-06 751 if (hsdevp->dma_pending[tag] == SATA_DWC_DMA_PENDING_NONE) {
d578514b271e7c Andy Shevchenko 2015-03-03 752 dev_err(ap->dev,
d578514b271e7c Andy Shevchenko 2015-03-03 753 "%s DMA protocol RX and TX DMA not pending dmacr: 0x%08x\n",
d578514b271e7c Andy Shevchenko 2015-03-03 754 __func__,
ee81d6cc8e8aa6 Mans Rullgard 2016-04-26 755 sata_dwc_readl(&hsdev->sata_dwc_regs->dmacr));
62936009f35a66 Rupjyoti Sarmah 2010-07-06 756 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 757
62936009f35a66 Rupjyoti Sarmah 2010-07-06 758 hsdevp->dma_pending[tag] = SATA_DWC_DMA_PENDING_NONE;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 759 sata_dwc_qc_complete(ap, qc, check_status);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 760 ap->link.active_tag = ATA_TAG_POISON;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 761 } else {
62936009f35a66 Rupjyoti Sarmah 2010-07-06 762 sata_dwc_qc_complete(ap, qc, check_status);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 763 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 764 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 765
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 13/73] sata_dwc_460ex: use generic tracepoints
[not found] <20211208163255.114660-14-hare@suse.de>
2021-12-09 12:28 ` [PATCH 13/73] sata_dwc_460ex: use generic tracepoints kernel test robot
@ 2021-12-09 19:52 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-12-09 19:52 UTC (permalink / raw)
To: Hannes Reinecke; +Cc: llvm, kbuild-all
Hi Hannes,
I love your patch! Yet something to improve:
[auto build test ERROR on rostedt-trace/for-next]
[also build test ERROR on axboe-block/for-next linus/master v5.16-rc4 next-20211208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hannes-Reinecke/libata-rework-logging-take-II/20211209-003634
base: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
config: i386-randconfig-a012-20211209 (https://download.01.org/0day-ci/archive/20211210/202112100319.zR4w9NfW-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 097a1cb1d5ebb3a0ec4bcaed8ba3ff6a8e33c00a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/b3bb5eac4170da8a3e9c477ad4c1c8f97164abc5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hannes-Reinecke/libata-rework-logging-take-II/20211209-003634
git checkout b3bb5eac4170da8a3e9c477ad4c1c8f97164abc5
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/ata/sata_dwc_460ex.c:744:5: error: implicit declaration of function 'get_dma_dir_descript' [-Werror,-Wimplicit-function-declaration]
get_dma_dir_descript(qc->dma_dir),
^
drivers/ata/sata_dwc_460ex.c:744:5: warning: format specifies type 'char *' but the argument has type 'int' [-Wformat]
get_dma_dir_descript(qc->dma_dir),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:150:67: note: expanded from macro 'dev_info'
dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap'
_p_func(dev, fmt, ##__VA_ARGS__); \
~~~ ^~~~~~~~~~~
1 warning and 1 error generated.
vim +/get_dma_dir_descript +744 drivers/ata/sata_dwc_460ex.c
62936009f35a665 Rupjyoti Sarmah 2010-07-06 724
62936009f35a665 Rupjyoti Sarmah 2010-07-06 725 static void sata_dwc_dma_xfer_complete(struct ata_port *ap, u32 check_status)
62936009f35a665 Rupjyoti Sarmah 2010-07-06 726 {
62936009f35a665 Rupjyoti Sarmah 2010-07-06 727 struct ata_queued_cmd *qc;
62936009f35a665 Rupjyoti Sarmah 2010-07-06 728 struct sata_dwc_device_port *hsdevp = HSDEVP_FROM_AP(ap);
62936009f35a665 Rupjyoti Sarmah 2010-07-06 729 struct sata_dwc_device *hsdev = HSDEV_FROM_AP(ap);
62936009f35a665 Rupjyoti Sarmah 2010-07-06 730 u8 tag = 0;
62936009f35a665 Rupjyoti Sarmah 2010-07-06 731
62936009f35a665 Rupjyoti Sarmah 2010-07-06 732 tag = ap->link.active_tag;
62936009f35a665 Rupjyoti Sarmah 2010-07-06 733 qc = ata_qc_from_tag(ap, tag);
62936009f35a665 Rupjyoti Sarmah 2010-07-06 734 if (!qc) {
62936009f35a665 Rupjyoti Sarmah 2010-07-06 735 dev_err(ap->dev, "failed to get qc");
62936009f35a665 Rupjyoti Sarmah 2010-07-06 736 return;
62936009f35a665 Rupjyoti Sarmah 2010-07-06 737 }
62936009f35a665 Rupjyoti Sarmah 2010-07-06 738
62936009f35a665 Rupjyoti Sarmah 2010-07-06 739 #ifdef DEBUG_NCQ
62936009f35a665 Rupjyoti Sarmah 2010-07-06 740 if (tag > 0) {
d578514b271e7c8 Andy Shevchenko 2015-03-03 741 dev_info(ap->dev,
d578514b271e7c8 Andy Shevchenko 2015-03-03 742 "%s tag=%u cmd=0x%02x dma dir=%s proto=%s dmacr=0x%08x\n",
4e5b6260cc9ba84 Jens Axboe 2018-05-11 743 __func__, qc->hw_tag, qc->tf.command,
84b47e3b16f8a5b Sergei Shtylyov 2011-01-28 @744 get_dma_dir_descript(qc->dma_dir),
84b47e3b16f8a5b Sergei Shtylyov 2011-01-28 745 get_prot_descript(qc->tf.protocol),
ee81d6cc8e8aa66 Mans Rullgard 2016-04-26 746 sata_dwc_readl(&hsdev->sata_dwc_regs->dmacr));
62936009f35a665 Rupjyoti Sarmah 2010-07-06 747 }
62936009f35a665 Rupjyoti Sarmah 2010-07-06 748 #endif
62936009f35a665 Rupjyoti Sarmah 2010-07-06 749
62936009f35a665 Rupjyoti Sarmah 2010-07-06 750 if (ata_is_dma(qc->tf.protocol)) {
62936009f35a665 Rupjyoti Sarmah 2010-07-06 751 if (hsdevp->dma_pending[tag] == SATA_DWC_DMA_PENDING_NONE) {
d578514b271e7c8 Andy Shevchenko 2015-03-03 752 dev_err(ap->dev,
d578514b271e7c8 Andy Shevchenko 2015-03-03 753 "%s DMA protocol RX and TX DMA not pending dmacr: 0x%08x\n",
d578514b271e7c8 Andy Shevchenko 2015-03-03 754 __func__,
ee81d6cc8e8aa66 Mans Rullgard 2016-04-26 755 sata_dwc_readl(&hsdev->sata_dwc_regs->dmacr));
62936009f35a665 Rupjyoti Sarmah 2010-07-06 756 }
62936009f35a665 Rupjyoti Sarmah 2010-07-06 757
62936009f35a665 Rupjyoti Sarmah 2010-07-06 758 hsdevp->dma_pending[tag] = SATA_DWC_DMA_PENDING_NONE;
62936009f35a665 Rupjyoti Sarmah 2010-07-06 759 sata_dwc_qc_complete(ap, qc, check_status);
62936009f35a665 Rupjyoti Sarmah 2010-07-06 760 ap->link.active_tag = ATA_TAG_POISON;
62936009f35a665 Rupjyoti Sarmah 2010-07-06 761 } else {
62936009f35a665 Rupjyoti Sarmah 2010-07-06 762 sata_dwc_qc_complete(ap, qc, check_status);
62936009f35a665 Rupjyoti Sarmah 2010-07-06 763 }
62936009f35a665 Rupjyoti Sarmah 2010-07-06 764 }
62936009f35a665 Rupjyoti Sarmah 2010-07-06 765
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-09 19:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211208163255.114660-14-hare@suse.de>
2021-12-09 12:28 ` [PATCH 13/73] sata_dwc_460ex: use generic tracepoints kernel test robot
2021-12-09 19:52 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox