* Re: [PATCH v6 2/2] Input: add Imagis touchscreen driver
[not found] <20220222203414.8656-3-markuss.broks@gmail.com>
@ 2022-02-23 4:59 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-02-23 4:59 UTC (permalink / raw)
To: Markuss Broks, linux-kernel
Cc: llvm, kbuild-all, phone-devel, ~postmarketos/upstreaming,
Markuss Broks, Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski,
Henrik Rydberg, linux-input, devicetree
Hi Markuss,
I love your patch! Perhaps something to improve:
[auto build test WARNING on dtor-input/next]
[also build test WARNING on linux/master robh/for-next linus/master v5.17-rc5 next-20220222]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Markuss-Broks/Add-support-for-Imagis-touchscreens/20220223-043645
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20220223/202202231213.Vj9yo4tW-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/bc77ee5e0d7309edca7d65925c6afa05334b0b01
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Markuss-Broks/Add-support-for-Imagis-touchscreens/20220223-043645
git checkout bc77ee5e0d7309edca7d65925c6afa05334b0b01
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/input/touchscreen/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/input/touchscreen/imagis.c:300:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (input_device_enabled(ts->input_dev))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/input/touchscreen/imagis.c:305:9: note: uninitialized use occurs here
return ret;
^~~
drivers/input/touchscreen/imagis.c:300:2: note: remove the 'if' if its condition is always true
if (input_device_enabled(ts->input_dev))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/input/touchscreen/imagis.c:296:9: note: initialize the variable 'ret' to silence this warning
int ret;
^
= 0
drivers/input/touchscreen/imagis.c:316:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (input_device_enabled(ts->input_dev))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/input/touchscreen/imagis.c:321:9: note: uninitialized use occurs here
return ret;
^~~
drivers/input/touchscreen/imagis.c:316:2: note: remove the 'if' if its condition is always true
if (input_device_enabled(ts->input_dev))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/input/touchscreen/imagis.c:312:9: note: initialize the variable 'ret' to silence this warning
int ret;
^
= 0
2 warnings generated.
vim +300 drivers/input/touchscreen/imagis.c
291
292 static int __maybe_unused imagis_suspend(struct device *dev)
293 {
294 struct i2c_client *client = to_i2c_client(dev);
295 struct imagis_ts *ts = i2c_get_clientdata(client);
296 int ret;
297
298 mutex_lock(&ts->input_dev->mutex);
299
> 300 if (input_device_enabled(ts->input_dev))
301 ret = imagis_stop(ts);
302
303 mutex_unlock(&ts->input_dev->mutex);
304
305 return ret;
306 }
307
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] only message in thread