* Re: [PATCH v2 8/9] eventfs: moving tracing/events to eventfs [not found] <1683026600-13485-9-git-send-email-akaher@vmware.com> @ 2023-05-02 18:07 ` kernel test robot 2023-05-09 12:29 ` Ajay Kaher 0 siblings, 1 reply; 6+ messages in thread From: kernel test robot @ 2023-05-02 18:07 UTC (permalink / raw) To: Ajay Kaher, rostedt, mhiramat, shuah Cc: llvm, oe-kbuild-all, linux-kernel, linux-trace-kernel, linux-kselftest, chinglinyu, namit, srivatsab, srivatsa, amakhalov, vsirnapalli, tkundu, er.ajay.kaher, Ajay Kaher Hi Ajay, kernel test robot noticed the following build warnings: [auto build test WARNING on shuah-kselftest/next] [also build test WARNING on shuah-kselftest/fixes linus/master v6.3 next-20230428] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Ajay-Kaher/eventfs-introducing-struct-tracefs_inode/20230502-192949 base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next patch link: https://lore.kernel.org/r/1683026600-13485-9-git-send-email-akaher%40vmware.com patch subject: [PATCH v2 8/9] eventfs: moving tracing/events to eventfs config: i386-randconfig-a011-20230501 (https://download.01.org/0day-ci/archive/20230503/202305030116.Gu6yyvKj-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/2fe2002efb23a715f5eb7a58891ff85f4e37b084 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Ajay-Kaher/eventfs-introducing-struct-tracefs_inode/20230502-192949 git checkout 2fe2002efb23a715f5eb7a58891ff85f4e37b084 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash kernel/trace/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202305030116.Gu6yyvKj-lkp@intel.com/ All warnings (new ones prefixed by >>): >> kernel/trace/trace_events.c:2424:17: warning: variable 'd_events' set but not used [-Wunused-but-set-variable] struct dentry *d_events; ^ 1 warning generated. vim +/d_events +2424 kernel/trace/trace_events.c ac343da7bc9048 Masami Hiramatsu 2020-09-10 2417 1473e4417c79f1 Steven Rostedt 2009-02-24 2418 static int 7f1d2f8210195c Steven Rostedt (Red Hat 2015-05-05 2419) event_create_dir(struct dentry *parent, struct trace_event_file *file) 1473e4417c79f1 Steven Rostedt 2009-02-24 2420 { 2425bcb9240f8c Steven Rostedt (Red Hat 2015-05-05 2421) struct trace_event_call *call = file->event_call; ae63b31e4d0e2e Steven Rostedt 2012-05-03 2422 struct trace_array *tr = file->tr; 2fe2002efb23a7 Ajay Kaher 2023-05-02 2423 struct eventfs_file *ef_subsystem = NULL; ae63b31e4d0e2e Steven Rostedt 2012-05-03 @2424 struct dentry *d_events; de7b2973903c6c Mathieu Desnoyers 2014-04-08 2425 const char *name; fd99498989f3b3 Steven Rostedt 2009-02-28 2426 int ret; 1473e4417c79f1 Steven Rostedt 2009-02-24 2427 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2428 /* 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2429 * If the trace point header did not define TRACE_SYSTEM 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2430 * then the system would be called "TRACE_SYSTEM". 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2431 */ ae63b31e4d0e2e Steven Rostedt 2012-05-03 2432 if (strcmp(call->class->system, TRACE_SYSTEM) != 0) { 2fe2002efb23a7 Ajay Kaher 2023-05-02 2433 ef_subsystem = event_subsystem_dir(tr, call->class->system, file, parent); 2fe2002efb23a7 Ajay Kaher 2023-05-02 2434 if (!ef_subsystem) ae63b31e4d0e2e Steven Rostedt 2012-05-03 2435 return -ENOMEM; ae63b31e4d0e2e Steven Rostedt 2012-05-03 2436 } else ae63b31e4d0e2e Steven Rostedt 2012-05-03 2437 d_events = parent; 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2438 687fcc4aee4567 Steven Rostedt (Red Hat 2015-05-13 2439) name = trace_event_name(call); 2fe2002efb23a7 Ajay Kaher 2023-05-02 2440 file->ef = eventfs_add_dir(name, ef_subsystem, &tr->eventfs_rwsem); 2fe2002efb23a7 Ajay Kaher 2023-05-02 2441 if (IS_ERR(file->ef)) { 8434dc9340cd2e Steven Rostedt (Red Hat 2015-01-20 2442) pr_warn("Could not create tracefs '%s' directory\n", name); 1473e4417c79f1 Steven Rostedt 2009-02-24 2443 return -1; 1473e4417c79f1 Steven Rostedt 2009-02-24 2444 } 1473e4417c79f1 Steven Rostedt 2009-02-24 2445 9b63776fa3ca96 Steven Rostedt 2012-05-10 2446 if (call->class->reg && !(call->flags & TRACE_EVENT_FL_IGNORE_ENABLE)) 2fe2002efb23a7 Ajay Kaher 2023-05-02 2447 eventfs_add_file("enable", TRACE_MODE_WRITE, file->ef, file, 620a30e97febc8 Oleg Nesterov 2013-07-31 2448 &ftrace_enable_fops); 1473e4417c79f1 Steven Rostedt 2009-02-24 2449 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 8/9] eventfs: moving tracing/events to eventfs 2023-05-02 18:07 ` [PATCH v2 8/9] eventfs: moving tracing/events to eventfs kernel test robot @ 2023-05-09 12:29 ` Ajay Kaher 2023-05-09 16:45 ` Steven Rostedt 0 siblings, 1 reply; 6+ messages in thread From: Ajay Kaher @ 2023-05-09 12:29 UTC (permalink / raw) To: kernel test robot, rostedt@goodmis.org, mhiramat@kernel.org, shuah@kernel.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, chinglinyu@google.com, Nadav Amit, Srivatsa Bhat, srivatsa@csail.mit.edu, Alexey Makhalov, Vasavi Sirnapalli, Tapas Kundu, er.ajay.kaher@gmail.com > On 02/05/23, 11:42 PM, "kernel test robot" <lkp@intel.com> wrote: > >> kernel/trace/trace_events.c:2424:17: warning: variable 'd_events' set but not used [-Wunused-but-set-variable] > struct dentry *d_events; > ^ > 1 warning generated. > Steve, with-in event_create_dir(), do we have any scenario when file->event_call->class->system doesn't have TRACE_SYSTEM? And need to execute following: ae63b31e4d0e2e Steven Rostedt 2012-05-03 2437 d_events = parent; looking for your input if we could remove d_events from event_create_dir(). - Ajay > vim +/d_events +2424 kernel/trace/trace_events.c > > ac343da7bc9048 Masami Hiramatsu 2020-09-10 2417 > 1473e4417c79f1 Steven Rostedt 2009-02-24 2418 static int > 7f1d2f8210195c Steven Rostedt (Red Hat 2015-05-05 2419) event_create_dir(struct dentry *parent, struct trace_event_file *file) > 1473e4417c79f1 Steven Rostedt 2009-02-24 2420 { > 2425bcb9240f8c Steven Rostedt (Red Hat 2015-05-05 2421) struct trace_event_call *call = file->event_call; > ae63b31e4d0e2e Steven Rostedt 2012-05-03 2422 struct trace_array *tr = file->tr; > 2fe2002efb23a7 Ajay Kaher 2023-05-02 2423 struct eventfs_file *ef_subsystem = NULL; > ae63b31e4d0e2e Steven Rostedt 2012-05-03 @2424 struct dentry *d_events; > de7b2973903c6c Mathieu Desnoyers 2014-04-08 2425 const char *name; > fd99498989f3b3 Steven Rostedt 2009-02-28 2426 int ret; > 1473e4417c79f1 Steven Rostedt 2009-02-24 2427 > 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2428 /* > 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2429 * If the trace point header did not define TRACE_SYSTEM > 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2430 * then the system would be called "TRACE_SYSTEM". > 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2431 */ > ae63b31e4d0e2e Steven Rostedt 2012-05-03 2432 if (strcmp(call->class->system, TRACE_SYSTEM) != 0) { > 2fe2002efb23a7 Ajay Kaher 2023-05-02 2433 ef_subsystem = event_subsystem_dir(tr, call->class->system, file, parent); > 2fe2002efb23a7 Ajay Kaher 2023-05-02 2434 if (!ef_subsystem) > ae63b31e4d0e2e Steven Rostedt 2012-05-03 2435 return -ENOMEM; > ae63b31e4d0e2e Steven Rostedt 2012-05-03 2436 } else > ae63b31e4d0e2e Steven Rostedt 2012-05-03 2437 d_events = parent; > 6ecc2d1ca39177 Steven Rostedt 2009-02-27 2438 > 687fcc4aee4567 Steven Rostedt (Red Hat 2015-05-13 2439) name = trace_event_name(call); > 2fe2002efb23a7 Ajay Kaher 2023-05-02 2440 file->ef = eventfs_add_dir(name, ef_subsystem, &tr->eventfs_rwsem); > 2fe2002efb23a7 Ajay Kaher 2023-05-02 2441 if (IS_ERR(file->ef)) { > 8434dc9340cd2e Steven Rostedt (Red Hat 2015-01-20 2442) pr_warn("Could not create tracefs '%s' directory\n", name); > 1473e4417c79f1 Steven Rostedt 2009-02-24 2443 return -1; > 1473e4417c79f1 Steven Rostedt 2009-02-24 2444 } > 1473e4417c79f1 Steven Rostedt 2009-02-24 2445 > 9b63776fa3ca96 Steven Rostedt 2012-05-10 2446 if (call->class->reg && !(call->flags & TRACE_EVENT_FL_IGNORE_ENABLE)) > 2fe2002efb23a7 Ajay Kaher 2023-05-02 2447 eventfs_add_file("enable", TRACE_MODE_WRITE, file->ef, file, > 620a30e97febc8 Oleg Nesterov 2013-07-31 2448 &ftrace_enable_fops); > 1473e4417c79f1 Steven Rostedt 2009-02-24 2449 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 8/9] eventfs: moving tracing/events to eventfs 2023-05-09 12:29 ` Ajay Kaher @ 2023-05-09 16:45 ` Steven Rostedt 2023-05-10 11:11 ` Ajay Kaher 0 siblings, 1 reply; 6+ messages in thread From: Steven Rostedt @ 2023-05-09 16:45 UTC (permalink / raw) To: Ajay Kaher Cc: kernel test robot, mhiramat@kernel.org, shuah@kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, chinglinyu@google.com, Nadav Amit, Srivatsa Bhat, srivatsa@csail.mit.edu, Alexey Makhalov, Vasavi Sirnapalli, Tapas Kundu, er.ajay.kaher@gmail.com On Tue, 9 May 2023 12:29:23 +0000 Ajay Kaher <akaher@vmware.com> wrote: > > On 02/05/23, 11:42 PM, "kernel test robot" <lkp@intel.com> wrote: > > >> kernel/trace/trace_events.c:2424:17: warning: variable 'd_events' set but not used [-Wunused-but-set-variable] > > struct dentry *d_events; > > ^ > > 1 warning generated. > > > > Steve, with-in event_create_dir(), do we have any scenario when file->event_call->class->system > doesn't have TRACE_SYSTEM? And need to execute following: > > ae63b31e4d0e2e Steven Rostedt 2012-05-03 2437 d_events = parent; > > looking for your input if we could remove d_events from event_create_dir(). > I have hit this in the beginning, but I don't think it's an issue anymore. Perhaps just have it be: if (WARN_ON_ONCE(strcmp(call->class->system, TRACE_SYSTEM) == 0)) return -ENODEV; ef_subsystem = event_subsystem_dir(tr, call->class->system, file, parent); Hmm, how about just add this patch before your patch set: -- Steve From: "Steven Rostedt (Google)" <rostedt@goodmis.org> Subject: [PATCH] tracing: Require all trace events to have a TRACE_SYSTEM The creation of the trace event directory requires that a TRACE_SYSTEM is defined that the trace event directory is added within the system it was defined in. The code handled the case where a TRACE_SYSTEM was not added, and would then add the event at the events directory. But nothing should be doing this. This code also prevents the implementation of creating dynamic dentrys for the eventfs system. As this path has never been hit on correct code, remove it. If it does get hit, issues a WARN_ON_ONCE() and return ENODEV. Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> --- (lightly tested) kernel/trace/trace_events.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 654ffa40457a..16bc5ba45507 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -2424,14 +2424,15 @@ event_create_dir(struct dentry *parent, struct trace_event_file *file) /* * If the trace point header did not define TRACE_SYSTEM - * then the system would be called "TRACE_SYSTEM". + * then the system would be called "TRACE_SYSTEM". This should + * never happen. */ - if (strcmp(call->class->system, TRACE_SYSTEM) != 0) { - d_events = event_subsystem_dir(tr, call->class->system, file, parent); - if (!d_events) - return -ENOMEM; - } else - d_events = parent; + if (WARN_ON_ONCE(strcmp(call->class->system, TRACE_SYSTEM) == 0)) + return -ENODEV; + + d_events = event_subsystem_dir(tr, call->class->system, file, parent); + if (!d_events) + return -ENOMEM; name = trace_event_name(call); file->dir = tracefs_create_dir(name, d_events); -- 2.39.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 8/9] eventfs: moving tracing/events to eventfs 2023-05-09 16:45 ` Steven Rostedt @ 2023-05-10 11:11 ` Ajay Kaher 2023-05-12 22:59 ` Steven Rostedt 0 siblings, 1 reply; 6+ messages in thread From: Ajay Kaher @ 2023-05-10 11:11 UTC (permalink / raw) To: Steven Rostedt Cc: kernel test robot, mhiramat@kernel.org, shuah@kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, chinglinyu@google.com, Nadav Amit, Srivatsa Bhat, srivatsa@csail.mit.edu, Alexey Makhalov, Vasavi Sirnapalli, Tapas Kundu, er.ajay.kaher@gmail.com > On 09-May-2023, at 10:15 PM, Steven Rostedt <rostedt@goodmis.org> wrote: > > !! External Email > > On Tue, 9 May 2023 12:29:23 +0000 > Ajay Kaher <akaher@vmware.com> wrote: > >> > On 02/05/23, 11:42 PM, "kernel test robot" <lkp@intel.com> wrote: >>>>> kernel/trace/trace_events.c:2424:17: warning: variable 'd_events' set but not used [-Wunused-but-set-variable] >>> struct dentry *d_events; >>> ^ >>> 1 warning generated. >>> >> >> Steve, with-in event_create_dir(), do we have any scenario when file->event_call->class->system >> doesn't have TRACE_SYSTEM? And need to execute following: >> >> ae63b31e4d0e2e Steven Rostedt 2012-05-03 2437 d_events = parent; >> >> looking for your input if we could remove d_events from event_create_dir(). >> > > I have hit this in the beginning, but I don't think it's an issue > anymore. Perhaps just have it be: > > if (WARN_ON_ONCE(strcmp(call->class->system, TRACE_SYSTEM) == 0)) > return -ENODEV; > > ef_subsystem = event_subsystem_dir(tr, call->class->system, file, parent); > > Hmm, how about just add this patch before your patch set: > Sounds good. Thanks Steve :) Once you will merge below patch, I will rebase this patch in v3. - Ajay > > From: "Steven Rostedt (Google)" <rostedt@goodmis.org> > Subject: [PATCH] tracing: Require all trace events to have a TRACE_SYSTEM > > The creation of the trace event directory requires that a TRACE_SYSTEM is > defined that the trace event directory is added within the system it was > defined in. > > The code handled the case where a TRACE_SYSTEM was not added, and would > then add the event at the events directory. But nothing should be doing > this. This code also prevents the implementation of creating dynamic > dentrys for the eventfs system. > > As this path has never been hit on correct code, remove it. If it does get > hit, issues a WARN_ON_ONCE() and return ENODEV. > > Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> > --- > > (lightly tested) > > kernel/trace/trace_events.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c > index 654ffa40457a..16bc5ba45507 100644 > --- a/kernel/trace/trace_events.c > +++ b/kernel/trace/trace_events.c > @@ -2424,14 +2424,15 @@ event_create_dir(struct dentry *parent, struct trace_event_file *file) > > /* > * If the trace point header did not define TRACE_SYSTEM > - * then the system would be called "TRACE_SYSTEM". > + * then the system would be called "TRACE_SYSTEM". This should > + * never happen. > */ > - if (strcmp(call->class->system, TRACE_SYSTEM) != 0) { > - d_events = event_subsystem_dir(tr, call->class->system, file, parent); > - if (!d_events) > - return -ENOMEM; > - } else > - d_events = parent; > + if (WARN_ON_ONCE(strcmp(call->class->system, TRACE_SYSTEM) == 0)) > + return -ENODEV; > + > + d_events = event_subsystem_dir(tr, call->class->system, file, parent); > + if (!d_events) > + return -ENOMEM; > > name = trace_event_name(call); > file->dir = tracefs_create_dir(name, d_events); > -- > 2.39.2 > > > !! External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 8/9] eventfs: moving tracing/events to eventfs 2023-05-10 11:11 ` Ajay Kaher @ 2023-05-12 22:59 ` Steven Rostedt 2023-05-15 11:35 ` Ajay Kaher 0 siblings, 1 reply; 6+ messages in thread From: Steven Rostedt @ 2023-05-12 22:59 UTC (permalink / raw) To: Ajay Kaher Cc: kernel test robot, mhiramat@kernel.org, shuah@kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, chinglinyu@google.com, Nadav Amit, Srivatsa Bhat, srivatsa@csail.mit.edu, Alexey Makhalov, Vasavi Sirnapalli, Tapas Kundu, er.ajay.kaher@gmail.com On Wed, 10 May 2023 11:11:15 +0000 Ajay Kaher <akaher@vmware.com> wrote: > Sounds good. Thanks Steve :) > Once you will merge below patch, I will rebase this patch in v3. Feel free to just add it at the start of your queue. You just need to keep the "From" line and it will be added as my patch. -- Steve ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 8/9] eventfs: moving tracing/events to eventfs 2023-05-12 22:59 ` Steven Rostedt @ 2023-05-15 11:35 ` Ajay Kaher 0 siblings, 0 replies; 6+ messages in thread From: Ajay Kaher @ 2023-05-15 11:35 UTC (permalink / raw) To: Steven Rostedt Cc: kernel test robot, mhiramat@kernel.org, shuah@kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, chinglinyu@google.com, Nadav Amit, srivatsa@csail.mit.edu, Alexey Makhalov, Vasavi Sirnapalli, Tapas Kundu, er.ajay.kaher@gmail.com > On 13-May-2023, at 4:29 AM, Steven Rostedt <rostedt@goodmis.org> wrote: > > !! External Email > > On Wed, 10 May 2023 11:11:15 +0000 > Ajay Kaher <akaher@vmware.com> wrote: > >> Sounds good. Thanks Steve :) >> Once you will merge below patch, I will rebase this patch in v3. > > Feel free to just add it at the start of your queue. You just need to > keep the "From" line and it will be added as my patch. Ok, I will include in v3. -Ajay ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-15 11:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1683026600-13485-9-git-send-email-akaher@vmware.com>
2023-05-02 18:07 ` [PATCH v2 8/9] eventfs: moving tracing/events to eventfs kernel test robot
2023-05-09 12:29 ` Ajay Kaher
2023-05-09 16:45 ` Steven Rostedt
2023-05-10 11:11 ` Ajay Kaher
2023-05-12 22:59 ` Steven Rostedt
2023-05-15 11:35 ` Ajay Kaher
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox