* Re: [PATCH 12/18] mtd: nand: omap: Use devm_platform_get_and_ioremap_resource() [not found] ` <20230713075751.486075-1-miquel.raynal@bootlin.com> @ 2023-07-14 15:27 ` Nathan Chancellor 2023-07-15 16:06 ` Miquel Raynal 0 siblings, 1 reply; 2+ messages in thread From: Nathan Chancellor @ 2023-07-14 15:27 UTC (permalink / raw) To: Miquel Raynal Cc: Yangtao Li, Kyungmin Park, Richard Weinberger, Vignesh Raghavendra, linux-mtd, linux-kernel, llvm On Thu, Jul 13, 2023 at 09:57:51AM +0200, Miquel Raynal wrote: > On Fri, 2023-07-07 at 04:06:16 UTC, Yangtao Li wrote: > > Convert platform_get_resource(), devm_ioremap_resource() to a single > > call to devm_platform_get_and_ioremap_resource(), as this is exactly > > what this function does. > > > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Please apply the updated version at [1], the current version is obviously not correct, as clang points out in next-20230714: drivers/mtd/nand/onenand/onenand_omap2.c:470:2: warning: variable 'c' is uninitialized when used here [-Wuninitialized] 470 | c->onenand.base = devm_platform_get_and_ioremap_resource(pdev, 0, &res); | ^ drivers/mtd/nand/onenand/onenand_omap2.c:465:25: note: initialize the variable 'c' to silence this warning 465 | struct omap2_onenand *c; | ^ | = NULL 1 warning generated. KernelCI also reported this at [2]. I apologize if this has already been reported or fixed locally, I did not see your branch updated. [1]: https://lore.kernel.org/20230713104422.29222-1-frank.li@vivo.com/ [2]: https://lore.kernel.org/64b137dc.170a0220.b8a13.feee@mx.google.com/ Cheers, Nathan ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 12/18] mtd: nand: omap: Use devm_platform_get_and_ioremap_resource() 2023-07-14 15:27 ` [PATCH 12/18] mtd: nand: omap: Use devm_platform_get_and_ioremap_resource() Nathan Chancellor @ 2023-07-15 16:06 ` Miquel Raynal 0 siblings, 0 replies; 2+ messages in thread From: Miquel Raynal @ 2023-07-15 16:06 UTC (permalink / raw) To: Nathan Chancellor Cc: Yangtao Li, Kyungmin Park, Richard Weinberger, Vignesh Raghavendra, linux-mtd, linux-kernel, llvm Hi Nathan, nathan@kernel.org wrote on Fri, 14 Jul 2023 08:27:01 -0700: > On Thu, Jul 13, 2023 at 09:57:51AM +0200, Miquel Raynal wrote: > > On Fri, 2023-07-07 at 04:06:16 UTC, Yangtao Li wrote: > > > Convert platform_get_resource(), devm_ioremap_resource() to a single > > > call to devm_platform_get_and_ioremap_resource(), as this is exactly > > > what this function does. > > > > > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > > > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. > > Please apply the updated version at [1], the current version is > obviously not correct, as clang points out in next-20230714: I will replace the first version by the corrected one. > > drivers/mtd/nand/onenand/onenand_omap2.c:470:2: warning: variable 'c' is uninitialized when used here [-Wuninitialized] > 470 | c->onenand.base = devm_platform_get_and_ioremap_resource(pdev, 0, &res); > | ^ > drivers/mtd/nand/onenand/onenand_omap2.c:465:25: note: initialize the variable 'c' to silence this warning > 465 | struct omap2_onenand *c; > | ^ > | = NULL > 1 warning generated. > > KernelCI also reported this at [2]. I apologize if this has already been > reported or fixed locally, I did not see your branch updated. > > [1]: https://lore.kernel.org/20230713104422.29222-1-frank.li@vivo.com/ > [2]: https://lore.kernel.org/64b137dc.170a0220.b8a13.feee@mx.google.com/ > > Cheers, > Nathan Thanks, Miquèl ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-15 16:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230707040622.78174-12-frank.li@vivo.com>
[not found] ` <20230713075751.486075-1-miquel.raynal@bootlin.com>
2023-07-14 15:27 ` [PATCH 12/18] mtd: nand: omap: Use devm_platform_get_and_ioremap_resource() Nathan Chancellor
2023-07-15 16:06 ` Miquel Raynal
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox