Re: [PATCH v4 07/28] block: Introduce zone write plugging

Re: [PATCH v4 07/28] block: Introduce zone write plugging

[kernel test robot]

Hi Damien,

kernel test robot noticed the following build warnings:

[auto build test WARNING on axboe-block/for-next]
[also build test WARNING on linus/master v6.9-rc2 next-20240402]
[cannot apply to jejb-scsi/for-next device-mapper-dm/for-next mkp-scsi/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Damien-Le-Moal/block-Restore-sector-of-flush-requests/20240402-204657
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link:    https://lore.kernel.org/r/20240402123907.512027-8-dlemoal%40kernel.org
patch subject: [PATCH v4 07/28] block: Introduce zone write plugging
config: i386-buildonly-randconfig-003-20240403 (https://download.01.org/0day-ci/archive/20240403/202404031242.Oy7q9BWh-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240403/202404031242.Oy7q9BWh-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404031242.Oy7q9BWh-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> block/blk-zoned.c:1435:10: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
    1435 |                 return ret;
         |                        ^~~
   block/blk-zoned.c:1415:9: note: initialize the variable 'ret' to silence this warning
    1415 |         int ret;
         |                ^
         |                 = 0
   1 warning generated.


vim +/ret +1435 block/blk-zoned.c

  1410	
  1411	static int disk_alloc_zone_resources(struct gendisk *disk,
  1412					     unsigned int pool_size)
  1413	{
  1414		unsigned int i;
  1415		int ret;
  1416	
  1417		disk->zone_wplugs_hash_bits =
  1418			min(ilog2(pool_size) + 1, BLK_ZONE_WPLUG_MAX_HASH_BITS);
  1419	
  1420		disk->zone_wplugs_hash =
  1421			kcalloc(disk_zone_wplugs_hash_size(disk),
  1422				sizeof(struct hlist_head), GFP_KERNEL);
  1423		if (!disk->zone_wplugs_hash)
  1424			return -ENOMEM;
  1425	
  1426		for (i = 0; i < disk_zone_wplugs_hash_size(disk); i++)
  1427			INIT_HLIST_HEAD(&disk->zone_wplugs_hash[i]);
  1428	
  1429		disk->zone_wplugs_pool = mempool_create_kmalloc_pool(pool_size,
  1430							sizeof(struct blk_zone_wplug));
  1431		if (!disk->zone_wplugs_pool) {
  1432			kfree(disk->zone_wplugs_hash);
  1433			disk->zone_wplugs_hash = NULL;
  1434			disk->zone_wplugs_hash_bits = 0;
> 1435			return ret;
  1436		}
  1437	
  1438		return 0;
  1439	}
  1440	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki