* Re: [PATCH v6 4/5] power: supply: power-supply-leds: Add charging_orange_full_green trigger for RGB LED
[not found] <20240416053909.256319-5-hpa@redhat.com>
@ 2024-04-16 23:27 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-04-16 23:27 UTC (permalink / raw)
To: Kate Hsuan, Pavel Machek, Lee Jones, linux-leds,
platform-driver-x86, Hans de Goede, Ilpo Järvinen,
André Apitzsch, linux-kernel, Andy Shevchenko,
Sebastian Reichel, linux-pm
Cc: llvm, oe-kbuild-all, Kate Hsuan
Hi Kate,
kernel test robot noticed the following build errors:
[auto build test ERROR on sre-power-supply/for-next]
[also build test ERROR on lee-leds/for-leds-next linus/master v6.9-rc4]
[cannot apply to next-20240416]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kate-Hsuan/platform-x86-android-tablets-other-Add-swnode-for-Xiaomi-pad2-indicator-LED/20240416-134240
base: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
patch link: https://lore.kernel.org/r/20240416053909.256319-5-hpa%40redhat.com
patch subject: [PATCH v6 4/5] power: supply: power-supply-leds: Add charging_orange_full_green trigger for RGB LED
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240417/202404170705.Or8MFKNi-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240417/202404170705.Or8MFKNi-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404170705.Or8MFKNi-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/power/supply/power_supply_leds.c:42:3: error: implicit declaration of function 'led_mc_trigger_event' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
led_mc_trigger_event(psy->charging_orange_full_green_trig,
^
drivers/power/supply/power_supply_leds.c:42:3: note: did you mean 'led_trigger_event'?
include/linux/leds.h:489:6: note: 'led_trigger_event' declared here
void led_trigger_event(struct led_trigger *trigger, enum led_brightness event);
^
1 error generated.
vim +/led_mc_trigger_event +42 drivers/power/supply/power_supply_leds.c
21
22 static void power_supply_update_bat_leds(struct power_supply *psy)
23 {
24 union power_supply_propval status;
25 unsigned int intensity_green[3] = {255, 0, 0};
26 unsigned int intensity_orange[3] = {128, 0, 255};
27 unsigned int intensity_red[3] = {0, 0, 255};
28
29 if (power_supply_get_property(psy, POWER_SUPPLY_PROP_STATUS, &status))
30 return;
31
32 dev_dbg(&psy->dev, "%s %d\n", __func__, status.intval);
33
34 switch (status.intval) {
35 case POWER_SUPPLY_STATUS_FULL:
36 led_trigger_event(psy->charging_full_trig, LED_FULL);
37 led_trigger_event(psy->charging_trig, LED_OFF);
38 led_trigger_event(psy->full_trig, LED_FULL);
39 /* Going from blink to LED on requires a LED_OFF event to stop blink */
40 led_trigger_event(psy->charging_blink_full_solid_trig, LED_OFF);
41 led_trigger_event(psy->charging_blink_full_solid_trig, LED_FULL);
> 42 led_mc_trigger_event(psy->charging_orange_full_green_trig,
43 intensity_green,
44 ARRAY_SIZE(intensity_green),
45 LED_FULL);
46 break;
47 case POWER_SUPPLY_STATUS_CHARGING:
48 led_trigger_event(psy->charging_full_trig, LED_FULL);
49 led_trigger_event(psy->charging_trig, LED_FULL);
50 led_trigger_event(psy->full_trig, LED_OFF);
51 led_trigger_blink(psy->charging_blink_full_solid_trig, 0, 0);
52 led_mc_trigger_event(psy->charging_orange_full_green_trig,
53 intensity_orange,
54 ARRAY_SIZE(intensity_orange),
55 LED_FULL);
56 break;
57 default:
58 led_trigger_event(psy->charging_full_trig, LED_OFF);
59 led_trigger_event(psy->charging_trig, LED_OFF);
60 led_trigger_event(psy->full_trig, LED_OFF);
61 led_trigger_event(psy->charging_blink_full_solid_trig,
62 LED_OFF);
63 led_mc_trigger_event(psy->charging_orange_full_green_trig,
64 intensity_red,
65 ARRAY_SIZE(intensity_red),
66 LED_OFF);
67 break;
68 }
69 }
70
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread