* Re: [PATCH v3] platform/x86: dell-laptop: Implement platform_profile
[not found] <20240429164844.7544-2-lsanche@lyndeno.ca>
@ 2024-05-01 8:16 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-05-01 8:16 UTC (permalink / raw)
To: Lyndon Sanche
Cc: llvm, oe-kbuild-all, mario.limonciello, pali, W_Armin,
srinivas.pandruvada, ilpo.jarvinen, Matthew Garrett,
Hans de Goede, platform-driver-x86, linux-kernel,
Dell.Client.Kernel
Hi Lyndon,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.9-rc6 next-20240430]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Lyndon-Sanche/platform-x86-dell-laptop-Implement-platform_profile/20240430-135932
base: linus/master
patch link: https://lore.kernel.org/r/20240429164844.7544-2-lsanche%40lyndeno.ca
patch subject: [PATCH v3] platform/x86: dell-laptop: Implement platform_profile
config: i386-buildonly-randconfig-001-20240501 (https://download.01.org/0day-ci/archive/20240501/202405011636.CDJVLh7l-lkp@intel.com/config)
compiler: clang version 18.1.4 (https://github.com/llvm/llvm-project e6c3289804a67ea0bb6a86fadbe454dd93b8d855)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240501/202405011636.CDJVLh7l-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405011636.CDJVLh7l-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/platform/x86/dell/dell-laptop.c:2387:5: warning: no previous prototype for function 'thermal_init' [-Wmissing-prototypes]
2387 | int thermal_init(void)
| ^
drivers/platform/x86/dell/dell-laptop.c:2387:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
2387 | int thermal_init(void)
| ^
| static
>> drivers/platform/x86/dell/dell-laptop.c:2418:6: warning: no previous prototype for function 'thermal_cleanup' [-Wmissing-prototypes]
2418 | void thermal_cleanup(void)
| ^
drivers/platform/x86/dell/dell-laptop.c:2418:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
2418 | void thermal_cleanup(void)
| ^
| static
2 warnings generated.
vim +/thermal_init +2387 drivers/platform/x86/dell/dell-laptop.c
2386
> 2387 int thermal_init(void)
2388 {
2389 int ret;
2390 int supported_modes;
2391
2392 ret = thermal_get_supported_modes(&supported_modes);
2393 if (ret || !supported_modes)
2394 return 0;
2395
2396 thermal_handler = kzalloc(sizeof(*thermal_handler), GFP_KERNEL);
2397 if (!thermal_handler)
2398 return -ENOMEM;
2399 thermal_handler->profile_get = thermal_platform_profile_get;
2400 thermal_handler->profile_set = thermal_platform_profile_set;
2401
2402 if (supported_modes & DELL_QUIET)
2403 set_bit(PLATFORM_PROFILE_QUIET, thermal_handler->choices);
2404 if (supported_modes & DELL_COOL_BOTTOM)
2405 set_bit(PLATFORM_PROFILE_COOL, thermal_handler->choices);
2406 if (supported_modes & DELL_BALANCED)
2407 set_bit(PLATFORM_PROFILE_BALANCED, thermal_handler->choices);
2408 if (supported_modes & DELL_PERFORMANCE)
2409 set_bit(PLATFORM_PROFILE_PERFORMANCE, thermal_handler->choices);
2410
2411 // Clean up but do not fail
2412 if (platform_profile_register(thermal_handler))
2413 kfree(thermal_handler);
2414
2415 return 0;
2416 }
2417
> 2418 void thermal_cleanup(void)
2419 {
2420 if (thermal_handler) {
2421 platform_profile_remove();
2422 kfree(thermal_handler);
2423 }
2424 }
2425
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread