* Re: [PATCH v24 2/4] reset: npcm: register npcm8xx clock auxiliary bus device
[not found] <20240509192411.2432066-3-tmaimon77@gmail.com>
@ 2024-05-10 11:25 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-05-10 11:25 UTC (permalink / raw)
To: Tomer Maimon, mturquette, sboyd, p.zabel, robh+dt,
krzysztof.kozlowski+dt, tali.perry1, joel, venture, yuenn,
benjaminfair
Cc: llvm, oe-kbuild-all, devicetree, openbmc, Tomer Maimon, linux-clk,
linux-kernel
Hi Tomer,
kernel test robot noticed the following build errors:
[auto build test ERROR on clk/clk-next]
[also build test ERROR on pza/reset/next linus/master v6.9-rc7 next-20240510]
[cannot apply to pza/imx-drm/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Tomer-Maimon/dt-bindings-reset-npcm-add-clock-properties/20240510-072622
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
patch link: https://lore.kernel.org/r/20240509192411.2432066-3-tmaimon77%40gmail.com
patch subject: [PATCH v24 2/4] reset: npcm: register npcm8xx clock auxiliary bus device
config: i386-buildonly-randconfig-004-20240510 (https://download.01.org/0day-ci/archive/20240510/202405101939.Espij82X-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240510/202405101939.Espij82X-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405101939.Espij82X-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/reset/reset-npcm.c:391:2: error: call to undeclared function 'kfree'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
391 | kfree(rdev);
| ^
drivers/reset/reset-npcm.c:391:2: note: did you mean 'vfree'?
include/linux/vmalloc.h:162:13: note: 'vfree' declared here
162 | extern void vfree(const void *addr);
| ^
>> drivers/reset/reset-npcm.c:400:9: error: call to undeclared function 'kzalloc'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
400 | rdev = kzalloc(sizeof(*rdev), GFP_KERNEL);
| ^
drivers/reset/reset-npcm.c:400:9: note: did you mean 'vzalloc'?
include/linux/vmalloc.h:142:14: note: 'vzalloc' declared here
142 | extern void *vzalloc(unsigned long size) __alloc_size(1);
| ^
>> drivers/reset/reset-npcm.c:400:7: error: incompatible integer to pointer conversion assigning to 'struct npcm_clock_adev *' from 'int' [-Wint-conversion]
400 | rdev = kzalloc(sizeof(*rdev), GFP_KERNEL);
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/reset/reset-npcm.c:414:3: error: call to undeclared function 'kfree'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
414 | kfree(adev);
| ^
4 errors generated.
vim +/kfree +391 drivers/reset/reset-npcm.c
385
386 static void npcm_clock_adev_release(struct device *dev)
387 {
388 struct auxiliary_device *adev = to_auxiliary_dev(dev);
389 struct npcm_clock_adev *rdev = to_npcm_clock_adev(adev);
390
> 391 kfree(rdev);
392 }
393
394 static struct auxiliary_device *npcm_clock_adev_alloc(struct npcm_rc_data *rst_data, char *clk_name)
395 {
396 struct npcm_clock_adev *rdev;
397 struct auxiliary_device *adev;
398 int ret;
399
> 400 rdev = kzalloc(sizeof(*rdev), GFP_KERNEL);
401 if (!rdev)
402 return ERR_PTR(-ENOMEM);
403
404 rdev->base = rst_data->base;
405
406 adev = &rdev->adev;
407 adev->name = clk_name;
408 adev->dev.parent = rst_data->dev;
409 adev->dev.release = npcm_clock_adev_release;
410 adev->id = 555u;
411
412 ret = auxiliary_device_init(adev);
413 if (ret) {
414 kfree(adev);
415 return ERR_PTR(ret);
416 }
417
418 return adev;
419 }
420
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread