From: John Hubbard <jhubbard@nvidia.com>
To: Shuah Khan <shuah@kernel.org>
Cc: Beau Belgrave <beaub@linux.microsoft.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mark Brown <broonie@kernel.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Justin Stitt <justinstitt@google.com>,
Bill Wendling <morbo@google.com>,
sunliming <sunliming@kylinos.cn>,
Masami Hiramatsu <mhiramat@kernel.org>,
Valentin Obst <kernel@valentinobst.de>,
linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev, John Hubbard <jhubbard@nvidia.com>,
Nathan Chancellor <nathan@kernel.org>,
Ryan Roberts <ryan.roberts@arm.com>
Subject: [PATCH 1/2] selftests/lib.mk: handle both LLVM=1 and CC=clang builds
Date: Tue, 28 May 2024 19:08:41 -0700 [thread overview]
Message-ID: <20240529020842.127275-2-jhubbard@nvidia.com> (raw)
In-Reply-To: <20240529020842.127275-1-jhubbard@nvidia.com>
The kselftests may be built in a couple different ways:
make LLVM=1
make CC=clang
In order to handle both cases, set LLVM=1 if CC=clang. That way,the rest
of lib.mk, and any Makefiles that include lib.mk, can base decisions
solely on whether or not LLVM is set.
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
tools/testing/selftests/lib.mk | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
index 429535816dbd..2902787b89b2 100644
--- a/tools/testing/selftests/lib.mk
+++ b/tools/testing/selftests/lib.mk
@@ -1,5 +1,17 @@
# This mimics the top-level Makefile. We do it explicitly here so that this
# Makefile can operate with or without the kbuild infrastructure.
+
+# The kselftests may be built in a couple different ways:
+# make LLVM=1
+# make CC=clang
+#
+# In order to handle both cases, set LLVM=1 if CC=clang. That way,the rest of
+# lib.mk, and any Makefiles that include lib.mk, can base decisions solely on
+# whether or not LLVM is set.
+ifeq ($(CC),clang)
+ LLVM := 1
+endif
+
ifneq ($(LLVM),)
ifneq ($(filter %/,$(LLVM)),)
LLVM_PREFIX := $(LLVM)
--
2.45.1
next prev parent reply other threads:[~2024-05-29 2:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 2:08 [PATCH 0/2] selftests/lib.mk: LLVM=1, CC=clang, and warnings John Hubbard
2024-05-29 2:08 ` John Hubbard [this message]
2024-05-30 5:04 ` [PATCH 1/2] selftests/lib.mk: handle both LLVM=1 and CC=clang builds Muhammad Usama Anjum
2024-05-29 2:08 ` [PATCH 2/2] selftests/lib.mk: silence some clang warnings that gcc already ignores John Hubbard
2024-05-30 14:25 ` Shuah Khan
2024-05-30 19:28 ` John Hubbard
2024-05-31 14:30 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240529020842.127275-2-jhubbard@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=beaub@linux.microsoft.com \
--cc=broonie@kernel.org \
--cc=justinstitt@google.com \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mhiramat@kernel.org \
--cc=morbo@google.com \
--cc=naresh.kamboju@linaro.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=rostedt@goodmis.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=sunliming@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox