From: Shuah Khan <skhan@linuxfoundation.org>
To: John Hubbard <jhubbard@nvidia.com>, Shuah Khan <shuah@kernel.org>
Cc: Beau Belgrave <beaub@linux.microsoft.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mark Brown <broonie@kernel.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Justin Stitt <justinstitt@google.com>,
Bill Wendling <morbo@google.com>,
sunliming <sunliming@kylinos.cn>,
Masami Hiramatsu <mhiramat@kernel.org>,
Valentin Obst <kernel@valentinobst.de>,
linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev, Nathan Chancellor <nathan@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 2/2] selftests/lib.mk: silence some clang warnings that gcc already ignores
Date: Fri, 31 May 2024 08:30:27 -0600 [thread overview]
Message-ID: <e9597e75-948b-4ddc-8ca3-e9b188099f8f@linuxfoundation.org> (raw)
In-Reply-To: <e0f3563b-5cd7-4f3c-ae7c-4478c25d527c@nvidia.com>
On 5/30/24 13:28, John Hubbard wrote:
> On 5/30/24 7:25 AM, Shuah Khan wrote:
>> On 5/28/24 20:08, John Hubbard wrote:
>>> gcc defaults to silence (off) for the following warnings, but clang
>>> defaults to the opposite. These warnings are not useful for kselftests,
>>> so silence them for the clang builds as well:
>>
>> Please you add more information on why they aren't useful
>> for kselftests.
>
> Ah OK. My wording is a little misleading. The warnings are not useful
> for the *kernel*, as previous decided by the gcc settings when building
> the kernel. And it is only only due to including kernel data structures
> in the selftests, that we get the warnings on clang.
>
> So it is not something unique to the selftests. There is nothing that
> the selftests' code does that triggers these warnings, other than the
> act of including the kernel's data structures.
>
> I can post a v2 to update both the comment and the commit description.
>
Yes please.
thanks,
-- Shuah
prev parent reply other threads:[~2024-05-31 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 2:08 [PATCH 0/2] selftests/lib.mk: LLVM=1, CC=clang, and warnings John Hubbard
2024-05-29 2:08 ` [PATCH 1/2] selftests/lib.mk: handle both LLVM=1 and CC=clang builds John Hubbard
2024-05-30 5:04 ` Muhammad Usama Anjum
2024-05-29 2:08 ` [PATCH 2/2] selftests/lib.mk: silence some clang warnings that gcc already ignores John Hubbard
2024-05-30 14:25 ` Shuah Khan
2024-05-30 19:28 ` John Hubbard
2024-05-31 14:30 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9597e75-948b-4ddc-8ca3-e9b188099f8f@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=beaub@linux.microsoft.com \
--cc=broonie@kernel.org \
--cc=jhubbard@nvidia.com \
--cc=justinstitt@google.com \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mhiramat@kernel.org \
--cc=morbo@google.com \
--cc=naresh.kamboju@linaro.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=sunliming@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox