* Re: [PATCH v4 3/3] net: phy: bcm-phy-lib: Implement BroadR-Reach link modes
[not found] <20240604133654.2626813-4-kamilh@axis.com>
@ 2024-06-04 20:47 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-06-04 20:47 UTC (permalink / raw)
To: Kamil Horák - 2N, florian.fainelli, bcm-kernel-feedback-list,
andrew, hkallweit1
Cc: llvm, oe-kbuild-all, kamilh, netdev, linux-kernel
Hi Kamil,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net/main]
[also build test WARNING on net-next/main linus/master v6.10-rc2 next-20240604]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kamil-Hor-k-2N/net-phy-bcm54811-New-link-mode-for-BroadR-Reach/20240604-214127
base: net/main
patch link: https://lore.kernel.org/r/20240604133654.2626813-4-kamilh%40axis.com
patch subject: [PATCH v4 3/3] net: phy: bcm-phy-lib: Implement BroadR-Reach link modes
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240605/202406050455.vukoabPJ-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240605/202406050455.vukoabPJ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406050455.vukoabPJ-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/phy/broadcom.c:641:6: warning: operator '?:' has lower precedence than '|'; '|' will be evaluated first [-Wbitwise-conditional-parentheses]
on ? 0 : BCM54811_EXP_BROADREACH_LRE_OVERLAY_CTL_OVERRIDE_VAL);
~~ ^
drivers/net/phy/broadcom.c:641:6: note: place parentheses around the '|' expression to silence this warning
on ? 0 : BCM54811_EXP_BROADREACH_LRE_OVERLAY_CTL_OVERRIDE_VAL);
~~ ^
drivers/net/phy/broadcom.c:641:6: note: place parentheses around the '?:' expression to evaluate it first
on ? 0 : BCM54811_EXP_BROADREACH_LRE_OVERLAY_CTL_OVERRIDE_VAL);
~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
vim +641 drivers/net/phy/broadcom.c
614
615 static int bcm5481x_set_brrmode(struct phy_device *phydev, bool on)
616 {
617 int reg;
618 int err;
619
620 reg = bcm_phy_read_exp(phydev, BCM54810_EXP_BROADREACH_LRE_MISC_CTL);
621
622 if (on)
623 reg |= BCM54810_EXP_BROADREACH_LRE_MISC_CTL_EN;
624 else
625 reg &= ~BCM54810_EXP_BROADREACH_LRE_MISC_CTL_EN;
626
627 err = bcm_phy_write_exp(phydev, BCM54810_EXP_BROADREACH_LRE_MISC_CTL, reg);
628 if (err)
629 return err;
630
631 /* Update the abilities based on the current brr on/off setting */
632 err = bcm54811_read_abilities(phydev);
633 if (err)
634 return err;
635
636 /* Ensure LRE or IEEE register set is accessed according to the brr on/off,
637 * thus set the override
638 */
639 return bcm_phy_write_exp(phydev, BCM54811_EXP_BROADREACH_LRE_OVERLAY_CTL,
640 BCM54811_EXP_BROADREACH_LRE_OVERLAY_CTL_EN |
> 641 on ? 0 : BCM54811_EXP_BROADREACH_LRE_OVERLAY_CTL_OVERRIDE_VAL);
642 }
643
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread