Re: [PATCH v2 5/8] mm: extend working set reporting to memcgs

Re: [PATCH v2 5/8] mm: extend working set reporting to memcgs

[kernel test robot]

Hi Yuanchu,

kernel test robot noticed the following build errors:

[auto build test ERROR on driver-core/driver-core-testing]
[also build test ERROR on driver-core/driver-core-next driver-core/driver-core-linus staging/staging-testing staging/staging-next staging/staging-linus linus/master v6.10-rc2 next-20240604]
[cannot apply to akpm-mm/mm-everything]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yuanchu-Xie/mm-multi-gen-LRU-ignore-non-leaf-pmd_young-for-force_scan-true/20240604-100824
base:   driver-core/driver-core-testing
patch link:    https://lore.kernel.org/r/20240604020549.1017540-6-yuanchu%40google.com
patch subject: [PATCH v2 5/8] mm: extend working set reporting to memcgs
config: s390-randconfig-002-20240605 (https://download.01.org/0day-ci/archive/20240605/202406050600.hZAG0KTL-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project d7d2d4f53fc79b4b58e8d8d08151b577c3699d4a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240605/202406050600.hZAG0KTL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406050600.hZAG0KTL-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from mm/workingset_report.c:6:
   In file included from include/linux/memcontrol.h:21:
   In file included from include/linux/mm.h:2253:
   include/linux/vmstat.h:514:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     514 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   In file included from mm/workingset_report.c:14:
   include/linux/mm_inline.h:47:41: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
      47 |         __mod_lruvec_state(lruvec, NR_LRU_BASE + lru, nr_pages);
         |                                    ~~~~~~~~~~~ ^ ~~~
   include/linux/mm_inline.h:49:22: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
      49 |                                 NR_ZONE_LRU_BASE + lru, nr_pages);
         |                                 ~~~~~~~~~~~~~~~~ ^ ~~~
>> mm/workingset_report.c:45:37: error: incomplete definition of type 'struct mem_cgroup'
      45 |                 wsr->page_age_cgroup_file = &memcg->workingset_page_age_file;
         |                                              ~~~~~^
   include/linux/mm_types.h:33:8: note: forward declaration of 'struct mem_cgroup'
      33 | struct mem_cgroup;
         |        ^
>> mm/workingset_report.c:551:3: error: call to undeclared function 'cgroup_file_notify'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     551 |                 cgroup_file_notify(wsr->page_age_cgroup_file);
         |                 ^
   3 warnings and 2 errors generated.


vim +45 mm/workingset_report.c

    36	
    37	void wsr_init_lruvec(struct lruvec *lruvec)
    38	{
    39		struct wsr_state *wsr = &lruvec->wsr;
    40		struct mem_cgroup *memcg = lruvec_memcg(lruvec);
    41	
    42		memset(wsr, 0, sizeof(*wsr));
    43		mutex_init(&wsr->page_age_lock);
    44		if (memcg && !mem_cgroup_is_root(memcg))
  > 45			wsr->page_age_cgroup_file = &memcg->workingset_page_age_file;
    46	}
    47	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki