Re: [PATCH v3 1/3] ACPI/APEI: Add hest_parse_pcie_aer()

Re: [PATCH v3 1/3] ACPI/APEI: Add hest_parse_pcie_aer()

[kernel test robot]

Hi LeoLiu-oc,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pci/for-linus]
[also build test WARNING on rafael-pm/linux-next rafael-pm/bleeding-edge linus/master v6.10 next-20240718]
[cannot apply to pci/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/LeoLiu-oc/ACPI-APEI-Add-hest_parse_pcie_aer/20240718-144218
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git for-linus
patch link:    https://lore.kernel.org/r/20240718062405.30571-2-LeoLiu-oc%40zhaoxin.com
patch subject: [PATCH v3 1/3] ACPI/APEI: Add hest_parse_pcie_aer()
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20240719/202407190015.eutiIYQp-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240719/202407190015.eutiIYQp-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407190015.eutiIYQp-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/acpi/apei/hest.c:157:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
     157 |         case ACPI_HEST_TYPE_AER_ENDPOINT:
         |         ^
   drivers/acpi/apei/hest.c:157:2: note: insert '__attribute__((fallthrough));' to silence this warning
     157 |         case ACPI_HEST_TYPE_AER_ENDPOINT:
         |         ^
         |         __attribute__((fallthrough)); 
   drivers/acpi/apei/hest.c:157:2: note: insert 'break;' to avoid fall-through
     157 |         case ACPI_HEST_TYPE_AER_ENDPOINT:
         |         ^
         |         break; 
   drivers/acpi/apei/hest.c:160:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
     160 |         case ACPI_HEST_TYPE_AER_BRIDGE:
         |         ^
   drivers/acpi/apei/hest.c:160:2: note: insert '__attribute__((fallthrough));' to silence this warning
     160 |         case ACPI_HEST_TYPE_AER_BRIDGE:
         |         ^
         |         __attribute__((fallthrough)); 
   drivers/acpi/apei/hest.c:160:2: note: insert 'break;' to avoid fall-through
     160 |         case ACPI_HEST_TYPE_AER_BRIDGE:
         |         ^
         |         break; 
   drivers/acpi/apei/hest.c:163:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
     163 |         default:
         |         ^
   drivers/acpi/apei/hest.c:163:2: note: insert '__attribute__((fallthrough));' to silence this warning
     163 |         default:
         |         ^
         |         __attribute__((fallthrough)); 
   drivers/acpi/apei/hest.c:163:2: note: insert 'break;' to avoid fall-through
     163 |         default:
         |         ^
         |         break; 
   3 warnings generated.


vim +157 drivers/acpi/apei/hest.c

   144	
   145	static bool hest_source_is_pcie_aer(struct acpi_hest_header *hest_hdr, struct pci_dev *dev)
   146	{
   147		u16 hest_type = hest_hdr->type;
   148		u8 pcie_type = pci_pcie_type(dev);
   149		struct acpi_hest_aer_common *common;
   150	
   151		common = (struct acpi_hest_aer_common *)(hest_hdr + 1);
   152	
   153		switch (hest_type) {
   154		case ACPI_HEST_TYPE_AER_ROOT_PORT:
   155			if (pcie_type != PCI_EXP_TYPE_ROOT_PORT)
   156				return false;
 > 157		case ACPI_HEST_TYPE_AER_ENDPOINT:
   158			if (pcie_type != PCI_EXP_TYPE_ENDPOINT)
   159				return false;
   160		case ACPI_HEST_TYPE_AER_BRIDGE:
   161			if (pcie_type != PCI_EXP_TYPE_PCI_BRIDGE && pcie_type != PCI_EXP_TYPE_PCIE_BRIDGE)
   162				return false;
   163		default:
   164			return false;
   165		}
   166	
   167		if (common->flags & ACPI_HEST_GLOBAL)
   168			return true;
   169	
   170		if (hest_match_pci_devfn(common, dev))
   171			return true;
   172	
   173		return false;
   174	}
   175	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki