Re: [PATCH v10 8/9] iommu/arm-smmu-v3: Add in-kernel support for NVIDIA Tegra241 (Grace) CMDQV

Re: [PATCH v10 8/9] iommu/arm-smmu-v3: Add in-kernel support for NVIDIA Tegra241 (Grace) CMDQV

[kernel test robot]

Hi Nicolin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.11-rc1 next-20240729]
[cannot apply to joro-iommu/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nicolin-Chen/iommu-arm-smmu-v3-Issue-a-batch-of-commands-to-the-same-cmdq/20240729-072957
base:   linus/master
patch link:    https://lore.kernel.org/r/ca671f4d090546c21a0aba6fa4ddda8da26d4474.1722206275.git.nicolinc%40nvidia.com
patch subject: [PATCH v10 8/9] iommu/arm-smmu-v3: Add in-kernel support for NVIDIA Tegra241 (Grace) CMDQV
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20240729/202407292157.BauV7TPf-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project ccae7b461be339e717d02f99ac857cf0bc7d17fc)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240729/202407292157.BauV7TPf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407292157.BauV7TPf-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c:186: warning: Function parameter or struct member 'vintfs' not described in 'tegra241_cmdqv'
>> drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c:186: warning: Excess struct member 'vtinfs' description in 'tegra241_cmdqv'


vim +186 drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c

   160	
   161	/**
   162	 * struct tegra241_cmdqv - CMDQ-V for SMMUv3
   163	 * @smmu: SMMUv3 device
   164	 * @base: MMIO base address
   165	 * @irq: IRQ number
   166	 * @num_vintfs: Total number of VINTFs
   167	 * @num_vcmdqs: Total number of VCMDQs
   168	 * @num_lvcmdqs_per_vintf: Number of logical VCMDQs per VINTF
   169	 * @vintf_ids: VINTF id allocator
   170	 * @vtinfs: List of VINTFs
   171	 */
   172	struct tegra241_cmdqv {
   173		struct arm_smmu_device smmu;
   174	
   175		void __iomem *base;
   176		int irq;
   177	
   178		/* CMDQV Hardware Params */
   179		u16 num_vintfs;
   180		u16 num_vcmdqs;
   181		u16 num_lvcmdqs_per_vintf;
   182	
   183		struct ida vintf_ids;
   184	
   185		struct tegra241_vintf **vintfs;
 > 186	};
   187	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH v10 8/9] iommu/arm-smmu-v3: Add in-kernel support for NVIDIA Tegra241 (Grace) CMDQV

[Nicolin Chen]

On Mon, Jul 29, 2024 at 10:01:10PM +0800, kernel test robot wrote:
 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c:186: warning: Function parameter or struct member 'vintfs' not described in 'tegra241_cmdqv'
> >> drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c:186: warning: Excess struct member 'vtinfs' description in 'tegra241_cmdqv'
> 
> 
> vim +186 drivers/iommu/arm/arm-smmu-v3/tegra241-cmdqv.c
> 
>    160
>    161  /**
>    162   * struct tegra241_cmdqv - CMDQ-V for SMMUv3
>    163   * @smmu: SMMUv3 device
>    164   * @base: MMIO base address
>    165   * @irq: IRQ number
>    166   * @num_vintfs: Total number of VINTFs
>    167   * @num_vcmdqs: Total number of VCMDQs
>    168   * @num_lvcmdqs_per_vintf: Number of logical VCMDQs per VINTF
>    169   * @vintf_ids: VINTF id allocator

>    170   * @vtinfs: List of VINTFs

s/vtinfs/vintfs

Will include the typo fix in next ver.

Thanks
Nicolin

>    171   */
>    172  struct tegra241_cmdqv {
>    173          struct arm_smmu_device smmu;
>    174
>    175          void __iomem *base;
>    176          int irq;
>    177
>    178          /* CMDQV Hardware Params */
>    179          u16 num_vintfs;
>    180          u16 num_vcmdqs;
>    181          u16 num_lvcmdqs_per_vintf;
>    182
>    183          struct ida vintf_ids;
>    184
>    185          struct tegra241_vintf **vintfs;
>  > 186  };
>    187
> 
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki