* [broonie-ci:fileZMvsMi 36/37] sound/soc/sof/amd/acp.c:277:12: error: no member named 'rev' in 'struct sof_amd_acp_desc'
@ 2024-08-08 12:56 kernel test robot
2024-08-08 16:08 ` Mukunda,Vijendar
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2024-08-08 12:56 UTC (permalink / raw)
To: Vijendar Mukunda
Cc: llvm, oe-kbuild-all, Mark Brown, Ranjani Sridharan,
Pierre-Louis Bossart
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/ci.git fileZMvsMi
head: 43e41a7c8601d155489d208c40809f96727ea7fe
commit: 1b18e9f7176f8bec6673befed88068f03fa6d254 [36/37] ASoC: SOF: amd: remove unused variable from sof_amd_acp_desc structure
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240808/202408082001.IkvZrxTk-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240808/202408082001.IkvZrxTk-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408082001.IkvZrxTk-lkp@intel.com/
All errors (new ones prefixed by >>):
>> sound/soc/sof/amd/acp.c:277:12: error: no member named 'rev' in 'struct sof_amd_acp_desc'
277 | if (desc->rev == 3) {
| ~~~~ ^
sound/soc/sof/amd/acp.c:284:12: error: no member named 'rev' in 'struct sof_amd_acp_desc'
284 | if (desc->rev == 5 && !(adata->quirks && adata->quirks->skip_iram_dram_size_mod)) {
| ~~~~ ^
2 errors generated.
vim +277 sound/soc/sof/amd/acp.c
f063eba3e7a6ae Ajit Kumar Pandey 2021-11-17 232
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 233 int configure_and_run_sha_dma(struct acp_dev_data *adata, void *image_addr,
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 234 unsigned int start_addr, unsigned int dest_addr,
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 235 unsigned int image_length)
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 236 {
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 237 struct snd_sof_dev *sdev = adata->dev;
b1db244c716fe3 Mastan Katragadda 2023-06-30 238 const struct sof_amd_acp_desc *desc = get_chip_info(sdev->pdata);
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 239 unsigned int tx_count, fw_qualifier, val;
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 240 int ret;
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 241
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 242 if (!image_addr) {
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 243 dev_err(sdev->dev, "SHA DMA image address is NULL\n");
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 244 return -EINVAL;
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 245 }
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 246
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 247 val = snd_sof_dsp_read(sdev, ACP_DSP_BAR, ACP_SHA_DMA_CMD);
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 248 if (val & ACP_SHA_RUN) {
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 249 snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_CMD, ACP_SHA_RESET);
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 250 ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, ACP_SHA_DMA_CMD_STS,
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 251 val, val & ACP_SHA_RESET,
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 252 ACP_REG_POLL_INTERVAL,
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 253 ACP_REG_POLL_TIMEOUT_US);
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 254 if (ret < 0) {
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 255 dev_err(sdev->dev, "SHA DMA Failed to Reset\n");
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 256 return ret;
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 257 }
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 258 }
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 259
33c3d813330718 Cristian Ciocaltea 2024-02-20 260 if (adata->quirks && adata->quirks->signed_fw_image)
6a69b724b2f82b Venkata Prasad Potturu 2023-08-09 261 snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_INCLUDE_HDR, ACP_SHA_HEADER);
6a69b724b2f82b Venkata Prasad Potturu 2023-08-09 262
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 263 snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_STRT_ADDR, start_addr);
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 264 snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_DESTINATION_ADDR, dest_addr);
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 265 snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_MSG_LENGTH, image_length);
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 266 snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_CMD, ACP_SHA_RUN);
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 267
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 268 ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, ACP_SHA_TRANSFER_BYTE_CNT,
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 269 tx_count, tx_count == image_length,
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 270 ACP_REG_POLL_INTERVAL, ACP_DMA_COMPLETE_TIMEOUT_US);
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 271 if (ret < 0) {
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 272 dev_err(sdev->dev, "SHA DMA Failed to Transfer Length %x\n", tx_count);
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 273 return ret;
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 274 }
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 275
b1db244c716fe3 Mastan Katragadda 2023-06-30 276 /* psp_send_cmd only required for renoir platform (rev - 3) */
b1db244c716fe3 Mastan Katragadda 2023-06-30 @277 if (desc->rev == 3) {
bbdcd3d590cad7 Ajit Kumar Pandey 2022-04-21 278 ret = psp_send_cmd(adata, MBOX_ACP_SHA_DMA_COMMAND);
f063eba3e7a6ae Ajit Kumar Pandey 2021-11-17 279 if (ret)
f063eba3e7a6ae Ajit Kumar Pandey 2021-11-17 280 return ret;
b1db244c716fe3 Mastan Katragadda 2023-06-30 281 }
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 282
55d7bbe433467a Venkata Prasad Potturu 2023-12-19 283 /* psp_send_cmd only required for vangogh platform (rev - 5) */
094d11768f740f Cristian Ciocaltea 2024-02-20 284 if (desc->rev == 5 && !(adata->quirks && adata->quirks->skip_iram_dram_size_mod)) {
55d7bbe433467a Venkata Prasad Potturu 2023-12-19 285 /* Modify IRAM and DRAM size */
55d7bbe433467a Venkata Prasad Potturu 2023-12-19 286 ret = psp_send_cmd(adata, MBOX_ACP_IRAM_DRAM_FENCE_COMMAND | IRAM_DRAM_FENCE_2);
55d7bbe433467a Venkata Prasad Potturu 2023-12-19 287 if (ret)
55d7bbe433467a Venkata Prasad Potturu 2023-12-19 288 return ret;
55d7bbe433467a Venkata Prasad Potturu 2023-12-19 289 ret = psp_send_cmd(adata, MBOX_ACP_IRAM_DRAM_FENCE_COMMAND | MBOX_ISREADY_FLAG);
55d7bbe433467a Venkata Prasad Potturu 2023-12-19 290 if (ret)
55d7bbe433467a Venkata Prasad Potturu 2023-12-19 291 return ret;
55d7bbe433467a Venkata Prasad Potturu 2023-12-19 292 }
55d7bbe433467a Venkata Prasad Potturu 2023-12-19 293
2a2f5f2384b979 Ajye Huang 2022-12-05 294 ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, ACP_SHA_DSP_FW_QUALIFIER,
2a2f5f2384b979 Ajye Huang 2022-12-05 295 fw_qualifier, fw_qualifier & DSP_FW_RUN_ENABLE,
2a2f5f2384b979 Ajye Huang 2022-12-05 296 ACP_REG_POLL_INTERVAL, ACP_DMA_COMPLETE_TIMEOUT_US);
2a2f5f2384b979 Ajye Huang 2022-12-05 297 if (ret < 0) {
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 298 dev_err(sdev->dev, "PSP validation failed\n");
2a2f5f2384b979 Ajye Huang 2022-12-05 299 return ret;
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 300 }
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 301
2dc643cd756398 Pierre-Louis Bossart 2021-12-21 302 return 0;
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 303 }
0e44572a28a491 Ajit Kumar Pandey 2021-11-17 304
:::::: The code at line 277 was first introduced by commit
:::::: b1db244c716fe300e36428aeb0874913d2e0a91d ASoC: SOF: amd: add revision check for sending sha dma completion command
:::::: TO: Mastan Katragadda <Mastan.Katragadda@amd.com>
:::::: CC: Mark Brown <broonie@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [broonie-ci:fileZMvsMi 36/37] sound/soc/sof/amd/acp.c:277:12: error: no member named 'rev' in 'struct sof_amd_acp_desc'
2024-08-08 12:56 [broonie-ci:fileZMvsMi 36/37] sound/soc/sof/amd/acp.c:277:12: error: no member named 'rev' in 'struct sof_amd_acp_desc' kernel test robot
@ 2024-08-08 16:08 ` Mukunda,Vijendar
0 siblings, 0 replies; 2+ messages in thread
From: Mukunda,Vijendar @ 2024-08-08 16:08 UTC (permalink / raw)
To: kernel test robot
Cc: llvm, oe-kbuild-all, Mark Brown, Ranjani Sridharan,
Pierre-Louis Bossart
On 08/08/24 18:26, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/ci.git fileZMvsMi
> head: 43e41a7c8601d155489d208c40809f96727ea7fe
> commit: 1b18e9f7176f8bec6673befed88068f03fa6d254 [36/37] ASoC: SOF: amd: remove unused variable from sof_amd_acp_desc structure
> config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240808/202408082001.IkvZrxTk-lkp@intel.com/config)
> compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240808/202408082001.IkvZrxTk-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202408082001.IkvZrxTk-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>>> sound/soc/sof/amd/acp.c:277:12: error: no member named 'rev' in 'struct sof_amd_acp_desc'
Complete patch series is not applied, resulted in build failures.
Will resend patch series.
> 277 | if (desc->rev == 3) {
> | ~~~~ ^
> sound/soc/sof/amd/acp.c:284:12: error: no member named 'rev' in 'struct sof_amd_acp_desc'
> 284 | if (desc->rev == 5 && !(adata->quirks && adata->quirks->skip_iram_dram_size_mod)) {
> | ~~~~ ^
> 2 errors generated.
>
>
> vim +277 sound/soc/sof/amd/acp.c
>
> f063eba3e7a6ae Ajit Kumar Pandey 2021-11-17 232
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 233 int configure_and_run_sha_dma(struct acp_dev_data *adata, void *image_addr,
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 234 unsigned int start_addr, unsigned int dest_addr,
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 235 unsigned int image_length)
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 236 {
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 237 struct snd_sof_dev *sdev = adata->dev;
> b1db244c716fe3 Mastan Katragadda 2023-06-30 238 const struct sof_amd_acp_desc *desc = get_chip_info(sdev->pdata);
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 239 unsigned int tx_count, fw_qualifier, val;
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 240 int ret;
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 241
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 242 if (!image_addr) {
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 243 dev_err(sdev->dev, "SHA DMA image address is NULL\n");
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 244 return -EINVAL;
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 245 }
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 246
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 247 val = snd_sof_dsp_read(sdev, ACP_DSP_BAR, ACP_SHA_DMA_CMD);
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 248 if (val & ACP_SHA_RUN) {
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 249 snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_CMD, ACP_SHA_RESET);
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 250 ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, ACP_SHA_DMA_CMD_STS,
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 251 val, val & ACP_SHA_RESET,
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 252 ACP_REG_POLL_INTERVAL,
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 253 ACP_REG_POLL_TIMEOUT_US);
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 254 if (ret < 0) {
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 255 dev_err(sdev->dev, "SHA DMA Failed to Reset\n");
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 256 return ret;
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 257 }
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 258 }
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 259
> 33c3d813330718 Cristian Ciocaltea 2024-02-20 260 if (adata->quirks && adata->quirks->signed_fw_image)
> 6a69b724b2f82b Venkata Prasad Potturu 2023-08-09 261 snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_INCLUDE_HDR, ACP_SHA_HEADER);
> 6a69b724b2f82b Venkata Prasad Potturu 2023-08-09 262
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 263 snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_STRT_ADDR, start_addr);
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 264 snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_DESTINATION_ADDR, dest_addr);
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 265 snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_MSG_LENGTH, image_length);
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 266 snd_sof_dsp_write(sdev, ACP_DSP_BAR, ACP_SHA_DMA_CMD, ACP_SHA_RUN);
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 267
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 268 ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, ACP_SHA_TRANSFER_BYTE_CNT,
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 269 tx_count, tx_count == image_length,
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 270 ACP_REG_POLL_INTERVAL, ACP_DMA_COMPLETE_TIMEOUT_US);
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 271 if (ret < 0) {
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 272 dev_err(sdev->dev, "SHA DMA Failed to Transfer Length %x\n", tx_count);
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 273 return ret;
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 274 }
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 275
> b1db244c716fe3 Mastan Katragadda 2023-06-30 276 /* psp_send_cmd only required for renoir platform (rev - 3) */
> b1db244c716fe3 Mastan Katragadda 2023-06-30 @277 if (desc->rev == 3) {
> bbdcd3d590cad7 Ajit Kumar Pandey 2022-04-21 278 ret = psp_send_cmd(adata, MBOX_ACP_SHA_DMA_COMMAND);
> f063eba3e7a6ae Ajit Kumar Pandey 2021-11-17 279 if (ret)
> f063eba3e7a6ae Ajit Kumar Pandey 2021-11-17 280 return ret;
> b1db244c716fe3 Mastan Katragadda 2023-06-30 281 }
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 282
> 55d7bbe433467a Venkata Prasad Potturu 2023-12-19 283 /* psp_send_cmd only required for vangogh platform (rev - 5) */
> 094d11768f740f Cristian Ciocaltea 2024-02-20 284 if (desc->rev == 5 && !(adata->quirks && adata->quirks->skip_iram_dram_size_mod)) {
> 55d7bbe433467a Venkata Prasad Potturu 2023-12-19 285 /* Modify IRAM and DRAM size */
> 55d7bbe433467a Venkata Prasad Potturu 2023-12-19 286 ret = psp_send_cmd(adata, MBOX_ACP_IRAM_DRAM_FENCE_COMMAND | IRAM_DRAM_FENCE_2);
> 55d7bbe433467a Venkata Prasad Potturu 2023-12-19 287 if (ret)
> 55d7bbe433467a Venkata Prasad Potturu 2023-12-19 288 return ret;
> 55d7bbe433467a Venkata Prasad Potturu 2023-12-19 289 ret = psp_send_cmd(adata, MBOX_ACP_IRAM_DRAM_FENCE_COMMAND | MBOX_ISREADY_FLAG);
> 55d7bbe433467a Venkata Prasad Potturu 2023-12-19 290 if (ret)
> 55d7bbe433467a Venkata Prasad Potturu 2023-12-19 291 return ret;
> 55d7bbe433467a Venkata Prasad Potturu 2023-12-19 292 }
> 55d7bbe433467a Venkata Prasad Potturu 2023-12-19 293
> 2a2f5f2384b979 Ajye Huang 2022-12-05 294 ret = snd_sof_dsp_read_poll_timeout(sdev, ACP_DSP_BAR, ACP_SHA_DSP_FW_QUALIFIER,
> 2a2f5f2384b979 Ajye Huang 2022-12-05 295 fw_qualifier, fw_qualifier & DSP_FW_RUN_ENABLE,
> 2a2f5f2384b979 Ajye Huang 2022-12-05 296 ACP_REG_POLL_INTERVAL, ACP_DMA_COMPLETE_TIMEOUT_US);
> 2a2f5f2384b979 Ajye Huang 2022-12-05 297 if (ret < 0) {
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 298 dev_err(sdev->dev, "PSP validation failed\n");
> 2a2f5f2384b979 Ajye Huang 2022-12-05 299 return ret;
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 300 }
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 301
> 2dc643cd756398 Pierre-Louis Bossart 2021-12-21 302 return 0;
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 303 }
> 0e44572a28a491 Ajit Kumar Pandey 2021-11-17 304
>
> :::::: The code at line 277 was first introduced by commit
> :::::: b1db244c716fe300e36428aeb0874913d2e0a91d ASoC: SOF: amd: add revision check for sending sha dma completion command
>
> :::::: TO: Mastan Katragadda <Mastan.Katragadda@amd.com>
> :::::: CC: Mark Brown <broonie@kernel.org>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-08 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-08 12:56 [broonie-ci:fileZMvsMi 36/37] sound/soc/sof/amd/acp.c:277:12: error: no member named 'rev' in 'struct sof_amd_acp_desc' kernel test robot
2024-08-08 16:08 ` Mukunda,Vijendar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox