* Re: [PATCH 3/5] phy: stm32: Add support for STM32MP25 COMBOPHY.
[not found] <20240812120529.3564390-4-christian.bruel@foss.st.com>
@ 2024-08-12 20:14 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-08-12 20:14 UTC (permalink / raw)
To: Christian Bruel, vkoul, kishon, robh, krzk+dt, conor+dt,
mcoquelin.stm32, alexandre.torgue, p.zabel
Cc: llvm, oe-kbuild-all, linux-phy, devicetree, linux-stm32,
linux-arm-kernel, linux-kernel, fabrice.gasnier, Christian Bruel
Hi Christian,
kernel test robot noticed the following build errors:
[auto build test ERROR on atorgue-stm32/stm32-next]
[also build test ERROR on robh/for-next linus/master v6.11-rc3 next-20240812]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Christian-Bruel/MAINTAINERS-add-entry-for-ST-STM32MP25-COMBOPHY-driver/20240812-201003
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
patch link: https://lore.kernel.org/r/20240812120529.3564390-4-christian.bruel%40foss.st.com
patch subject: [PATCH 3/5] phy: stm32: Add support for STM32MP25 COMBOPHY.
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20240813/202408130307.IK7U1H7o-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project f86594788ce93b696675c94f54016d27a6c21d18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240813/202408130307.IK7U1H7o-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408130307.IK7U1H7o-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/phy/st/phy-stm32-combophy.c:12:
In file included from include/linux/phy/phy.h:17:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:26:
In file included from include/linux/kernel_stat.h:9:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
548 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
| ^
In file included from drivers/phy/st/phy-stm32-combophy.c:12:
In file included from include/linux/phy/phy.h:17:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:26:
In file included from include/linux/kernel_stat.h:9:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
| ^
In file included from drivers/phy/st/phy-stm32-combophy.c:12:
In file included from include/linux/phy/phy.h:17:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:26:
In file included from include/linux/kernel_stat.h:9:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
585 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
In file included from drivers/phy/st/phy-stm32-combophy.c:12:
In file included from include/linux/phy/phy.h:17:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:21:
In file included from include/linux/mm.h:2253:
include/linux/vmstat.h:514:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
514 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> drivers/phy/st/phy-stm32-combophy.c:134:8: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
134 | FIELD_PREP(STM32MP25_PCIEPRG_IMPCTRL_OHM, imp_of));
| ^
>> drivers/phy/st/phy-stm32-combophy.c:137:12: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
137 | imp_of = FIELD_GET(STM32MP25_PCIEPRG_IMPCTRL_OHM, val);
| ^
drivers/phy/st/phy-stm32-combophy.c:155:8: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
155 | FIELD_PREP(STM32MP25_PCIEPRG_IMPCTRL_VSWING, vswing_of));
| ^
7 warnings and 3 errors generated.
vim +/FIELD_PREP +134 drivers/phy/st/phy-stm32-combophy.c
107
108 static int stm32_impedance_tune(struct stm32_combophy *combophy)
109 {
110 u8 imp_size = ARRAY_SIZE(imp_lookup);
111 u8 vswing_size = ARRAY_SIZE(imp_lookup[0].vswing);
112 u8 imp_of, vswing_of;
113 u32 max_imp = imp_lookup[0].microohm;
114 u32 min_imp = imp_lookup[imp_size - 1].microohm;
115 u32 max_vswing = imp_lookup[imp_size - 1].vswing[vswing_size - 1];
116 u32 min_vswing = imp_lookup[0].vswing[0];
117 u32 val;
118
119 if (!of_property_read_u32(combophy->dev->of_node, "st,output-micro-ohms", &val)) {
120 if (val < min_imp || val > max_imp) {
121 dev_err(combophy->dev, "Invalid value %u for output ohm\n", val);
122 return -EINVAL;
123 }
124
125 for (imp_of = 0 ; imp_of < ARRAY_SIZE(imp_lookup); imp_of++)
126 if (imp_lookup[imp_of].microohm <= val)
127 break;
128
129 dev_dbg(combophy->dev, "Set %u micro-ohms output impedance\n",
130 imp_lookup[imp_of].microohm);
131
132 regmap_update_bits(combophy->regmap, SYSCFG_PCIEPRGCR,
133 STM32MP25_PCIEPRG_IMPCTRL_OHM,
> 134 FIELD_PREP(STM32MP25_PCIEPRG_IMPCTRL_OHM, imp_of));
135 } else {
136 regmap_read(combophy->regmap, SYSCFG_PCIEPRGCR, &val);
> 137 imp_of = FIELD_GET(STM32MP25_PCIEPRG_IMPCTRL_OHM, val);
138 }
139
140 if (!of_property_read_u32(combophy->dev->of_node, "st,output-vswing-microvolt", &val)) {
141 if (val < min_vswing || val > max_vswing) {
142 dev_err(combophy->dev, "Invalid value %u for output vswing\n", val);
143 return -EINVAL;
144 }
145
146 for (vswing_of = 0 ; vswing_of < ARRAY_SIZE(imp_lookup[imp_of].vswing); vswing_of++)
147 if (imp_lookup[imp_of].vswing[vswing_of] >= val)
148 break;
149
150 dev_dbg(combophy->dev, "Set %u microvolt swing\n",
151 imp_lookup[imp_of].vswing[vswing_of]);
152
153 regmap_update_bits(combophy->regmap, SYSCFG_PCIEPRGCR,
154 STM32MP25_PCIEPRG_IMPCTRL_VSWING,
155 FIELD_PREP(STM32MP25_PCIEPRG_IMPCTRL_VSWING, vswing_of));
156 }
157
158 return 0;
159 }
160
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread