Re: [RFC PATCH] function_graph: Support recording and printing the function return address

Re: [RFC PATCH] function_graph: Support recording and printing the function return address

[kernel test robot]

Hi Donglin,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.11-rc7]
[cannot apply to next-20240910]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Donglin-Peng/function_graph-Support-recording-and-printing-the-function-return-address/20240908-222737
base:   linus/master
patch link:    https://lore.kernel.org/r/20240908142544.1409032-1-dolinux.peng%40gmail.com
patch subject: [RFC PATCH] function_graph: Support recording and printing the function return address
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20240911/202409111115.i1L43FTN-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240911/202409111115.i1L43FTN-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409111115.i1L43FTN-lkp@intel.com/

All errors (new ones prefixed by >>):

>> kernel/trace/trace_functions_graph.c:830:3: error: call to undeclared function 'print_graph_retaddr'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     830 |                 print_graph_retaddr(s, call, tr->trace_flags, true);
         |                 ^
   1 error generated.


vim +/print_graph_retaddr +830 kernel/trace/trace_functions_graph.c

   797	
   798	static enum print_line_t
   799	print_graph_entry_nested(struct trace_iterator *iter,
   800				 struct ftrace_graph_ent_entry *entry,
   801				 struct trace_seq *s, int cpu, u32 flags)
   802	{
   803		struct ftrace_graph_ent *call = &entry->graph_ent;
   804		struct fgraph_data *data = iter->private;
   805		struct trace_array *tr = iter->tr;
   806		int i;
   807	
   808		if (data) {
   809			struct fgraph_cpu_data *cpu_data;
   810			int cpu = iter->cpu;
   811	
   812			cpu_data = per_cpu_ptr(data->cpu_data, cpu);
   813			cpu_data->depth = call->depth;
   814	
   815			/* Save this function pointer to see if the exit matches */
   816			if (call->depth < FTRACE_RETFUNC_DEPTH &&
   817			    !WARN_ON_ONCE(call->depth < 0))
   818				cpu_data->enter_funcs[call->depth] = call->func;
   819		}
   820	
   821		/* No time */
   822		print_graph_duration(tr, 0, s, flags | FLAGS_FILL_FULL);
   823	
   824		/* Function */
   825		for (i = 0; i < call->depth * TRACE_GRAPH_INDENT; i++)
   826			trace_seq_putc(s, ' ');
   827	
   828		trace_seq_printf(s, "%ps() {", (void *)call->func);
   829		if (flags & __TRACE_GRAPH_PRINT_RETADDR)
 > 830			print_graph_retaddr(s, call, tr->trace_flags, true);
   831		trace_seq_putc(s, '\n');
   832	
   833		if (trace_seq_has_overflowed(s))
   834			return TRACE_TYPE_PARTIAL_LINE;
   835	
   836		/*
   837		 * we already consumed the current entry to check the next one
   838		 * and see if this is a leaf.
   839		 */
   840		return TRACE_TYPE_NO_CONSUME;
   841	}
   842	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki