Re: [PATCH 13/21] pinctrl: Add drivers for ADI ADSP-SC5xx platform

Re: [PATCH 13/21] pinctrl: Add drivers for ADI ADSP-SC5xx platform

[kernel test robot]

Hi Arturs,

kernel test robot noticed the following build warnings:

[auto build test WARNING on da3ea35007d0af457a0afc87e84fddaebc4e0b63]

url:    https://github.com/intel-lab-lkp/linux/commits/Arturs-Artamonovs-via-B4-Relay/arm64-Add-ADI-ADSP-SC598-SoC/20240913-022308
base:   da3ea35007d0af457a0afc87e84fddaebc4e0b63
patch link:    https://lore.kernel.org/r/20240912-test-v1-13-458fa57c8ccf%40analog.com
patch subject: [PATCH 13/21] pinctrl: Add drivers for ADI ADSP-SC5xx platform
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20240914/202409141049.53oom3zJ-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project bf684034844c660b778f0eba103582f582b710c9)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240914/202409141049.53oom3zJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409141049.53oom3zJ-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/pinctrl/pinctrl-adsp.c:291: warning: Function parameter or struct member 'pctldev' not described in 'adsp_pinctrl_dt_node_to_map'
>> drivers/pinctrl/pinctrl-adsp.c:291: warning: Function parameter or struct member 'np' not described in 'adsp_pinctrl_dt_node_to_map'
>> drivers/pinctrl/pinctrl-adsp.c:291: warning: Function parameter or struct member 'map' not described in 'adsp_pinctrl_dt_node_to_map'
>> drivers/pinctrl/pinctrl-adsp.c:291: warning: Function parameter or struct member 'num_maps' not described in 'adsp_pinctrl_dt_node_to_map'
>> drivers/pinctrl/pinctrl-adsp.c:291: warning: expecting prototype for Handle device tree structures like(). Prototype was for adsp_pinctrl_dt_node_to_map() instead


vim +291 drivers/pinctrl/pinctrl-adsp.c

   271	
   272	/**
   273	 * Handle device tree structures like:
   274	 *
   275	 * pinctrl_uart0_hwflow: uart0_hwflow_pins {
   276	 *   pins_rxtx_ {
   277	 *     pinmux = <1>, <2>;
   278	 *     some-padconf-flag;
   279	 *   };
   280	 *   pins_hwflow {
   281	 *     pinmux = <3>, <4>;
   282	 *     some-other-padconf-flag;
   283	 *   };
   284	 * };
   285	 *
   286	 * where &pinctrl_uart0_hwflow is passed as an entry in pinctrl-0 on uart driver and
   287	 * enables all sub-pins at once
   288	 */
   289	static int adsp_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
   290		struct device_node *np, struct pinctrl_map **map, unsigned int *num_maps)
 > 291	{
   292		unsigned int reserved_maps;
   293		struct device_node *child_np;
   294		int ret;
   295	
   296		reserved_maps = 0;
   297		*map = NULL;
   298		*num_maps = 0;
   299	
   300		for_each_child_of_node(np, child_np) {
   301			ret = adsp_pinctrl_dt_subnode_to_map(pctldev, child_np, map,
   302						&reserved_maps, num_maps);
   303			if (ret < 0)
   304				goto exit;
   305		}
   306		return 0;
   307	
   308	exit:
   309		pinctrl_utils_free_map(pctldev, *map, *num_maps);
   310		return ret;
   311	}
   312	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki