Re: [PATCH RFC V4 1/1] ocfs2: reserve space for inline xattr before attaching reflink tree

Re: [PATCH RFC V4 1/1] ocfs2: reserve space for inline xattr before attaching reflink tree

[kernel test robot]

Hi Gautham,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.11-rc7 next-20240913]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Gautham-Ananthakrishna/ocfs2-reserve-space-for-inline-xattr-before-attaching-reflink-tree/20240912-144813
base:   linus/master
patch link:    https://lore.kernel.org/r/20240912064720.898600-1-gautham.ananthakrishna%40oracle.com
patch subject: [PATCH RFC V4 1/1] ocfs2: reserve space for inline xattr before attaching reflink tree
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20240915/202409150732.E4EsYwaz-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240915/202409150732.E4EsYwaz-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409150732.E4EsYwaz-lkp@intel.com/

All errors (new ones prefixed by >>):

>> fs/ocfs2/refcounttree.c:4197:25: error: incompatible pointer types initializing 'struct ocfs2_dinode *' with an expression of type 'char *' [-Werror,-Wincompatible-pointer-types]
    4197 |                         struct ocfs2_dinode *new_di = new_bh->b_data;
         |                                              ^        ~~~~~~~~~~~~~~
   fs/ocfs2/refcounttree.c:4198:25: error: incompatible pointer types initializing 'struct ocfs2_dinode *' with an expression of type 'char *' [-Werror,-Wincompatible-pointer-types]
    4198 |                         struct ocfs2_dinode *old_di = old_bh->b_data;
         |                                              ^        ~~~~~~~~~~~~~~
   2 errors generated.


vim +4197 fs/ocfs2/refcounttree.c

  4150	
  4151	static int __ocfs2_reflink(struct dentry *old_dentry,
  4152				   struct buffer_head *old_bh,
  4153				   struct inode *new_inode,
  4154				   bool preserve)
  4155	{
  4156		int ret;
  4157		struct inode *inode = d_inode(old_dentry);
  4158		struct buffer_head *new_bh = NULL;
  4159		struct ocfs2_inode_info *oi = OCFS2_I(inode);
  4160	
  4161		if (oi->ip_flags & OCFS2_INODE_SYSTEM_FILE) {
  4162			ret = -EINVAL;
  4163			mlog_errno(ret);
  4164			goto out;
  4165		}
  4166	
  4167		ret = filemap_fdatawrite(inode->i_mapping);
  4168		if (ret) {
  4169			mlog_errno(ret);
  4170			goto out;
  4171		}
  4172	
  4173		ret = ocfs2_attach_refcount_tree(inode, old_bh);
  4174		if (ret) {
  4175			mlog_errno(ret);
  4176			goto out;
  4177		}
  4178	
  4179		inode_lock_nested(new_inode, I_MUTEX_CHILD);
  4180		ret = ocfs2_inode_lock_nested(new_inode, &new_bh, 1,
  4181					      OI_LS_REFLINK_TARGET);
  4182		if (ret) {
  4183			mlog_errno(ret);
  4184			goto out_unlock;
  4185		}
  4186	
  4187		if ((oi->ip_dyn_features & OCFS2_HAS_XATTR_FL) &&
  4188		    (oi->ip_dyn_features & OCFS2_INLINE_XATTR_FL)) {
  4189			/*
  4190			 * Adjust extent record count to reserve space for extended attribute.
  4191			 * Inline data count had been adjusted in ocfs2_duplicate_inline_data().
  4192			 */
  4193			struct ocfs2_inode_info *new_oi = OCFS2_I(new_inode);
  4194	
  4195			if (!(new_oi->ip_dyn_features & OCFS2_INLINE_DATA_FL) &&
  4196			    !(ocfs2_inode_is_fast_symlink(new_inode))) {
> 4197				struct ocfs2_dinode *new_di = new_bh->b_data;
  4198				struct ocfs2_dinode *old_di = old_bh->b_data;
  4199				struct ocfs2_extent_list *el = &new_di->id2.i_list;
  4200				int inline_size = le16_to_cpu(old_di->i_xattr_inline_size);
  4201	
  4202				le16_add_cpu(&el->l_count, -(inline_size /
  4203						sizeof(struct ocfs2_extent_rec)));
  4204			}
  4205		}
  4206	
  4207		ret = ocfs2_create_reflink_node(inode, old_bh,
  4208						new_inode, new_bh, preserve);
  4209		if (ret) {
  4210			mlog_errno(ret);
  4211			goto inode_unlock;
  4212		}
  4213	
  4214		if (oi->ip_dyn_features & OCFS2_HAS_XATTR_FL) {
  4215			ret = ocfs2_reflink_xattrs(inode, old_bh,
  4216						   new_inode, new_bh,
  4217						   preserve);
  4218			if (ret) {
  4219				mlog_errno(ret);
  4220				goto inode_unlock;
  4221			}
  4222		}
  4223	
  4224		ret = ocfs2_complete_reflink(inode, old_bh,
  4225					     new_inode, new_bh, preserve);
  4226		if (ret)
  4227			mlog_errno(ret);
  4228	
  4229	inode_unlock:
  4230		ocfs2_inode_unlock(new_inode, 1);
  4231		brelse(new_bh);
  4232	out_unlock:
  4233		inode_unlock(new_inode);
  4234	out:
  4235		if (!ret) {
  4236			ret = filemap_fdatawait(inode->i_mapping);
  4237			if (ret)
  4238				mlog_errno(ret);
  4239		}
  4240		return ret;
  4241	}
  4242	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki