* Re: [PATCH 2/2 v2] PCI/P2PDMA: Modify p2p_dma_distance to detect P2P links
[not found] <1726733624-2142-3-git-send-email-shivasharan.srikanteshwara@broadcom.com>
@ 2024-09-20 5:51 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-09-20 5:51 UTC (permalink / raw)
To: Shivasharan S, linux-pci, bhelgaas, manivannan.sadhasivam, logang
Cc: llvm, oe-kbuild-all, linux-kernel, sumanesh.samanta,
sathya.prakash, sjeaugey, Shivasharan S
Hi Shivasharan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on pci/next]
[also build test WARNING on next-20240919]
[cannot apply to pci/for-linus linus/master v6.11]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Shivasharan-S/PCI-portdrv-Enable-reporting-inter-switch-P2P-links/20240919-162626
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link: https://lore.kernel.org/r/1726733624-2142-3-git-send-email-shivasharan.srikanteshwara%40broadcom.com
patch subject: [PATCH 2/2 v2] PCI/P2PDMA: Modify p2p_dma_distance to detect P2P links
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20240920/202409201333.LCx5k41f-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240920/202409201333.LCx5k41f-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409201333.LCx5k41f-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/pci/pcie/portdrv.c:86: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Determine if device supports Inter switch P2P links.
>> drivers/pci/pcie/portdrv.c:116: warning: Function parameter or struct member 'a' not described in 'pcie_port_is_p2p_link_available'
>> drivers/pci/pcie/portdrv.c:116: warning: Function parameter or struct member 'b' not described in 'pcie_port_is_p2p_link_available'
vim +116 drivers/pci/pcie/portdrv.c
106
107 /**
108 * pcie_port_is_p2p_link_available: Determine if a P2P link is available
109 * between the two upstream bridges. The serial number of the two devices
110 * will be compared and if they are same then it is considered that the P2P
111 * link is available.
112 *
113 * Return value: true if inter switch P2P is available, return false otherwise.
114 */
115 bool pcie_port_is_p2p_link_available(struct pci_dev *a, struct pci_dev *b)
> 116 {
117 u64 dsn_a, dsn_b;
118
119 /*
120 * Check if the devices support Inter switch P2P.
121 */
122 if (!pcie_port_is_p2p_supported(a) ||
123 !pcie_port_is_p2p_supported(b))
124 return false;
125
126 dsn_a = pci_get_dsn(a);
127 if (!dsn_a)
128 return false;
129
130 dsn_b = pci_get_dsn(b);
131 if (!dsn_b)
132 return false;
133
134 if (dsn_a == dsn_b)
135 return true;
136
137 return false;
138 }
139 EXPORT_SYMBOL_GPL(pcie_port_is_p2p_link_available);
140
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread