* Re: [PATCH v2 1/3] PCI: Add support for VF Resizable Bar extended cap
[not found] <20240919223557.1897608-2-michal.winiarski@intel.com>
@ 2024-09-20 8:36 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-09-20 8:36 UTC (permalink / raw)
To: Michał Winiarski, linux-pci, intel-xe, dri-devel,
linux-kernel, Bjorn Helgaas, Christian König,
Krzysztof Wilczyński
Cc: llvm, oe-kbuild-all, Rodrigo Vivi, Michal Wajdeczko,
Lucas De Marchi, Thomas Hellström, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Matt Roper, Michał Winiarski
Hi Michał,
kernel test robot noticed the following build warnings:
[auto build test WARNING on pci/for-linus]
[also build test WARNING on drm-xe/drm-xe-next drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.11 next-20240919]
[cannot apply to pci/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Micha-Winiarski/PCI-Add-support-for-VF-Resizable-Bar-extended-cap/20240920-064112
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git for-linus
patch link: https://lore.kernel.org/r/20240919223557.1897608-2-michal.winiarski%40intel.com
patch subject: [PATCH v2 1/3] PCI: Add support for VF Resizable Bar extended cap
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20240920/202409201629.QlC0MRbn-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240920/202409201629.QlC0MRbn-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409201629.QlC0MRbn-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/pci/pci.c:1920:20: warning: variable 'res' set but not used [-Wunused-but-set-variable]
1920 | struct resource *res;
| ^
1 warning generated.
vim +/res +1920 drivers/pci/pci.c
1903
1904 static void pci_restore_vf_rebar_state(struct pci_dev *pdev)
1905 {
1906 unsigned int pos, nbars, i;
1907 u32 ctrl;
1908
1909 if (!pdev->is_physfn)
1910 return;
1911
1912 pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_VF_REBAR);
1913 if (!pos)
1914 return;
1915
1916 pci_read_config_dword(pdev, pos + PCI_REBAR_CTRL, &ctrl);
1917 nbars = FIELD_GET(PCI_REBAR_CTRL_NBAR_MASK, ctrl);
1918
1919 for (i = 0; i < nbars; i++, pos += 8) {
> 1920 struct resource *res;
1921 int bar_idx, size;
1922
1923 pci_read_config_dword(pdev, pos + PCI_REBAR_CTRL, &ctrl);
1924 bar_idx = ctrl & PCI_REBAR_CTRL_BAR_IDX;
1925 res = pdev->resource + bar_idx;
1926 size = pci_rebar_bytes_to_size(pdev->sriov->barsz[bar_idx]);
1927 ctrl &= ~PCI_REBAR_CTRL_BAR_SIZE;
1928 ctrl |= FIELD_PREP(PCI_REBAR_CTRL_BAR_SIZE, size);
1929 pci_write_config_dword(pdev, pos + PCI_REBAR_CTRL, ctrl);
1930 }
1931 }
1932
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread