Re: [PATCH] dma-mapping: report unlimited DMA addressing in IOMMU DMA path

Re: [PATCH] dma-mapping: report unlimited DMA addressing in IOMMU DMA path

[kernel test robot]

Hi Leon,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.11 next-20240920]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Leon-Romanovsky/dma-mapping-report-unlimited-DMA-addressing-in-IOMMU-DMA-path/20240922-222704
base:   linus/master
patch link:    https://lore.kernel.org/r/92f61e9627003eeeee1bc5fc8b32e59d7c932a33.1727015030.git.leon%40kernel.org
patch subject: [PATCH] dma-mapping: report unlimited DMA addressing in IOMMU DMA path
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20240923/202409230026.u9gtxAOt-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240923/202409230026.u9gtxAOt-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409230026.u9gtxAOt-lkp@intel.com/

All errors (new ones prefixed by >>):

>> kernel/dma/mapping.c:930:3: error: expected ')'
     930 |                 return false;
         |                 ^
   kernel/dma/mapping.c:929:5: note: to match this '('
     929 |         if (unlikely(ops) || use_dma_iommu(dev)
         |            ^
   1 error generated.


vim +930 kernel/dma/mapping.c

8ddbe5943c0b12 Christoph Hellwig 2018-12-06  912  
8ae0e970319ac0 Jia He            2023-10-28  913  /**
8ae0e970319ac0 Jia He            2023-10-28  914   * dma_addressing_limited - return if the device is addressing limited
8ae0e970319ac0 Jia He            2023-10-28  915   * @dev:	device to check
8ae0e970319ac0 Jia He            2023-10-28  916   *
8ae0e970319ac0 Jia He            2023-10-28  917   * Return %true if the devices DMA mask is too small to address all memory in
8ae0e970319ac0 Jia He            2023-10-28  918   * the system, else %false.  Lack of addressing bits is the prime reason for
8ae0e970319ac0 Jia He            2023-10-28  919   * bounce buffering, but might not be the only one.
8ae0e970319ac0 Jia He            2023-10-28  920   */
8ae0e970319ac0 Jia He            2023-10-28  921  bool dma_addressing_limited(struct device *dev)
8ae0e970319ac0 Jia He            2023-10-28  922  {
a409d9600959f3 Jia He            2023-10-28  923  	const struct dma_map_ops *ops = get_dma_ops(dev);
a409d9600959f3 Jia He            2023-10-28  924  
a409d9600959f3 Jia He            2023-10-28  925  	if (min_not_zero(dma_get_mask(dev), dev->bus_dma_limit) <
a409d9600959f3 Jia He            2023-10-28  926  			 dma_get_required_mask(dev))
a409d9600959f3 Jia He            2023-10-28  927  		return true;
a409d9600959f3 Jia He            2023-10-28  928  
cc55895d61e71f Leon Romanovsky   2024-09-22  929  	if (unlikely(ops) || use_dma_iommu(dev)
a409d9600959f3 Jia He            2023-10-28 @930  		return false;
a409d9600959f3 Jia He            2023-10-28  931  	return !dma_direct_all_ram_mapped(dev);
8ae0e970319ac0 Jia He            2023-10-28  932  }
8ae0e970319ac0 Jia He            2023-10-28  933  EXPORT_SYMBOL_GPL(dma_addressing_limited);
8ae0e970319ac0 Jia He            2023-10-28  934  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki