* Re: [PATCH v2 net] net: Add error pointer check in bcmsysport.c
[not found] <20240923053900.1310-1-kdipendra88@gmail.com>
@ 2024-09-23 19:33 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-09-23 19:33 UTC (permalink / raw)
To: Dipendra Khadka, andrew, florian.fainelli, davem, edumazet,
bcm-kernel-feedback-list, kuba, pabeni
Cc: llvm, oe-kbuild-all, Dipendra Khadka, netdev, linux-kernel
Hi Dipendra,
kernel test robot noticed the following build errors:
[auto build test ERROR on net/main]
url: https://github.com/intel-lab-lkp/linux/commits/Dipendra-Khadka/net-Add-error-pointer-check-in-bcmsysport-c/20240923-134407
base: net/main
patch link: https://lore.kernel.org/r/20240923053900.1310-1-kdipendra88%40gmail.com
patch subject: [PATCH v2 net] net: Add error pointer check in bcmsysport.c
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240924/202409240323.wQPM6V1v-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240924/202409240323.wQPM6V1v-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409240323.wQPM6V1v-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/net/ethernet/broadcom/bcmsysport.c:2341:10: error: call to undeclared function 'PRT_ERR'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
2341 | return PRT_ERR(dp);
| ^
drivers/net/ethernet/broadcom/bcmsysport.c:2341:10: note: did you mean 'PTR_ERR'?
include/linux/err.h:49:33: note: 'PTR_ERR' declared here
49 | static inline long __must_check PTR_ERR(__force const void *ptr)
| ^
1 error generated.
vim +/PRT_ERR +2341 drivers/net/ethernet/broadcom/bcmsysport.c
2330
2331 static int bcm_sysport_map_queues(struct net_device *dev,
2332 struct net_device *slave_dev)
2333 {
2334 struct dsa_port *dp = dsa_port_from_netdev(slave_dev);
2335 struct bcm_sysport_priv *priv = netdev_priv(dev);
2336 struct bcm_sysport_tx_ring *ring;
2337 unsigned int num_tx_queues;
2338 unsigned int q, qp, port;
2339
2340 if (IS_ERR(dp))
> 2341 return PRT_ERR(dp);
2342
2343 /* We can't be setting up queue inspection for non directly attached
2344 * switches
2345 */
2346 if (dp->ds->index)
2347 return 0;
2348
2349 port = dp->index;
2350
2351 /* On SYSTEMPORT Lite we have twice as less queues, so we cannot do a
2352 * 1:1 mapping, we can only do a 2:1 mapping. By reducing the number of
2353 * per-port (slave_dev) network devices queue, we achieve just that.
2354 * This need to happen now before any slave network device is used such
2355 * it accurately reflects the number of real TX queues.
2356 */
2357 if (priv->is_lite)
2358 netif_set_real_num_tx_queues(slave_dev,
2359 slave_dev->num_tx_queues / 2);
2360
2361 num_tx_queues = slave_dev->real_num_tx_queues;
2362
2363 if (priv->per_port_num_tx_queues &&
2364 priv->per_port_num_tx_queues != num_tx_queues)
2365 netdev_warn(slave_dev, "asymmetric number of per-port queues\n");
2366
2367 priv->per_port_num_tx_queues = num_tx_queues;
2368
2369 for (q = 0, qp = 0; q < dev->num_tx_queues && qp < num_tx_queues;
2370 q++) {
2371 ring = &priv->tx_rings[q];
2372
2373 if (ring->inspect)
2374 continue;
2375
2376 /* Just remember the mapping actual programming done
2377 * during bcm_sysport_init_tx_ring
2378 */
2379 ring->switch_queue = qp;
2380 ring->switch_port = port;
2381 ring->inspect = true;
2382 priv->ring_map[qp + port * num_tx_queues] = ring;
2383 qp++;
2384 }
2385
2386 return 0;
2387 }
2388
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread